Merge pull request #13796 from n1hility/no-live-set

Prevent set command from updating a running instance
This commit is contained in:
OpenShift Merge Robot 2022-04-07 06:59:32 -04:00 committed by GitHub
commit d7ff08aff4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 0 deletions

View File

@ -439,6 +439,19 @@ func (v *MachineVM) Set(_ string, opts machine.SetOptions) error {
return nil
}
running, err := v.isRunning()
if err != nil {
return err
}
if running {
suffix := ""
if v.Name != machine.DefaultMachineName {
suffix = " " + v.Name
}
return errors.Errorf("cannot change setting while the vm is running, run 'podman machine stop%s' first", suffix)
}
changeCon, err := machine.AnyConnectionDefault(v.Name, v.Name+"-root")
if err != nil {
return err