mirror of https://github.com/containers/podman.git
Add problematic volume name to kube play error messages
When kube play fails to create a volume, it should say which volume had the problem so the user doesn't have to guess. For the following pod spec: apiVersion: v1 kind: Pod metadata: name: mypod spec: containers: - name: myfrontend image: nginx volumeMounts: - mountPath: "/var/www/html" name: mypd volumes: - name: mypd hostPath: path: /var/blah podman will now report: Error: failed to create volume "mypd": error in parsing HostPath in YAML: error checking path "/var/blah": stat /var/blah: no such file or directory Signed-off-by: Jordan Christiansen <xordspar0@gmail.com>
This commit is contained in:
parent
4d0b583340
commit
dce877c5ca
|
@ -116,7 +116,7 @@ func InitializeVolumes(specVolumes []v1.Volume) (map[string]*KubeVolume, error)
|
||||||
for _, specVolume := range specVolumes {
|
for _, specVolume := range specVolumes {
|
||||||
volume, err := VolumeFromSource(specVolume.VolumeSource)
|
volume, err := VolumeFromSource(specVolume.VolumeSource)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
return nil, errors.Wrapf(err, "failed to create volume %q", specVolume.Name)
|
||||||
}
|
}
|
||||||
|
|
||||||
volumes[specVolume.Name] = volume
|
volumes[specVolume.Name] = volume
|
||||||
|
|
|
@ -1449,6 +1449,7 @@ spec:
|
||||||
kube := podmanTest.Podman([]string{"play", "kube", kubeYaml})
|
kube := podmanTest.Podman([]string{"play", "kube", kubeYaml})
|
||||||
kube.WaitWithDefaultTimeout()
|
kube.WaitWithDefaultTimeout()
|
||||||
Expect(kube.ExitCode()).NotTo(Equal(0))
|
Expect(kube.ExitCode()).NotTo(Equal(0))
|
||||||
|
Expect(kube.ErrorToString()).To(ContainSubstring(defaultVolName))
|
||||||
})
|
})
|
||||||
|
|
||||||
It("podman play kube test with empty HostPath type volume", func() {
|
It("podman play kube test with empty HostPath type volume", func() {
|
||||||
|
|
Loading…
Reference in New Issue