Merge pull request #8201 from QiWang19/search-limit

Remove search limit since pagination support
This commit is contained in:
OpenShift Merge Robot 2020-10-30 20:34:28 +01:00 committed by GitHub
commit e5227b9d75
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 5 deletions

View File

@ -99,10 +99,6 @@ func imageSearch(cmd *cobra.Command, args []string) error {
return errors.Errorf("search requires exactly one argument")
}
if searchOptions.Limit > 100 {
return errors.Errorf("Limit %d is outside the range of [1, 100]", searchOptions.Limit)
}
if searchOptions.ListTags && len(searchOptions.Filters) != 0 {
return errors.Errorf("filters are not applicable to list tags result")
}

View File

@ -62,7 +62,7 @@ Note: use .Tag only if the --list-tags is set.
**--limit**=*limit*
Limit the number of results. This value can be in the range between 1 and 100. The default number of results is 25.
Limit the number of results (default 25).
Note: The results from each registry will be limited to this value.
Example if limit is 10 and two registries are being searched, the total
number of results will be 20, 10 from each (if there are at least 10 matches in each).

View File

@ -460,4 +460,11 @@ registries = ['{{.Host}}:{{.Port}}']`
search.WaitWithDefaultTimeout()
Expect(len(search.OutputToStringArray()) == 0).To(BeTrue())
})
It("podman search with limit over 100", func() {
search := podmanTest.Podman([]string{"search", "--limit", "130", "registry.redhat.io/rhel"})
search.WaitWithDefaultTimeout()
Expect(search.ExitCode()).To(Equal(0))
Expect(len(search.OutputToStringArray())).To(Equal(131))
})
})