containers
/
podman
mirror of https://github.com/containers/podman.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Only run TestGetImageConfigStopSignal on Linux 

... because the implementation requires Linux-only pkg/signal

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This commit is contained in:
Miloslav Trmač 2020-03-20 23:40:00 +01:00
parent 036531c006
commit e625b57d22
2 changed files with 29 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
pkg/util/utils_linux_test.go Normal file
View File

@ -0,0 +1,29 @@
package util
import (
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestGetImageConfigStopSignal(t *testing.T) {
// Linux-only beause parsing signal names is not supported on non-Linux systems by
// pkg/signal.
stopSignalValidInt, err := GetImageConfig([]string{"STOPSIGNAL 9"})
require.Nil(t, err)
assert.Equal(t, stopSignalValidInt.StopSignal, "9")
stopSignalValidString, err := GetImageConfig([]string{"STOPSIGNAL SIGKILL"})
require.Nil(t, err)
assert.Equal(t, stopSignalValidString.StopSignal, "9")
_, err = GetImageConfig([]string{"STOPSIGNAL 0"})
assert.NotNil(t, err)
_, err = GetImageConfig([]string{"STOPSIGNAL garbage"})
assert.NotNil(t, err)
_, err = GetImageConfig([]string{"STOPSIGNAL "})
assert.NotNil(t, err)
}

19
pkg/util/utils_test.go
View File

@ -219,25 +219,6 @@ func TestGetImageConfigLabel(t *testing.T) {
assert.NotNil(t, err)
}
func TestGetImageConfigStopSignal(t *testing.T) {
stopSignalValidInt, err := GetImageConfig([]string{"STOPSIGNAL 9"})
require.Nil(t, err)
assert.Equal(t, stopSignalValidInt.StopSignal, "9")
stopSignalValidString, err := GetImageConfig([]string{"STOPSIGNAL SIGKILL"})
require.Nil(t, err)
assert.Equal(t, stopSignalValidString.StopSignal, "9")
_, err = GetImageConfig([]string{"STOPSIGNAL 0"})
assert.NotNil(t, err)
_, err = GetImageConfig([]string{"STOPSIGNAL garbage"})
assert.NotNil(t, err)
_, err = GetImageConfig([]string{"STOPSIGNAL "})
assert.NotNil(t, err)
}
func TestGetImageConfigOnBuild(t *testing.T) {
onBuildOne, err := GetImageConfig([]string{"ONBUILD ADD /testdir1"})
require.Nil(t, err)