containers
/
podman
mirror of https://github.com/containers/podman.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve dns-search validation, empty domains now return an error 

Fixes #3426

Signed-off-by: Jhon Honce <jhonce@redhat.com>
This commit is contained in:
Jhon Honce 2019-08-08 08:59:35 -07:00
parent dc3816819d
commit f070913c6a
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cmd/podman/shared/create.go
View File

@ -627,6 +627,11 @@ func ParseCreateOpts(ctx context.Context, c *GenericCLIResults, runtime *libpod.
return nil, errors.Errorf("cannot pass additional search domains when also specifying '.'")
}
// Check for explicit dns-search domain of ''
if c.Changed("dns-search") && len(c.StringSlice("dns-search")) == 0 {
return nil, errors.Errorf("'' is not a valid domain")
}
// Validate domains are good
for _, dom := range c.StringSlice("dns-search") {
if dom == "." {