containers
/
podman
mirror of https://github.com/containers/podman.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
25,424 Commits 52 Branches 247 Tags 253 MiB
Commit Graph

7 Commits

Author SHA1 Message Date
Kir Kolyshkin 9d4e820264 Use golangci-lint fmt for pkg/bindings 
golangci-lint v2 introduced a new command, fmt, which runs configured
formatters (see formatters in .golangci.yml).

Use this for generated files. Drop separate goimports binary.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-03 10:41:14 -07:00
Kir Kolyshkin 275e77d1fa test/tools/vendor: drop ginkgo 
It appears[1] that ginkgo binary can be easily built from the top-level
vendor, so it does not make sense to have a second copy in test/tools
(and a hassle of keeping the two in sync).

Inspired by [1], [2], and a run of make localtest, which shows:

> Ginkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages:
>   Ginkgo CLI Version:
>     2.22.1
>   Mismatched package versions found:
>     2.23.3 used by podman, common, containers, parse, quadlet, rootlessport, abi, tunnel, libpod, events, file, shm, logs, annotations, libpod, utils, apiutil, auth, ctime, abi, expansion, utils, emulation, env, errorhandling, machine, compression, connection, define, ocipull, provider, proxyenv, qemu, command, shim, vmconfigs, rootless, signal, specgen, generate, kube, specgenutil, systemd, generate, notifyproxy, parser, timetype, trust, util, utils

[1]: af29bb5b6e (r2020246403)
[2]: e6c7ec94e2 (r2020230241)

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-01 14:24:41 -07:00
Paul Holzinger 5e9725983d
install swagger from source 
First of all this removes the need for a network connection, second
renovate can update the version as it is tracked in go.mod.

However the real important part is that the binary downloads are
broken[1]. For some reason the swagger created with them does not
include all the type information for the examples. However when building
from source the same thing works fine.

[1] https://github.com/go-swagger/go-swagger/issues/2842

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
 2024-04-12 15:26:34 +02:00
Oleksandr Redko 2a2d0b0e18 chore: delete obsolete // +build lines 
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
 2024-01-04 11:53:38 +02:00
Paul Holzinger 445815036f
update to ginkgo v2 
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
 2023-05-02 11:27:35 +02:00
Paul Holzinger c7827957a4
ginkgo: restructure install work flow 
- move the ginkgo deps into test/tools which is more consitent with the
  other tools there, listing in dependencies always causes errors with
  linters
- do not install it globally on the system, instead we use it in a
  subdir of this project

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
 2022-11-25 14:41:43 +01:00
Paul Holzinger 9166894c69
vendor test dependencies instead of installing via network 
We can vendor the test dependencies such as go-md2man, git-validation
and goimports. This allows us to always install the same version as
specified in go.mod. Also we do not rely on a network connection for
this.

The advantage with this method is that dependabot will also update the
dependencies for us and we do not have to hardcode versions in the
Makefile.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
 2022-05-03 18:43:18 +02:00