906af5bbc6
Move `getDevNullFiles` into a common file
...
Moves `getDevNullFiles` into a new common file,
`pkg/machine/machine_common.go`, preventing the re-implementation of the
function across the different hypervisor implementations.
Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2023-08-01 08:52:23 -04:00
7d5f9de7a9
Merge pull request #19423 from rhatdan/man
...
[CI:DOCS] Mention no comment lines in Containerfile.in podman-build man page
2023-08-01 12:16:25 +02:00
57aa4850fc
Merge pull request #19434 from rhatdan/userns
...
Set default userns from containers.conf file
2023-08-01 12:00:57 +02:00
843f663c81
Merge pull request #19460 from containers/renovate/github.com-digitalocean-go-qemu-digest
...
Update github.com/digitalocean/go-qemu digest to 2e3d018
2023-08-01 10:02:42 +02:00
a9948dafc9
Merge pull request #19455 from jakecorrenti/qemu-machine-funcs-to-methods
...
Convert new QEMU functions to methods with documentation
2023-08-01 09:43:17 +02:00
0ecda592c9
Merge pull request #19350 from jakecorrenti/breakup-applehv-machine-funcs
...
Breakup applehv machine funcs
2023-08-01 09:22:20 +02:00
89f1fdc7f2
Update github.com/digitalocean/go-qemu digest to 2e3d018
...
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-08-01 02:51:46 +00:00
dcb7f5e130
Merge pull request #19450 from cevich/use_stable_go
...
[CI:DOCS] GHA: Use stable go for Mac/Win builds
2023-08-01 00:12:26 +02:00
d6847b19c8
Convert QEMU functions to methods with documentation
...
Converts new functions added in #19311 to methods and adds
documentation.
[NO NEW TESTS NEEDED]
Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2023-07-31 15:55:47 -04:00
0d21f8986b
Merge pull request #19419 from Romain-Geissler-1A/remove-EOF-error-empty-context-with-podman-remote
...
Don't log EOF error when using podman --remote build with an empty context directory.
2023-07-31 21:43:36 +02:00
ad9015f478
Merge pull request #19096 from BlackHole1/support-new-line
...
feat(env): support multiline in env-file
2023-07-31 21:40:13 +02:00
3ddde2023a
Merge pull request #19413 from vrothberg/fix-19368
...
API: kill: return 409 on invalid state
2023-07-31 21:37:21 +02:00
30ad23e559
Merge pull request #19444 from Luap99/net-none-netns-path
...
inspect with network=none show SandboxKey netns path
2023-07-31 21:34:22 +02:00
6930f39a66
Update docs/source/markdown/podman-build.1.md.in
...
Co-authored-by: Valentin Rothberg <vrothberg@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-07-31 15:20:58 -04:00
a52cefe6b9
Merge pull request #19431 from rhatdan/man1
...
[CI:DOCS] Improve the description of fields in podman-stats man page
2023-07-31 21:01:24 +02:00
e1114f03ce
do not redefine gobuild for eln
...
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-07-31 14:55:52 -04:00
6b404759f2
Merge pull request #19422 from rhatdan/read-only
...
make /dev & /dev/shm read/only when --read-only --read-only-tmpfs=false
2023-07-31 20:24:16 +02:00
39341f283c
Set default userns from containers.conf file
...
Fixed: https://github.com/containers/podman/issues/19432
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-07-31 14:21:06 -04:00
94743d4e76
Merge pull request #19451 from rhatdan/quadlet
...
[CI:DOCS] Mention TimeoutStartSec in quadlet man page
2023-07-31 14:17:53 -04:00
9e91873c26
Merge pull request #19435 from rhatdan/codespell
...
Codespell fixups
2023-07-31 17:50:00 +02:00
4f1f88d7c3
Mention TimeoutStartSec in quadlet man page
...
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-07-31 11:43:56 -04:00
d351d47d49
Merge pull request #19449 from edsantiago/reenable_container_checkpoint_tests
...
CI: e2e: reenable containerized checkpoint tests
2023-07-31 17:42:17 +02:00
ada71889c7
inspect with network=none show SandboxKey netns path
...
We do not use any special netns path for the netns=none case, however
callers that inspect that may still wish to join the netns path directly
without extra work to figure out /proc/$pid/ns/net.
Fixes #16716
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-07-31 17:40:41 +02:00
93f4cc1b51
[CI:DOCS] GHA: Use stable go for Mac/Win builds
...
Having hard-coded versions burried under a hidden directory is ripe for
maintenance headaches. Use the latest 'stable' version, since this will
be "close enough" to what we test in CI.
Ref: https://github.com/containers/podman/discussions/19404
Signed-off-by: Chris Evich <cevich@redhat.com>
2023-07-31 10:43:53 -04:00
ff7d287fc0
Breakup AppleHV machine funcs
...
The functions for AppleHV's VM interface implementation (machine.go) had
quite large functions. Pulls out some code that could be moved to its
own function for easier readability and maintainability.
[NO NEW TESTS NEEDED]
Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2023-07-31 10:41:18 -04:00
330e51960e
Merge pull request #19364 from jakecorrenti/breakup-hyperv-machine-funcs
...
Breakup hyperv machine funcs
2023-07-31 16:25:03 +02:00
320fc6ca36
Merge pull request #19401 from jakecorrenti/fix-hyperv-load-from-json-name
...
Fix HyperV loadMachineFromJSON function name
2023-07-31 15:46:04 +02:00
64873e322c
Codespell fixups
...
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-07-31 09:38:46 -04:00
acbe7703f9
Update docs/source/markdown/podman-stats.1.md.in
...
Co-authored-by: Valentin Rothberg <vrothberg@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-07-31 09:31:33 -04:00
0b7157e3b3
CI: e2e: reenable containerized checkpoint tests
...
And lo, a miracle occurred. Containerized checkpoint tests are
no longer hanging. Reenable them.
(Followup miracle: tests are still passing, after a year of not
running!)
Closes : #15015
Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-07-31 06:58:09 -06:00
c67ef7c1a1
docs(env-file): improve document description
...
Signed-off-by: Black-Hole1 <bh@bugs.cc>
2023-07-31 20:24:26 +08:00
4ee31dc37f
Don't log EOF error when using podman --remote build with an empty context directory.
...
Closes #15921 .
Signed-off-by: Romain Geissler <romain.geissler@amadeus.com>
2023-07-31 12:00:01 +00:00
f2794f9a82
API: kill: return 409 on invalid state
...
If the container isn't running, make sure to return 409 as specified in
the Docker API [1] and the Podman reference.
[1] https://docs.docker.com/engine/api/v1.43/#tag/Container/operation/ContainerKill
Fixes : #19368
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-07-31 11:17:58 +02:00
170a78631b
feat(env): support multiline in env-file
...
Close: https://github.com/containers/podman/issues/18724
Signed-off-by: Black-Hole1 <bh@bugs.cc>
2023-07-31 09:59:45 +08:00
19deb6a346
Adds documentation to new functions that were added
...
Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2023-07-30 19:58:03 -04:00
481143e584
`startHostNetworking`: get DevNull files
...
[NO NEW TESTS NEEDED]
Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2023-07-30 18:39:45 -04:00
13da82466a
`Remove`: remove network and ready sockets from registry
...
Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2023-07-30 18:39:41 -04:00
d896431b28
`Remove`: remove files and connections
...
Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2023-07-30 18:31:30 -04:00
32265e1f64
`Remove`: collect files to destroy
...
Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2023-07-30 18:24:13 -04:00
381b103dd1
`Init`: read and split ign file
...
Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2023-07-30 18:22:49 -04:00
aa6827a67a
`Init`: write ign config
...
Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2023-07-30 18:21:48 -04:00
cc30639d7b
`Init`: add network and registry socks to registry
...
Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2023-07-30 18:19:34 -04:00
78d3b549cd
`Init`: add SSH conns to podman sock
...
Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2023-07-30 18:16:32 -04:00
630e7ba394
Improve the description of fields in podman-stats man page
...
Fixes: https://github.com/containers/podman/issues/15146
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-07-30 06:28:30 -04:00
22a8b68866
make /dev & /dev/shm read/only when --read-only --read-only-tmpfs=false
...
The intention of --read-only-tmpfs=fals when in --read-only mode was to
not allow any processes inside of the container to write content
anywhere, unless the caller also specified a volume or a tmpfs. Having
/dev and /dev/shm writable breaks this assumption.
Fixes: https://github.com/containers/podman/issues/12937
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-07-30 06:09:30 -04:00
663fe9446b
Mention no comment lines in Containerfile.in podman-build man page
...
Fixes: https://github.com/containers/podman/issues/13070
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-07-29 07:09:02 -04:00
e973d15c35
[CI:BUILD] RPM: define gobuild macro for rhel/centos stream
...
The current gobuild macro doesn't account for build tags on both c9s and
c8s. This is currently causing copr build failures for c9s.
Ref: https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/build/6220412/
This commit will define gobuild for all those envs until gobuild is
fixed by default.
Refs:
c9s bz: https://bugzilla.redhat.com/show_bug.cgi?id=2227328
c8s bz: https://bugzilla.redhat.com/show_bug.cgi?id=2227331
[NO NEW TESTS NEEDED]
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-07-28 14:11:42 -04:00
b6a52f1f8b
Merge pull request #19333 from lsm5/conditionalize-gvproxy
...
[CI:BUILD] RPM: separate out gvproxy for copr and rawhide
2023-07-28 19:58:19 +02:00
7c1406f822
Merge pull request #19399 from ashley-cui/cimac
...
[CI:DOCS] Build and Sign Mac Pkginstaller
2023-07-28 17:54:37 +02:00
837bc25681
Fix HyperV loadMachineFromJSON function name
...
Re-names HyperV function that was copied from the applehv
implementation and not changed. Makes the function a method of
`HyperVMachine`.
[NO NEW TESTS NEEDED]
Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
2023-07-28 11:14:13 -04:00
Jake Correnti
OpenShift Merge Robot
renovate[bot]
Daniel J Walsh
Lokesh Mandvekar
Paul Holzinger
Chris Evich
Ed Santiago
Black-Hole1
Romain Geissler
Valentin Rothberg