69085570f7
Merge pull request #10070 from TomSweeneyRedHat/dev/tsweeney/fixintrotypo
...
[CI:DOCS] Fix introduction page typo
2021-04-19 06:39:53 -04:00
21ae073034
Merge pull request #10069 from EduardoVega/clean-mounts-9618
...
Ensure mount destination is clean, no trailing slash
2021-04-19 05:01:52 -04:00
18d462c41b
Ensure mount destination is clean, no trailing slash
...
Signed-off-by: Eduardo Vega <edvegavalerio@gmail.com>
2021-04-18 09:57:04 -06:00
4ffaa50d05
add it for inspect pidfile
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-18 21:29:12 +08:00
53a1edc3db
[CI:DOCS] Fix introduction page typo
...
Fixes a small typo on the introduction pages.
Fixes : #10042
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2021-04-17 15:13:16 -04:00
a35e16c234
support pidfile on container restore
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-18 00:02:50 +08:00
a1002beb78
fix start it
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 23:35:27 +08:00
4ce7aa6ee8
skip pidfile test on remote
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 22:30:43 +08:00
022bf589c8
improve document
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 21:25:11 +08:00
728b73d7c4
set pidfile default value int containerconfig
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 21:15:23 +08:00
b963a5eb4a
add pidfile in inspection
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 20:56:08 +08:00
f3f7ae5cdd
add pidfile it for container start
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 20:42:21 +08:00
c9f347e9a8
skip pidfile it on remote
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 20:33:37 +08:00
6ff56ab50a
Merge pull request #10018 from jmguzik/more-network-bindings-tests
...
Add network bindings tests: remove and list
2021-04-17 06:35:49 -04:00
676c33f079
Merge pull request #10043 from Luap99/play-kube-ip
...
add --ip to podman play kube
2021-04-17 05:52:51 -04:00
80c1dd0651
Modify according to comments
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-17 16:08:08 +08:00
6af4c08a50
WIP: drop test requirement
...
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2021-04-16 17:45:52 -04:00
90d7f67138
runtime: bump required conmon version
...
2.0.24 introduced the new behavior with --full-attach, allowing podman to no longer use the socketDir
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2021-04-16 17:45:52 -04:00
b2c6663a9f
runtime: return findConmon to libpod
...
I believe moving the conmon probing code to c/common wasn't the best strategy.
Different container engines have different requrements of which conmon version is required
(based on what flags they use).
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2021-04-16 17:45:52 -04:00
452b9e204f
oci: drop ExecContainerCleanup
...
without the socketsDir, we no longer need to worry about cleaning up after an exec.
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2021-04-16 17:45:52 -04:00
fdfff1dab2
oci: use `--full-path` option for conmon
...
and stop relying on socket path
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2021-04-16 17:45:52 -04:00
6708bc235f
use AttachSocketPath when removing conmon files
...
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2021-04-16 17:45:52 -04:00
f331c9445f
hide conmon-pidfile flag on remote mode
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-16 23:10:19 +08:00
35b62ef19f
Merge pull request #10050 from Luap99/image-prune-panic
...
Fix possible panic in libpod/image/prune.go
2021-04-16 07:43:38 -04:00
12bcfa360d
Fix possible panic in libpod/image/prune.go
...
podman image prune paniced locally for me. The error handling was not
done correctly and we could end up with a nil pointer dereference.
[NO TESTS NEEDED] I have no idea how I could force an error in img.Size().
Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-04-16 11:21:47 +02:00
4c88035f09
Merge pull request #10021 from zhangguanzhang/invalid-save-expression
...
Fix invalid expression in save command
2021-04-16 04:28:14 -04:00
d7292dbf27
add --ip to podman play kube
...
Add a new --ip flag to podman play kube. This is used to specify a
static IP address which should be used for the pod. This option can be
specified several times because play kube can create more than one pod.
Fixes #8442
Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-04-16 09:55:03 +02:00
e16200ac9f
add flag autocomplete
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-16 15:52:59 +08:00
4fb5fee412
add ut
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-16 15:12:57 +08:00
8fbe06b8cb
add flag "--pidfile" for podman create/run
...
Signed-off-by: chenkang <kongchen28@gmail.com>
2021-04-16 13:43:14 +08:00
b82ae19acf
Merge pull request #10046 from edsantiago/bats
...
system tests: build --pull-never: deal with flakes
2021-04-16 01:19:12 -04:00
1af1c35efb
Add network bindings tests: remove and list
...
Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
2021-04-15 22:41:06 +02:00
373f15f617
Merge pull request #10010 from lsm5/GO111MODULE-OFF-fix-build
...
fix build with with GO111MODULE=off
2021-04-15 16:03:10 -04:00
f7ab6b8554
Merge pull request #10045 from Luap99/compose-test-debug
...
compose test: diagnose flakes v3
2021-04-15 15:18:09 -04:00
81ce39f10b
Merge pull request #10044 from Luap99/fix-10015
...
podman play kube apply correct log driver
2021-04-15 14:26:09 -04:00
501b4751a3
Fix build with GO111MODULE=off
...
Distro builds on Fedora and Kubic projects use GO111MODULE=off
by default which are currently failing. This commit fixes it and
going forward, podman CI will also indicate failures in rpm builds.
The additional LDFLAGS have been removed from the spec file
which is not ideal. But, currently we only use the spec file
to check if the rpm builds fine. We can fix the LDFLAGS in a
later commit when we're working on packit integration.
conmon build has also been removed from podman.spec.in because the COPR
for which it was provided has been discontinued.
[NO TESTS NEEDED]
Fixes : #10009
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2021-04-15 14:24:39 -04:00
cfcf5f9ddc
system tests: build --pull-never: deal with flakes
...
This test continues to flake on podman-remote (especially Ubuntu)
even after #10030 and #10034 . I give up. Stop checking the error
message in podman-remote tests.
Signed-off-by: Ed Santiago <santiago@redhat.com>
2021-04-15 12:15:15 -06:00
4f0a080fdc
compose test: diagnose flakes v3
...
From the debug output we know that rootlesskit does not bind the port
correctly. The rootlesskit port forwarder has a quite a few debug
statements so lets see the debug log when the test fails. Also check
if it binded the port inside the rootless cni namespace.
Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-04-15 20:05:39 +02:00
1685c2dc36
podman play kube apply correct log driver
...
The --log-driver flag was silently ignored by podman play kube. This
regression got introduced during the play kube rework.
Unfortunately the test for this was skipped for no good reason.
Fixes #10015
Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2021-04-15 18:24:22 +02:00
b074e80351
Merge pull request #10035 from pablofsf/volume-chown-docs
...
[CI:DOCS] Update documentation of podman-run to reflect volume "U" option
2021-04-15 09:32:35 -04:00
0a13b1a245
Merge pull request #10040 from containers/dependabot/go_modules/github.com/rootless-containers/rootlesskit-0.14.2
...
Bump github.com/rootless-containers/rootlesskit from 0.14.1 to 0.14.2
2021-04-15 09:25:37 -04:00
405331ff90
Merge pull request #10032 from nalind/trace-level
...
Recognize "trace" logging, and use it for lone errors at exit
2021-04-15 09:08:37 -04:00
21827f6a0c
Fixes podman-remote save to directories does not work
...
Signed-off-by: zhangguanzhang <zhangguanzhang@qq.com>
2021-04-15 19:24:46 +08:00
b2a3bb4a61
Merge pull request #10034 from rhatdan/build
...
Fix flake on failed podman-remote build : try 2
2021-04-15 07:18:35 -04:00
495adab26c
Bump github.com/rootless-containers/rootlesskit from 0.14.1 to 0.14.2
...
Bumps [github.com/rootless-containers/rootlesskit](https://github.com/rootless-containers/rootlesskit ) from 0.14.1 to 0.14.2.
- [Release notes](https://github.com/rootless-containers/rootlesskit/releases )
- [Commits](https://github.com/rootless-containers/rootlesskit/compare/v0.14.1...v0.14.2 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-04-15 07:59:56 +00:00
df6c7c2ae5
Merge pull request #10031 from edsantiago/compose_test_flakes_again
...
compose test: ongoing efforts to diagnose flakes
2021-04-14 18:01:51 -04:00
693352c841
Update documentation of podman-run to reflect volume "U" option
...
The "U" option is accepted by `--volume` in `podman-build`,
but documentation is missing
Signed-off-by: Pablo Correa Gómez <ablocorrea@hotmail.com>
2021-04-14 23:55:07 +02:00
855a5a89dd
Fix flake on failed podman-remote build : try 2
...
This time we are checking if the function actually succeeded,
otherwise we will report an error.
Also if we did not get the id, report unexpected failure.
[NO TESTS NEEDED] Still no good way to test this, but manually.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-04-14 16:51:13 -04:00
9f36efda37
Merge pull request #10030 from rhatdan/build
...
Fix flake on failed podman-remote build
2021-04-14 15:34:51 -04:00
a7bbb78c8d
Merge pull request #10028 from edsantiago/bats
...
System tests: fix racy podman-inspect
2021-04-14 15:12:51 -04:00
OpenShift Merge Robot
Eduardo Vega
chenkang
TomSweeneyRedHat
Peter Hunt
Paul Holzinger
wuhua.ck
Jakub Guzik
Lokesh Mandvekar
Ed Santiago
zhangguanzhang
dependabot[bot]
Pablo Correa Gómez
Daniel J Walsh