Commit Graph

15554 Commits

Author SHA1 Message Date
openshift-ci[bot] 2382955c6a
Merge pull request #14660 from rhatdan/bindings
Remove logrus.Infof on bindings start and attach
2022-06-22 13:02:35 +00:00
openshift-ci[bot] 2629f445a0
Merge pull request #14690 from sstosh/prune-message
Fix system prune output message
2022-06-22 13:01:36 +00:00
openshift-ci[bot] 00ce793f0d
Merge pull request #14631 from n1hility/opendoc-after-install
Open Windows tutorial after MSI installation
2022-06-22 11:21:59 +00:00
Toshiki Sonoda 0320ce37de Fix system prune output message
'podman system prune' command always outputs "Deleted Images" message,
even though there is no dangling or unused image to remove.
This message should be output only if dangling or unused image exists.

[NO NEW TESTS NEEDED]

Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
2022-06-22 13:12:46 +09:00
Daniel J Walsh 7ef282d643
Remove lorgus.Infof on bindings start and attach
We are only doing logrus.Info on a couple of bindings. I see no reason
to only do this on a couple, seems like debugging information more then
useful to the caller. We had a complaint about this so removing.

Fixes: https://github.com/containers/podman/issues/13504

[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-06-21 16:28:58 -04:00
gunnar 132393d15c
Update basic_networking.md
a little enhancement based on the [comment by @TomSweeneyRedHat](https://github.com/containers/podman/pull/14290#pullrequestreview-979316099)

Replaces: https://github.com/containers/podman/pull/14290
Thanks to @vrms

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-06-21 16:24:59 -04:00
openshift-ci[bot] 15a651f860
Merge pull request #13384 from flouthoc/podman-remote-add-with-annotate
bindings: manifest should follow `es_model` naming convention while marshalling `OSVersion` and `OSFeatures`
2022-06-21 20:18:01 +00:00
openshift-ci[bot] 8d17251f8a
Merge pull request #14642 from rhatdan/VENDOR
Update to use gopkg.in/yaml.v3
2022-06-21 19:23:48 +00:00
openshift-ci[bot] 8863e13dc3
Merge pull request #14643 from clobrano/feature/network/list/dangling/dev
allow filter networks by dangling status
2022-06-21 18:19:16 +00:00
openshift-ci[bot] c9dce6353d
Merge pull request #14659 from eriksjolund/setup_to_set_up_in_code
[CI:DOCS] "setup" -> "set up" in source code comments
2022-06-21 18:08:31 +00:00
openshift-ci[bot] 7724eb07ce
Merge pull request #14638 from giuseppe/improve-error-messages-rootless-unshare
pkg/rootless: error messages improvements
2022-06-21 18:01:15 +00:00
openshift-ci[bot] fe974101eb
Merge pull request #14625 from cdoern/podShm
podman pod create --shm-size
2022-06-21 17:57:24 +00:00
openshift-ci[bot] b8b0fa8045
Merge pull request #14683 from Luap99/bump-cobra
bump github.com/spf13/cobra from 1.4.0 to 1.5.0
2022-06-21 17:37:14 +00:00
openshift-ci[bot] 588d8ec371
Merge pull request #14662 from Luap99/api-json
API: containers/json always set application/json content type
2022-06-21 16:26:08 +00:00
openshift-ci[bot] 79eb467325
Merge pull request #14677 from giuseppe/memory-limit-ctr-handlers
api: show the memory limit specified for the container
2022-06-21 15:58:07 +00:00
openshift-ci[bot] 1cf19843d0
Merge pull request #14672 from sbmthakur/patch-1
[CI:DOCS] Fix typos
2022-06-21 15:54:20 +00:00
Carlo Lobrano 4a981c490b allow filter networks by dangling status
add the ability to filter networks by their dangling status via:

`network ls --filter dangling=true/false`

Fixes: #14595
Signed-off-by: Carlo Lobrano <c.lobrano@gmail.com>
2022-06-21 17:50:55 +02:00
Paul Holzinger 050693b2e7
bump github.com/spf13/cobra from 1.4.0 to 1.5.0
Update cobra to latest version. Remove workaround for podman -h.
Also regenerate the completion scripts.

[NO NEW TESTS NEEDED]

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-06-21 17:17:06 +02:00
openshift-ci[bot] c8032b9911
Merge pull request #14680 from containers/dependabot/go_modules/github.com/stretchr/testify-1.7.4
Bump github.com/stretchr/testify from 1.7.2 to 1.7.4
2022-06-21 14:19:58 +00:00
Giuseppe Scrivano ecf225019a
rootless: attempt to join all specified paths
when there are multiple paths specified, attempt to join them all
before returning an error.  Previously we were failing on the first
pid found.

[NO NEW TESTS NEEDED]

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2022-06-21 15:50:52 +02:00
Giuseppe Scrivano 9afd5e31c8
rootless: improve error messages
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2022-06-21 15:50:52 +02:00
Giuseppe Scrivano 99258703a7
rootless: do not ignore reexec_in_user_namespace_wait errors
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2022-06-21 15:49:05 +02:00
dependabot[bot] cfba09f682
Bump github.com/stretchr/testify from 1.7.2 to 1.7.4
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.2 to 1.7.4.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](https://github.com/stretchr/testify/compare/v1.7.2...v1.7.4)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-06-21 12:10:35 +00:00
Giuseppe Scrivano 1f539a2641
api: show the memory limit specified for the container
use the memory limit specified for the container instead of reading it
from the cgroup.  It is not reliable to read it from the cgroup since
the container could have been moved to a different cgroup and in
general the OCI runtime might create a sub-cgroup (like crun does).

Closes: https://github.com/containers/podman/issues/14676

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2022-06-21 12:06:33 +02:00
Shubham Thakur 7f82c43231
Fix typos
Signed-off-by: Shubham Thakur <sbmthakur@gmail.com>
2022-06-20 20:40:10 -05:00
cdoern f451b68dfa podman pod create --shm-size
expose the --shm-size flag to podman pod create and add proper handling and inheritance
for the option.

resolves #14609

Signed-off-by: Charlie Doern <cdoern@redhat.com>
2022-06-20 10:25:00 -04:00
openshift-ci[bot] fe8e536328
Merge pull request #14556 from sstosh/system-prune-network
podman system prune support prune unused networks
2022-06-20 13:57:42 +00:00
Paul Holzinger 46da7bc78f
podman machine init --now: respect proxy envs
podman machine start contains more logic than just the simple vm.Start()
call. Instead of duplicating this into inti we just call start().

[NO NEW TESTS NEEDED] I have no way to test this right now.

Fixes #14640

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-06-20 15:36:00 +02:00
Paul Holzinger bb5bd09ead
API: containers/json always set application/json content type
When we return no containers we just return `[]` but we still have to keep
the content type header `application/json` so external tools can correctly
parse the output.

Fixes #14647

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-06-20 14:07:56 +02:00
openshift-ci[bot] 55052c6b98
Merge pull request #14657 from eriksjolund/rewrite_env_docs
[CI:DOCS] Rewrite --env docs
2022-06-19 17:16:32 +00:00
Erik Sjölund 2827140907 [CI:DOCS] "setup" -> "set up" in source code comments
* Replace "setup", "lookup" with "set up", "look up"
  when used as verbs.

Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2022-06-19 12:18:08 +02:00
Erik Sjölund dda68201a4 [CI:DOCS] Rewrite --env docs
* Add docs about trailing * functionality in podman-exec.1.md

* Rewrite --env description in podman-create.1.md and podman-run.1.md

* Rewrite the --env examples in podman-create.1.md and podman-run.1.md

Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2022-06-19 09:56:46 +02:00
openshift-ci[bot] ff06c791ad
Merge pull request #14637 from edigaryev/fix-matrix-expansion
.cirrus.yml: fix matrix expansion by properly merging YAML mappings
2022-06-17 15:58:57 +00:00
openshift-ci[bot] 3b03bd3f78
Merge pull request #14592 from cevich/more_fix_404
Cirrus: Fix build. dep. missed in #14521
2022-06-17 15:23:44 +00:00
Daniel J Walsh 948866e8a0
Update to use gopkg.in/yaml.v3
[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-06-17 11:03:08 -04:00
openshift-ci[bot] 04de0dabce
Merge pull request #14599 from rhatdan/VENDOR
Vendor in latest containers/image
2022-06-17 14:59:17 +00:00
Nikolay Edigaryev 075c9ac455 .cirrus.yml: fix matrix expansion by properly merging YAML mappings
Signed-off-by: Nikolay Edigaryev <edigaryev@gmail.com>
2022-06-17 15:02:01 +03:00
Daniel J Walsh 8090445762
vendor in latests containers/image
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-06-17 06:10:24 -04:00
openshift-ci[bot] c936d1e611
Merge pull request #14622 from rhatdan/storage
Vendor in latest containers/storage
2022-06-17 07:54:59 +00:00
Jason T. Greene ce3d0954a5 Open Windows tutorial after MSI installation
Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2022-06-16 23:46:24 -05:00
openshift-ci[bot] 05fc5959ec
Merge pull request #14627 from cdoern/lint-fix
linter fix from #14299
2022-06-16 23:14:52 +00:00
cdoern a3b3f1723b linter fix from #14299
[NO NEW TESTS NEEDED] podman pod clone somehow snuck by the new linter code that went in while it was in flight
fix that here

Signed-off-by: cdoern <cdoern@redhat.com>
2022-06-16 16:32:01 -04:00
openshift-ci[bot] 2af8851787
Merge pull request #14299 from cdoern/podClone
implement podman pod clone
2022-06-16 20:05:27 +00:00
Chris Evich 065302bd58
Cirrus: Fix build. dep. missed in #14521
This is causing the remote system tests to fail when run on on `main`.

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-06-16 14:28:56 -04:00
openshift-ci[bot] 5cba4dc2e4
Merge pull request #14619 from Luap99/help
fix "podman -h" help output
2022-06-16 18:06:29 +00:00
Daniel J Walsh 3af047b63d
Vendor in latest containers/storage
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-06-16 14:05:43 -04:00
openshift-ci[bot] 8765adb756
Merge pull request #14621 from mheon/api_sec_notice
[CI:DOCS] Make it clear the REST API could be a security issue
2022-06-16 16:37:40 +00:00
openshift-ci[bot] e6fe06f591
Merge pull request #14600 from edsantiago/argh
system tests: avoid rmi -a ... plus cleanup
2022-06-16 16:01:45 +00:00
Paul Holzinger 09c462d735
fix "podman -h" help output
`podman -h` currently returns an error:
`Error: pflag: help requested`

This bug was introduced in 44d037898e, the problem is that we wrap the
error and cobra lib checks with `==` for this one and not errors.Is().
I have a PR upstream to fix this but for now this also works.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-06-16 16:59:47 +02:00
openshift-ci[bot] e3a0deadce
Merge pull request #14613 from kolyshkin/fix-410-selinux
test/system/410-selinux: fix for newer runc
2022-06-16 14:33:23 +00:00