Commit Graph

23615 Commits

Author SHA1 Message Date
Philippe Martin 3e58e04d3e Quote systemd DefaultEnvironment Proxy values, as documented in systemd.conf man page:
Example:
DefaultEnvironment="VAR1=word1 word2" VAR2=word3 "VAR3=word 5 6"
Sets three variables "VAR1", "VAR2", "VAR3".

Double quote is not escaped, as there is no chance it appears in a proxy value. User can still espace it if really necessary

Signed-off-by: Philippe Martin <phmartin@redhat.com>
2024-08-26 13:12:47 +02:00
openshift-merge-bot[bot] 8bb61c7f33
Merge pull request #23744 from qrhfz/qrhfz-patch-1
fix typo in podman-network-create.1.md
2024-08-26 08:27:56 +00:00
Qori El-Hafizh 16007e4370
fix typo in podman-network-create.1.md
gateway ip in the description doesnt match the provided command

Signed-off-by: Qori El-Hafizh <57665201+qrhfz@users.noreply.github.com>
2024-08-25 12:05:33 +00:00
openshift-merge-bot[bot] faf5b2cb06
Merge pull request #23486 from ben-krieger/connection-base-path
Use HTTP path prefix of TCP connections to match Docker context behavior
2024-08-25 11:55:48 +00:00
Ben Krieger 6c68f4ad97 Use HTTP path prefix of TCP connections to match Docker context behavior
Signed-off-by: Ben Krieger <ben.krieger@intel.com>
2024-08-22 21:22:26 -04:00
Ed Santiago cae427e2f8 Makefile: remotesystem: use real podman server, no --url
Belated followup to #21965.

All this time, we've been creating a socket and running

    podman-remote --url /path/to/socket

This dates back to varlink. Remember varlink?

There's no need for it. Let's run podman system service
with no args. That's a more realistic test, and it makes
our logs cleaner as a bonus.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-08-22 18:43:35 -06:00
openshift-merge-bot[bot] 6011eac97b
Merge pull request #23695 from edsantiago/safename-170
CI: parallel-safe userns test
2024-08-22 20:05:13 +00:00
openshift-merge-bot[bot] c959942494
Merge pull request #23673 from containers/renovate/setuptools-73.x
chore(deps): update dependency setuptools to v73
2024-08-22 17:25:35 +00:00
openshift-merge-bot[bot] 7156f60fee
Merge pull request #23721 from containers/renovate/github.com-openshift-imagebuilder-1.x
Update module github.com/openshift/imagebuilder to v1.2.15
2024-08-22 16:58:04 +00:00
renovate[bot] 215af114ab
Update module github.com/openshift/imagebuilder to v1.2.15
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-22 15:57:06 +00:00
openshift-merge-bot[bot] 77f5b4d678
Merge pull request #23718 from containers/renovate/github.com-onsi-ginkgo-v2-2.x
Update module github.com/onsi/ginkgo/v2 to v2.20.1
2024-08-22 15:54:47 +00:00
Ed Santiago 11547942b1 CI: parallel-safe userns test
- use safename
- add ci:parallel tags where possible
  - where not possible, document why

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-08-22 08:24:14 -06:00
renovate[bot] 7164177c68
Update module github.com/onsi/ginkgo/v2 to v2.20.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-22 13:56:19 +00:00
openshift-merge-bot[bot] a581bbdb3d
Merge pull request #23688 from containers/renovate/golangci-golangci-lint-1.x
[CI:DOCS] Update dependency golangci/golangci-lint to v1.60.2
2024-08-22 13:53:48 +00:00
Jerome Degroote d55b12f70b Add support for IP in quadlet .pod files
Signed-off-by: Jerome degroote <jeromedu59230@gmx.fr>
2024-08-22 14:51:12 +02:00
openshift-merge-bot[bot] 1c3ebeeabd
Merge pull request #23696 from edsantiago/safename-030
CI: parallel-safe run system test
2024-08-22 12:47:30 +00:00
openshift-merge-bot[bot] 3c2a2f0409
Merge pull request #23710 from ashley-cui/relp
Update Release Process
2024-08-22 12:36:30 +00:00
openshift-merge-bot[bot] e7905122d7
Merge pull request #23679 from ruihe774/pod-userns
quadlet: support user mapping in pod unit
2024-08-22 12:33:43 +00:00
openshift-merge-bot[bot] 0a9f49bbe0
Merge pull request #23622 from alexlarsson/ci-require-jira-links
CI: On vX.Y-rhel branches, ensure that some downstream Jira issue is linked
2024-08-22 12:31:00 +00:00
openshift-merge-bot[bot] bd90f9c200
Merge pull request #23706 from edsantiago/new-vms
Update CI VMs
2024-08-22 12:28:14 +00:00
Matt Heon b2fb944e19 Specify format to use for referencing fixed bugs.
Per discussion within the team, we would like all bugfixes to be
referenced in commit messages as "Fixes:" (or "Fixes" with no
colon, for those who would like to type one less character). We
are going to add CI to enforce this on our LTS branches as we
should only be backporting bugfixes there.

Signed-off-by: Matt Heon <mheon@redhat.com>
2024-08-22 08:22:52 -04:00
openshift-merge-bot[bot] bfb3a1765d
Merge pull request #23700 from rhatdan/exec
command is not optional to podman exec
2024-08-22 12:16:42 +00:00
Ed Santiago 68efa7e3a1 CI: parallel-safe run system test
- fix a few missing safenames
- eliminate 'container rm -a'
- when running ps, do substring match, not exact
- where possible, add ci:parallel tags
  - when not possible, explain

Also, fix a completely broken inspect test

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-08-22 05:58:52 -06:00
openshift-merge-bot[bot] ae4eaaf1ae
Merge pull request #23698 from edsantiago/safename-195
CI: parallel-safe namespaces system test
2024-08-22 11:37:20 +00:00
Ed Santiago 4dc5708f14 Revert "test/e2e: work around for pasta issue"
This reverts commit 1912dd4bf6.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-08-22 04:55:43 -06:00
Alexander Larsson 17193af962 CI: On vX.Y-rhel branches, ensure that some downstream Jira issue is linked
In the RHEL specific branches we want to ensure that all MRs link to
at least one downstream Jira ticket. To do this we add a new test in
validate-source similar to the existing pr-should-include-tests. This
test only runs on actual pull requests.

The syntax for linking to a Jira is "Fixes " or "Fixes: ", followed by
one jira links, like so:

```
Fixes https://issues.redhat.com/browse/RHEL-50506
Fixes: https://issues.redhat.com/browse/RHEL-50506
```

Note: This is the same syntax as for a regular github issue reference.

Signed-off-by: Alexander Larsson <alexl@redhat.com>
2024-08-22 11:53:25 +02:00
Misaki Kasumi 4fbfa7de6e quadlet: support user mapping in pod unit
Signed-off-by: Misaki Kasumi <misakikasumi@outlook.com>
2024-08-22 09:41:06 +08:00
Ashley Cui 5ccaa699f1 Update Release Process
Update release process to reflect automatic artifact generation

Signed-off-by: Ashley Cui <acui@redhat.com>
2024-08-21 15:35:40 -04:00
Ed Santiago 154d832696 Test new VM build
Mostly to get pasta 08-14 but also a ton more changes elsewhere.

   https://github.com/containers/automation_images/pull/383

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-08-21 11:35:19 -06:00
Daniel J Walsh 1d5bdce3d9
Merge branch 'main' of github.com:containers/podman into man
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-08-21 08:59:06 -04:00
Daniel J Walsh 29071ac498
command is not optional to podman exec
Fixes: https://github.com/containers/podman/issues/22849

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-08-21 08:45:50 -04:00
Ed Santiago 9c3921ca58 CI: parallel-safe namespaces system test
An easy one :-)

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-08-21 05:36:04 -06:00
renovate[bot] 13b31845c8
[CI:DOCS] Update dependency golangci/golangci-lint to v1.60.2
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-20 21:47:30 +00:00
openshift-merge-bot[bot] 43fe3ebaf3
Merge pull request #23670 from mheon/fix_stop_and_rmi
Fix `podman stop` and `podman run --rmi`
2024-08-20 21:45:51 +00:00
openshift-merge-bot[bot] 096b52c987
Merge pull request #23669 from lsm5/packit-fedora-all
[skip-ci] Packit: update targets for propose-downstream
2024-08-20 20:26:17 +00:00
openshift-merge-bot[bot] 8be89caf46
Merge pull request #23675 from ruihe774/fix-pod-cgroups
Add key CgroupsMode in Quadlet container unit
2024-08-20 18:47:16 +00:00
openshift-merge-bot[bot] a3adad98af
Merge pull request #23676 from ruihe774/infra-name
quadlet: set infra name to %s-infra
2024-08-20 15:52:53 +00:00
Misaki Kasumi 1ccccde183 quadlet: add key CgroupsMode
Signed-off-by: Misaki Kasumi <misakikasumi@outlook.com>
2024-08-20 22:09:36 +08:00
Matt Heon 458ba5a8af Fix `podman stop` and `podman run --rmi`
This started off as an attempt to make `podman stop` on a
container started with `--rm` actually remove the container,
instead of just cleaning it up and waiting for the cleanup
process to finish the removal.

In the process, I realized that `podman run --rmi` was rather
broken. It was only done as part of the Podman CLI, not the
cleanup process (meaning it only worked with attached containers)
and the way it was wired meant that I was fairly confident that
it wouldn't work if I did a `podman stop` on an attached
container run with `--rmi`. I rewired it to use the same
mechanism that `podman run --rm` uses, so it should be a lot more
durable now, and I also wired it into `podman inspect` so you can
tell that a container will remove its image.

Tests have been added for the changes to `podman run --rmi`. No
tests for `stop` on a `run --rm` container as that would be racy.

Fixes #22852
Fixes RHEL-39513

Signed-off-by: Matt Heon <mheon@redhat.com>
2024-08-20 09:51:18 -04:00
Misaki Kasumi e5c91ff03a quadlet: set infra name to %s-infra
e.g.: if the pod name is systemd-awd, the name of its infra container will be systemd-awd-infra

Signed-off-by: Misaki Kasumi <misakikasumi@outlook.com>
2024-08-20 18:20:02 +08:00
renovate[bot] 990fc335fa
chore(deps): update dependency setuptools to v73
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-19 21:46:48 +00:00
openshift-merge-bot[bot] 426aac362e
Merge pull request #23666 from rhatdan/apple
Do not segfault on hard stop
2024-08-19 18:02:00 +00:00
Lokesh Mandvekar 76e1bbb57d
[skip-ci] Packit: update targets for propose-downstream
When a new Fedora target (41 currently), is branched from rawhide,
`fedora-latest` packit target will point to fedora-41, while
`fedora-latest-stable` will point to `fedora-40`. Once fedora-41 has
released, `fedora-latest` and `fedora-latest-stable` will both point to
fedora-41.

So, to have Packit continue to create PRs for Fedora 40 once Fedora 41
has released, it's best to set the target back to `fedora-all`.

Caution: `fedora-all` will create v5.x PRs for Fedora-39 until it goes
EOL. Since dist-git PRs need to be merged manually, we can just manually
close F39 PRs.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2024-08-19 11:37:15 -04:00
Daniel J Walsh fc30620cdb
Do not segfault on hard stop
Podman machine on MAC can segfault on hard stop.

Fixes: 23654

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-08-19 11:14:30 -04:00
Daniel J Walsh d5cd388729
Fix description of :Z to talk about pods
Fixes: 23329

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-08-19 09:57:25 -04:00
openshift-merge-bot[bot] 7899358ec9
Merge pull request #23662 from edsantiago/disable-ginkgo-flake-retry
CI: disable ginkgo flake retries
2024-08-19 13:54:29 +00:00
openshift-merge-bot[bot] 8068bb2fc8
Merge pull request #23650 from Luap99/e2e-systemd-rm
test/e2e: rm systemd start test
2024-08-19 13:21:26 +00:00
openshift-merge-bot[bot] 8fd0d90669
Merge pull request #23663 from Luap99/criu-update
vendor: update go-criu to latest
2024-08-19 13:15:57 +00:00
Ed Santiago 145c7511aa CI: disable ginkgo flake retries
As discussed in Aug 13 Cabal, we are almost at a point where
e2e tests are reliably passing on the first try. Let's try to
keep things that way, and not hide future flakes.

Closes: #17967

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-08-19 06:48:15 -06:00
Paul Holzinger b755a1c60b
vendor: update go-criu to latest
There is no new version yet but we like to use the new code[1] to debug
a flake[2] in the podman CI. It will not fix it but the new error might
give us a better idea what is going on.

[1] https://github.com/checkpoint-restore/go-criu/pull/175
[2] https://github.com/containers/podman/issues/18856

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-19 13:51:56 +02:00