Commit Graph

23615 Commits

Author SHA1 Message Date
openshift-merge-bot[bot] 18e0272a7a
Merge pull request #23523 from inknos/flake-23468
Add passwd validate and generate steps
2024-08-08 12:40:53 +00:00
renovate[bot] 52ff2a41fa
Update module github.com/onsi/ginkgo/v2 to v2.20.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-08 12:10:24 +00:00
openshift-merge-bot[bot] 9007553a81
Merge pull request #23547 from containers/renovate/github.com-moby-sys-user-0.x
Update module github.com/moby/sys/user to v0.3.0
2024-08-08 11:36:45 +00:00
renovate[bot] 09639a07fb
Update module github.com/moby/sys/user to v0.3.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-08 09:59:03 +00:00
openshift-merge-bot[bot] c053194921
Merge pull request #23533 from edsantiago/fix-containerport-flake
CI: e2e: serialize root containerPort tests
2024-08-08 09:57:57 +00:00
Nicola Sella f041d059b5 Add passwd validate and generate steps
Add generate helper function.
Also, add a troubleshooting try/catch block in case we get more flakes
during Set-LocalUser step in Windows powershell.

Resolves: https://github.com/containers/podman/issues/23468

Signed-off-by: Nicola Sella <nsella@redhat.com>
2024-08-08 11:50:17 +02:00
openshift-merge-bot[bot] 9939f653c6
Merge pull request #23531 from containers/renovate/common-image-and-storage-deps
fix(deps): update github.com/containers/common digest to 05b2e1f
2024-08-08 08:51:46 +00:00
openshift-merge-bot[bot] 6dd64e5d27
Merge pull request #23537 from Luap99/cleanup-err
podman container cleanup: ignore common errors
2024-08-08 07:40:15 +00:00
Paul Holzinger 4620e91f86
podman container cleanup: ignore common errors
The podman container cleanup command is not really intended for human
use. Instead each conmon will spawn this command after the container
exit to make sure we can cleanup resources asynchronously. However this
command will always race against other foreground process such as podman
rm -fa. Therefore it is possible that the ctr was already removed and we
should not log errors in this case.

While these errors are normally not seen as the command is int he
background you can see it if you enable syslog logging and then they
just spam the log with useless errors so just ignore them.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-07 17:00:47 +02:00
Ygal Blum 795851edd3 Quadlet - Allow the user to override the default service name
Add support for the ServiceName key for all unit types
Extend the PodInfo struct into UnitInfo to consolidate all prepopulated data into a single map
Use the NodesInfo map instead of the resourceName
Update the UnitInfo in the convert function instead of returning it
No need to replace extension anymore just remove it
All e2e tests with dependencies on other Quadlet files moved to a separate section
Add the capability of overriding the service name in the test
Add e2e tests for the new functionality
Adjust integration tests
Update the MAN page

Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2024-08-07 17:50:49 +03:00
Ed Santiago 1a2e1eb46e CI: e2e: serialize root containerPort tests
Two tests, both check port 80 on host, one wants it live,
the other wants it blocked. Prevent them from running
concurrently.

Fixes: #23470

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-08-07 05:34:12 -06:00
openshift-merge-bot[bot] 4e788bc611
Merge pull request #23532 from containers/renovate/golang.org-x-tools-0.x
fix(deps): update module golang.org/x/tools to v0.24.0
2024-08-07 10:11:52 +00:00
Daniel J Walsh a06a7d7ba8
Should not force conversion of manifest type to DockerV2ListMediaType
Fixes: https://github.com/containers/podman/issues/23163

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-08-07 06:07:46 -04:00
openshift-merge-bot[bot] 61f7db5e7a
Merge pull request #23527 from edsantiago/safename-012
CI: manifest system tests: make parallel-safe
2024-08-07 08:25:10 +00:00
openshift-merge-bot[bot] 4109ffa649
Merge pull request #23529 from edsantiago/safename-060
CI: mount system test: make parallel-safe
2024-08-07 08:19:31 +00:00
openshift-merge-bot[bot] 9e8c4c4993
Merge pull request #23524 from mheon/fix_23515
Create volume path before state initialization
2024-08-07 08:16:54 +00:00
renovate[bot] 2038d88680
fix(deps): update module golang.org/x/tools to v0.24.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-07 03:20:04 +00:00
renovate[bot] 6714b6302d
fix(deps): update github.com/containers/common digest to 05b2e1f
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-07 00:16:18 +00:00
openshift-merge-bot[bot] 64020cdc51
Merge pull request #23526 from baude/windowsgvisorpidnoterror
Ignore ERROR_SHARING_VIOLATION error on windows
2024-08-06 22:21:57 +00:00
openshift-merge-bot[bot] 4a9942a043
Merge pull request #23528 from containers/renovate/golang.org-x-net-0.x
Update module golang.org/x/net to v0.28.0
2024-08-06 22:13:40 +00:00
openshift-merge-bot[bot] bcbd2b29de
Merge pull request #23521 from giuseppe/vendor-storage-6-aug-2024
vendor: update c/storage
2024-08-06 22:02:49 +00:00
Ed Santiago f99c7ead92 CI: mount system test: parallelize
Use safename for containers, volumes, images.

Build a temporary scratch image for podman image mount, so
we can safely mount/umount it (instead of $IMAGE) without
risk of other parallel tests umounting it.

Fixed some oopsies ("$vol1" is empty string, so, NOP test)

And... an experiment. I'm leaving in my 'ci:parallel' tags
and notes, so I don't have to carry them in #23275. This
is harmless, basically just noisy comments. The drawback
is, if for some reason #23275 does not pan out, I'll have
to go back and remove those tags. Right now I'm feeling
pretty comfortable about this parallelization approach tho.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-08-06 13:28:47 -06:00
renovate[bot] 53ae4ea927
Update module golang.org/x/net to v0.28.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-06 19:12:49 +00:00
Brent Baude 81003f2d08 Ignore ERROR_SHARING_VIOLATION error on windows
When removing the gvproxy pid file, under CI conditions we could hit a
case where the PID file being removed seemed to have an open handle on
it still.  I could not find anything in podman that left an open handle
and gvproxy would have quit before this, so we think it is likely
another process holding it.  I could not find root cause with CI because
I could not trip the flake.

this new code allows windows (specifically hyperv bc WSL does not use
GVProxy) to ignore an ERROR_SHARING_VIOLATION.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2024-08-06 14:09:36 -05:00
Ed Santiago f9b67cea57 CI: manifest system tests: make parallel-safe
Use safename instead of hardcoded "test"

Start registry once, in setup_file(), instead of requiring
individual tests to do so.

Add explicit --authfile arg to a bunch of places that now need it

Minor cleanup and improvements in test descriptions. I may have
gotten a little carried away here, but if this test ever fails
these additions will make someone's life much easier.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-08-06 13:07:10 -06:00
Matt Heon eb7ce80cf9 Create volume path before state initialization
Strictly speaking we don't need the path yet, but it existing
prevents a lot of strangeness in our path-checking logic to
validate the current Podman configuration, as it was the only
path that might not exist this early in init.

Fixes #23515

Signed-off-by: Matt Heon <mheon@redhat.com>
2024-08-06 13:42:09 -04:00
Giuseppe Scrivano 84a5119d17
vendor: update c/storage
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2024-08-06 17:51:14 +02:00
openshift-merge-bot[bot] 128fde1734
Merge pull request #23518 from Luap99/test-new-vms
Update CI images
2024-08-06 13:44:58 +00:00
Paul Holzinger 029f9b38cc
CI: fix broken libkrun test
Same issues as in the volume ops test, the libkrun volume is not working
properly (#23296).

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-06 14:45:52 +02:00
openshift-merge-bot[bot] 3275fd2dda
Merge pull request #23512 from rhatdan/mount
Remove another race condition when mounting containers or images
2024-08-06 11:41:10 +00:00
openshift-merge-bot[bot] 69862b7251
Merge pull request #23460 from Luap99/cleanup-term
libpod: inhibit SIGTERM during cleanup()
2024-08-06 11:38:27 +00:00
Paul Holzinger 1912dd4bf6
test/e2e: work around for pasta issue
Use network slirp4netns for the registry container to work around a
pasta regression (#23517). This should be revert once it is fixed in
pasta and included in our CI images.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-06 13:16:34 +02:00
Paul Holzinger 71bcd25ab6
test/e2e: fix missing exit code checks
Both push commands didn't check the exit code so make sure they actually
work.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-06 13:16:34 +02:00
Ed Santiago 082650b68f
Test new CI images
Source: https://github.com/containers/automation_images/pull/371

Signed-off-by: Ed Santiago <santiago@redhat.com>
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-08-06 13:15:53 +02:00
Daniel J Walsh abd586cb1c
Remove another race condition when mounting containers or images
Fixes: https://github.com/containers/podman/issues/23507

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-08-06 06:23:13 -04:00
openshift-merge-bot[bot] b1d111c770
Merge pull request #23391 from l0rd/build-contexts
Convert additional build context paths on Windows
2024-08-06 10:18:41 +00:00
openshift-merge-bot[bot] 7e469996b1
Merge pull request #23513 from containers/renovate/common-image-and-storage-deps
fix(deps): update github.com/containers/common digest to c0cc6b7
2024-08-06 08:31:27 +00:00
renovate[bot] 91b3fdbba3
fix(deps): update github.com/containers/common digest to c0cc6b7
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-06 00:10:39 +00:00
openshift-merge-bot[bot] 7c38ee7565
Merge pull request #23509 from l0rd/fix-23502
Change Windows installer MajorUpgrade Schedule
2024-08-06 00:08:10 +00:00
Mario Loriedo 01d739a65e Change Windows installer MajorUpgrade Schedule
Use Schedule "afterInstallExecute" (instead of the
default "afterInstallValidate") in the Windows
installer MajorUpgrade element. That avoid
overriding eventual users changes to the podman
machine configuration file created by the
installer.

Fixes #23502

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2024-08-05 21:52:58 +02:00
openshift-merge-bot[bot] 0bd43f4e12
Merge pull request #23461 from edsantiago/ci-machine-nocache
CI: podman-machine: do not use cache registry
2024-08-05 15:49:24 +00:00
openshift-merge-bot[bot] 5ca337d2e8
Merge pull request #23494 from rhatdan/VENDOR
Remove runc edit to lock to specific version
2024-08-05 14:34:38 +00:00
openshift-merge-bot[bot] 63ec8293ee
Merge pull request #23493 from rhatdan/buildah
Ignore missing containers when calling GetExternalContainerLists
2024-08-05 13:08:40 +00:00
openshift-merge-bot[bot] 9742b4ad6f
Merge pull request #23500 from containers/renovate/golang.org-x-sys-0.x
fix(deps): update module golang.org/x/sys to v0.23.0
2024-08-05 12:43:53 +00:00
Daniel J Walsh d628e14355
Ignore missing containers when calling GetExternalContainerLists
Race condition between listing containers and figuring out if it
is a buildah container.

Fixe: https://github.com/containers/podman/issues/23492

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-08-05 08:18:57 -04:00
Daniel J Walsh 37226e2e93
Remove runc edit to lock to specific version
Fixes: https://github.com/containers/podman/issues/19795

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-08-05 08:08:04 -04:00
openshift-merge-bot[bot] 43a077db87
Merge pull request #23484 from edsantiago/safename-600
CI: completion system test: use safename
2024-08-05 11:56:06 +00:00
renovate[bot] 67ce828152
fix(deps): update module golang.org/x/sys to v0.23.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-05 11:26:07 +00:00
Ed Santiago 87dad1caef CI: podman-machine: do not use cache registry
It's too difficult to keep the podman-machine image up-to-date.
And, we can't use the cache on Mac/Windows, so if quay is down
we're hosed no matter what.

Add a "nocache" mechanism to install_test_configs() and use that
in machine test setup.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-08-05 05:12:36 -06:00
Ed Santiago bfb42b3b15 CI: completion system test: use safename
Ongoing efforts to make system tests parallel-safe

Signed-off-by: Ed Santiago <santiago@redhat.com>
2024-08-05 05:09:19 -06:00