Commit Graph

14469 Commits

Author SHA1 Message Date
Daniel J Walsh 6609bb73aa
Fix use of infra image to clarify default
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-01-31 17:21:25 -05:00
OpenShift Merge Robot 271867263c
Merge pull request #13091 from lsm5/fix-nightly-ci-builds
CI: fix nightly builds
2022-01-31 15:26:32 -05:00
Yaron Dayagi 2ceab11947 play kube envVar.valueFrom.fieldRef
add support for env vars values from pod spec fields
see https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#envvarsource-v1-core

relates to issue https://github.com/containers/podman/issues/12756

Signed-off-by: Yaron Dayagi <ydayagi@redhat.com>
2022-01-31 21:49:38 +02:00
Lokesh Mandvekar e7bdd1260b
CI: fix nightly builds
Nightly builds were failing on CI ever since the Makefile change to have
install target independent of build targets.
See: e4636ebdc8

This commit ensures everything is built before installation.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2022-01-31 11:47:39 -05:00
OpenShift Merge Robot cb0f31624c
Merge pull request #13078 from patrycja-guzik/podman-image-ls-filters
[CI:DOCS] Adapt podman images ls filters docs to be aligned with prune filters docs
2022-01-31 07:06:32 -05:00
Tsubasa Watanabe 009d9eb679 Add notes to "--oom-kill-disable" not supported on cgroups V2
Clarify "--oom-kill-disable" is not supported on cgroups V2 in
documentation.

Signed-off-by: Tsubasa Watanabe <w.tsubasa@fujitsu.com>
2022-01-31 17:14:46 +09:00
Patrycja Guzik a8fb8f52c7 Adapt podman images ls filters docs to be aligned with prune filters docs
Signed-off-by: Patrycja Guzik <patrycja.k.guzik@gmail.com>
2022-01-29 22:50:49 +01:00
OpenShift Merge Robot c2f4747fea
Merge pull request #13061 from flouthoc/podman-vm-delegate-subsystem
ignition, machine: delegate `cpu,io,memory,pid cgroup controllers` to machine's non-root users.
2022-01-28 11:16:10 -05:00
Daniel J Walsh 6365437871
Clarify remote client means Mac and Windows
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-01-28 08:14:05 -05:00
OpenShift Merge Robot 1b544b7424
Merge pull request #12712 from flouthoc/volume_overlay_advanced
volume: add support for non-volatile `upperdir`,`workdir` for overlay volumes
2022-01-28 07:06:02 -05:00
OpenShift Merge Robot f9d2f99653
Merge pull request #13048 from cevich/fix_get_ci_vm
[CI:DOCS] Cirrus: Fix get_ci_vm.sh initial setup
2022-01-28 06:44:04 -05:00
Aditya R 6f2b027b38
ignition, machine: delegate cpu,io cgroup controllers to machine's default users
Makes sure that ignition setups up systemd config so cgroup controllers
like `cpu, io` are also delegated to `non-root` along with `memory,
pid`.

This allows general users of `podman` on `macOS` and `podman-remote` to
do operations which are dependent on `cpu, io` cgroup controllers.

[NO TESTS NEEDED]
[NO NEW TESTS NEEDED]
We don't have a CI infra to test this, please pull the tree and run
`podman info` inside the machine to confirm.

Signed-off-by: Aditya R <arajan@redhat.com>
2022-01-28 15:02:34 +05:30
OpenShift Merge Robot 935ae1bfd0
Merge pull request #13052 from Luap99/issues2
[CI:DOCS] github: label issues based on os fix regex
2022-01-28 03:16:04 -05:00
Aditya Rajan e64e6500d3
volume: add support for non-volatile upperdir,workdir for overlay volumes
Often users want their overlayed volumes to be `non-volatile` in nature
that means that same `upper` dir can be re-used by one or more
containers but overall of nature of volumes still have to be `overlay`
so work done is still on a overlay not on the actual volume.

Following PR adds support for more advanced options i.e custom `workdir`
and `upperdir` for overlayed volumes. So that users can re-use `workdir`
and `upperdir` across new containers as well.

Usage
```console

$ podman run -it -v myvol:/data:O,upperdir=/path/persistant/upper,workdir=/path/persistant/work alpine sh

```

Signed-off-by: Aditya R <arajan@redhat.com>
2022-01-28 13:10:15 +05:30
cdoern 56d95172f1 podman image scp syntax correction
[NO NEW TESTS NEEDED] image scp was reading the localhost syntax too loosely causing some errors with domains or hosts containing the word
localhost. Fixed that and added a few lines to make sure the pure localhost connections do not touch sshd

resolves #13021

Signed-off-by: cdoern <cdoern@redhat.com>
2022-01-27 22:13:02 -05:00
Paul Holzinger a928d39d0c github: label issues based on os fix regex
Good news the github action works, however I noticed that we cannot use
a multiline regex so we have to use serviceIsRemote to detect if this is
a remote client. Also change the os regex so that it matches both the
output of podman version and podman info.

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2022-01-27 21:24:34 +01:00
OpenShift Merge Robot fae7648ba1
Merge pull request #13050 from Luap99/issues
[CI:DOCS] github: label issues based on os
2022-01-27 13:54:51 -05:00
Daniel J Walsh 908329c390
Merge pull request #13049 from edsantiago/bats
System tests: emergency skip of checkpoint tests
2022-01-27 13:20:41 -05:00
OpenShift Merge Robot bedbc3e6fc
Merge pull request #13042 from Luap99/subnets
network create: allow multiple subnets
2022-01-27 12:16:50 -05:00
Paul Holzinger 525bdc3771
github: label issues based on os
We get a lot of issues for podman-remote on macos. Since the fact that
this is a remote client is often overlooked by us lets add windows, macos
and remote label automatically based on a regex which should match the
output of podman version.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-01-27 17:51:35 +01:00
Chris Evich 4c26a3a5cd
Cirrus: Fix get_ci_vm.sh initial setup
Due to some recent changes in the Makefile, the setup part of the script
is now breaking with the error:

```
install: cannot stat 'bin/rootlessport': No such file or directory
make: *** [Makefile:767: install.bin] Error 1
```

The root-cause seems to be the `install` targets not
properly specifying their build dependencies.  This may lead to other
problems WRT automation, but for now I'm just patching this tool to
workaround the issue.

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-01-27 11:36:48 -05:00
Ed Santiago d455bb879d System tests: emergency skip of checkpoint tests
...on kernel 5.17, because it's broken

Signed-off-by: Ed Santiago <santiago@redhat.com>
2022-01-27 09:18:06 -07:00
Paul Holzinger 6961d91206
network create: allow multiple subnets
podman network create --subnet, --gateway and --ip-range can now be
specified multiple times to join the network to more than one subnet.
This is very useful if you want to use a dual stack network and assign a
fixed ipv4 and ipv6 subnet. The order of the options is important here,
the first --gateway/--ip-range will be assigned to the first subnet and
so on.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-01-27 16:38:39 +01:00
OpenShift Merge Robot 5d6b5a0355
Merge pull request #13035 from rhatdan/docs1
CI:DOCS: Add troublshooting info on podman machine remove followed by podman machine init
2022-01-27 09:44:50 -05:00
OpenShift Merge Robot 9e7e91c13e
Merge pull request #13034 from rhatdan/docs
CI:DOCS: Unify podman prune filter description: volumes, networks, system
2022-01-27 09:42:50 -05:00
OpenShift Merge Robot 5b01dab618
Merge pull request #13029 from TomSweeneyRedHat/dev/tsweeney/mergepull2
Bump Buildah to v1.24.0
2022-01-27 08:38:52 -05:00
OpenShift Merge Robot 5659b0734c
Merge pull request #12867 from cdoern/scp
switch podman image scp from depending on machinectl to just os/exec
2022-01-27 07:48:50 -05:00
bazhang87 86547cc24a
Update troubleshooting.md
Signed-off-by: Bart Zhang bazhang@redhat.com
Co-authored-by: Erik Sjölund <erik.sjolund@gmail.com>
Co-authored-by: Tom Sweeney <tsweeney@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-01-27 07:45:11 -05:00
Daniel J Walsh 24dc02064e
Fix sort ordering of filters
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2022-01-27 07:19:02 -05:00
Patrycja Guzik 63b1557a25
Unify podman prune filter description: volumes, networks, system
follow up of #12976

Signed-off-by: Patrycja Guzik <patrycja.k.guzik@gmail.com>
2022-01-27 07:13:06 -05:00
OpenShift Merge Robot 0d96c46c7c
Merge pull request #13031 from giuseppe/drop-permission-check-privileged-rootless-devices
rootless: drop permission check for devices
2022-01-27 07:12:49 -05:00
tomsweeneyredhat 4a4d86d40f Bump Buildah to v1.24.0
Bumps Buildah to v1.24.0 and adopts the new values for pull:
true, false, never, and always.  The pull-never and pull-always options
for the build command are still usable, but they have been removed from
the man page documentation with this change.

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
2022-01-27 07:03:56 -05:00
Giuseppe Scrivano 6336e1ff1e
rootless: drop permission check for devices
commit 350ede1eeb added the feature.

Do not check whether the device is usable by the rootless user before
adding to the container.

Closes: https://github.com/containers/podman/issues/12704

[NO NEW TESTS NEEDED] it requires changes on the host to test it

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2022-01-27 09:35:02 +01:00
cdoern 77cd38d40c switch podman image scp from depending on machinectl to just os/exec
machinectl does not propogate error messages and adds extra lines in the output, exec.Cmd is able to clear the env besides PATH and TERM,
and use the given UID and GID to execute the command properly.

machinectl is still used to create a user session. Ubuntu support is limited by this.

Signed-off-by: cdoern <cdoern@redhat.com>
2022-01-26 14:40:44 -05:00
OpenShift Merge Robot 09589fccfd
Merge pull request #13017 from containers/dependabot/go_modules/github.com/containers/image/v5-5.19.0
Bump github.com/containers/image/v5 from 5.18.0 to 5.19.0
2022-01-26 19:02:18 +01:00
dependabot[bot] ab22a688d8
Bump github.com/containers/image/v5 from 5.18.0 to 5.19.0
Bumps [github.com/containers/image/v5](https://github.com/containers/image) from 5.18.0 to 5.19.0.
- [Release notes](https://github.com/containers/image/releases)
- [Commits](https://github.com/containers/image/compare/v5.18.0...v5.19.0)

---
updated-dependencies:
- dependency-name: github.com/containers/image/v5
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-26 15:15:46 +00:00
OpenShift Merge Robot 2a39fe9913
Merge pull request #13016 from containers/dependabot/go_modules/github.com/containers/storage-1.38.1
Bump github.com/containers/storage from 1.38.0 to 1.38.1
2022-01-26 16:14:19 +01:00
OpenShift Merge Robot 81763669a5
Merge pull request #13013 from danielhelfand/osx-build-docs
[CI:DOCS] change location of where make outputs podman binary on osx
2022-01-26 15:06:17 +01:00
dependabot[bot] 9916529880
Bump github.com/containers/storage from 1.38.0 to 1.38.1
Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.38.0 to 1.38.1.
- [Release notes](https://github.com/containers/storage/releases)
- [Changelog](https://github.com/containers/storage/blob/main/docs/containers-storage-changes.md)
- [Commits](https://github.com/containers/storage/compare/v1.38.0...v1.38.1)

---
updated-dependencies:
- dependency-name: github.com/containers/storage
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-01-26 12:06:51 +00:00
Daniel Helfand 9073b56a3d change location of where make outputs podman binary on osx
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
2022-01-25 22:36:35 -06:00
OpenShift Merge Robot 9f8c0975ed
Merge pull request #13008 from cevich/fix_jq
[CI:DOCS] Github workflow: Fix parsing of GraphQL response JSON
2022-01-25 19:49:44 -05:00
Chris Evich 72ddacdbe9
Github workflow: Fix parsing of GraphQL response JSON
While #12998 fixed the query string, it neglected to address
presence of the old `githubRepository` field name in the reply.  This
resulted in the job throwing an error:

`jq: error (at ./artifacts/reply.json:0): Cannot iterate over null`

However, the job did preserve an artifacts archive containing the new
response data.  As a test for the fix in this commit, I ran the
raw response data through the corrected jq command-line.  This
confirmed the change by properly parsing the data as expected by
the workflow.

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-01-25 14:39:32 -05:00
OpenShift Merge Robot 7003d334e8
Merge pull request #12998 from cevich/fix_query
[CI:DOCS] Github workflow: Update Cirrus-cron GraphQL query
2022-01-25 13:51:43 -05:00
OpenShift Merge Robot 321ad68726
Merge pull request #13005 from cevich/fix_notify
[CI:DOCS] Github-workflow: Fix YAML syntax
2022-01-25 13:47:43 -05:00
OpenShift Merge Robot 164a1d028b
Merge pull request #12999 from jwhonce/issues/12987
Update godoc, swagger using wrong struct
2022-01-25 13:37:43 -05:00
OpenShift Merge Robot fa9ab1f5f7
Merge pull request #12966 from lsm5/makefile-separate-build-install
Makefile: install targets independent of build
2022-01-25 13:15:45 -05:00
Chris Evich 6df245c6ec
Github-workflow: Fix YAML syntax
The `body` string value must be quoted because it contains a colon.

Also fix an incorrect URL substitution reference in error-notice e-mail
body text.

(In my defense...testing this workflow is basically impractical without
merging it)

Signed-off-by: Chris Evich <cevich@redhat.com>
2022-01-25 12:39:17 -05:00
Jhon Honce 44a87229b6 Update godoc, swagger using wrong struct
Documentation for API volume list, pointed to a different struct
than the code.

[NO NEW TESTS NEEDED]

Fixes #12987

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2022-01-25 10:05:51 -07:00
OpenShift Merge Robot 92635c726a
Merge pull request #12857 from giuseppe/fix-rm-dir-not-empty
exec: retry rm -rf on ENOTEMPTY and EBUSY
2022-01-25 10:09:43 -05:00
Lokesh Mandvekar e4636ebdc8 Makefile: install targets independent of build
Building from source would involve separate `make` and `make install`
steps.

This removes a lot of unnecessary `-nobuild` targets which were
otherwise needed for packaging.

This commit also removes spec files for unused copr jobs.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2022-01-25 08:27:44 -05:00