Commit Graph

12209 Commits

Author SHA1 Message Date
Valentin Rothberg f4ba433b18 logs: k8s-file: fix spurious error logs
Fix the suprious "Error: nil" messages.  Also add some more context to
logged error messages which makes error sources more obvious.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2021-06-21 14:11:27 +02:00
OpenShift Merge Robot 18bf92f7ea
Merge pull request #10734 from mgoltzsche/fix-dns-detection
Fix systemd-resolved detection.
2021-06-21 07:06:34 -04:00
OpenShift Merge Robot 9ec4d04592
Merge pull request #10723 from rhatdan/tmpdir
fix systemcontext to use correct TMPDIR
2021-06-21 03:50:31 -04:00
Max Goltzsche 0fb165ed08
Fix systemd-resolved detection.
Previously podman failed when run in an environment where 127.0.0.53 is
the only nameserver but systemd-resolved is not used directly.
In practice this happened when podman was run within an alpine container
that used the host's network and the host was running systemd-resolved.

This fix makes podman ignore a file not found error when reading /run/systemd/resolve/resolv.conf.

Closes #10733

[NO TESTS NEEDED]

Signed-off-by: Max Goltzsche <max.goltzsche@gmail.com>
2021-06-20 17:17:00 +02:00
OpenShift Merge Robot 928687e1da
Merge pull request #10068 from flouthoc/master
[CI:DOCS] Add support for `podman login --verbose`
2021-06-20 10:24:30 -04:00
OpenShift Merge Robot 4cf3861168
Merge pull request #10718 from containers/dependabot/go_modules/github.com/containers/storage-1.32.3
Bump github.com/containers/storage from 1.32.2 to 1.32.3
2021-06-20 05:59:29 -04:00
dependabot[bot] 9cc3473b58
Bump k8s.io/api from 0.21.1 to 0.21.2
Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.21.1 to 0.21.2.
- [Release notes](https://github.com/kubernetes/api/releases)
- [Commits](https://github.com/kubernetes/api/compare/v0.21.1...v0.21.2)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-06-20 09:50:04 +00:00
OpenShift Merge Robot 938ecfe3f5
Merge pull request #10721 from containers/dependabot/go_modules/k8s.io/apimachinery-0.21.2
Bump k8s.io/apimachinery from 0.21.1 to 0.21.2
2021-06-20 05:41:29 -04:00
OpenShift Merge Robot d8cd205478
Merge pull request #10727 from mheon/add_run_uid_to_tmpfiles
[CI:DOCS] Add an entry for `/run/user-$UID/libpod` to tmpfiles
2021-06-19 14:05:29 -04:00
flouthoc 1e36be439d Add support for podman login --verbose
Signed-off-by: flouthoc <flouthoc.git@gmail.com>
2021-06-19 10:01:19 +05:30
Daniel J Walsh 7864108ff1
fix systemcontext to use correct TMPDIR
Users are complaining about read/only /var/tmp failing
even if TMPDIR=/tmp is set.

This PR Fixes: https://github.com/containers/podman/issues/10698

[NO TESTS NEEDED] No way to test this.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-06-18 19:53:24 -04:00
Matthew Heon 9a02b50551 Add an entry for `/run/user-$UID/libpod` to tmpfiles
The systemd-tmpfiles configuration is meant preserve important
paths in /tmp that are used by Podman against deletion by
systemd. However, not all paths we previously used were included.
Some older versions used the `/tmp/use-$UID/libpod` directory
instead (when `/run/user/$UID` was unavailable).

Add an entry for these old paths to ensure tmpfiles treats the
directory correctly.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1960948

Signed-off-by: Matthew Heon <mheon@redhat.com>
2021-06-18 16:32:24 -04:00
dependabot[bot] b56d6c6460
Bump github.com/containers/storage from 1.32.2 to 1.32.3
Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.32.2 to 1.32.3.
- [Release notes](https://github.com/containers/storage/releases)
- [Changelog](https://github.com/containers/storage/blob/main/docs/containers-storage-changes.md)
- [Commits](https://github.com/containers/storage/compare/v1.32.2...v1.32.3)

---
updated-dependencies:
- dependency-name: github.com/containers/storage
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-06-18 14:46:38 +00:00
dependabot[bot] d398230853
Bump k8s.io/apimachinery from 0.21.1 to 0.21.2
Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.21.1 to 0.21.2.
- [Release notes](https://github.com/kubernetes/apimachinery/releases)
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.21.1...v0.21.2)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-06-18 14:46:21 +00:00
OpenShift Merge Robot 48db8d9868
Merge pull request #10690 from rhatdan/VENDOR
Vendor in containers/common v0.40.0
2021-06-18 10:37:37 -04:00
OpenShift Merge Robot ce04a3e17f
Merge pull request #10711 from mtrmac/format-docs
Fix documentation of the --format option of podman push
2021-06-17 18:34:24 -04:00
Miloslav Trmač 2bd382c8c7 Fix documentation of the --format option of podman push
It affects all transports; and without --format, we try several manifest formats.

[NO TESTS NEEDED]

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
2021-06-17 21:20:13 +02:00
Daniel J Walsh b6662eed3f
Vendor in containers/common v0.40.0
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-06-17 14:59:42 -04:00
OpenShift Merge Robot 725b5001a1
Merge pull request #10688 from jwhonce/bz/1855983
Scrub podman commands to use report package
2021-06-17 13:58:47 -04:00
Jhon Honce bd9987239d Scrub podman commands to use report package
Refactor podman commands that have drifted from using
c/common report pkg. Report pkg is needed to implement
go template functions.

Removed obsolete code from podman which exists in c/common.

Latest template library added default newlines and method to
remove them. Incorporated needed changes in c/common PR below.

Depends on https://github.com/containers/common/pull/624
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1855983

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2021-06-16 16:53:48 -07:00
OpenShift Merge Robot 814a8b6d71
Merge pull request #10692 from cevich/fix_clone_fail
[CI:DOCS] Fix multi-arch image build clone:failure
2021-06-16 18:33:59 -04:00
Chris Evich 6b230bc924
Fix multi-arch image build clone:failure
A suspected recent change in docker (in github-actions Ubuntu
environment) results in a error:

```
cannot clone: Operation not permitted
Error: cannot re-exec process
```

Fix this by using podman to execute the container instead of docker.

Signed-off-by: Chris Evich <cevich@redhat.com>
2021-06-16 16:44:42 -04:00
OpenShift Merge Robot e73a7dadac
Merge pull request #10699 from cevich/track_temp_double_tags2
[CI:DOCS] Cirrus: Prevent BZ1965743 workaround pruning
2021-06-16 16:12:55 -04:00
OpenShift Merge Robot 2509a81c34
Merge pull request #10683 from Luap99/exec-resize
Fix resize race with podman exec -it
2021-06-16 15:29:34 -04:00
Chris Evich 705b799afc
Cirrus: Prevent BZ1965743 workaround pruning
A hidden non-obvious corner-case of temporary changes introduced by
https://github.com/containers/podman/pull/10451 could be unintended
pruning of some ubuntu images.  This could be impactful if for some
reason the `.cirrus.yml: use c5521575421149184 for Ubuntu` commit is
reverted beyond 30-days (the disused image-prune interval) and the _old_
images are needed (for an unforeseen reason).

Mitigate this by temporarily including the old images in the timestamp
updating task. This commit may be reverted (and the problem ignored)
if new VM images are built and deployed for all OS's (i.e. replacing
the Fedora/Ubuntu tag split workaround needed for the BZ).

Signed-off-by: Chris Evich <cevich@redhat.com>
2021-06-16 15:19:53 -04:00
Alexander Richter e344a5899f [CI:DOCS] UPDATE manpages with MANPAGE_SYNTAX
MANPAGE_SYNTAX was edited.

The following manpages have been adapted to the MANPAGE_SYNTAX:
- podman-container-prune
- podman-container-restore

The following manpages have had little changes:
- podman-attach
- podman-auto-update
- podman-commit
- podman-completion
- podman-container-checkpoint
- podman-container-cleanup
- podman-container-exists

Signed-off-by: Alexander Richter <67486332+Procyhon@users.noreply.github.com>
2021-06-16 17:44:11 +02:00
OpenShift Merge Robot b3f61ec38c
Merge pull request #10451 from giuseppe/test-ENOSYS
tests: update CI images
2021-06-16 11:10:30 -04:00
Paul Holzinger 666f555aa5 Fix resize race with podman exec -it
When starting a process with `podman exec -it` the terminal is resized
after the process is started. To fix this allow exec start to accept the
terminal height and width as parameter and let it resize right before
the process is started.

Fixes #10560

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2021-06-16 16:43:30 +02:00
OpenShift Merge Robot 85bf412bb5
Merge pull request #10684 from Luap99/slirp-hosts
add correct slirp ip to /etc/hosts
2021-06-16 10:10:17 -04:00
OpenShift Merge Robot 1c71c1a540
Merge pull request #10588 from cdoern/imgDocs
[CI:DOCS] converted query parameter for credentials to header parameter.
2021-06-16 06:04:33 -04:00
Giuseppe Scrivano 404d5edb15
.cirrus.yml: use c5521575421149184 for Ubuntu
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2021-06-16 10:16:04 +02:00
Giuseppe Scrivano 769df3207d
test: drop invalid test
runc-1.0-rc95 refuses destination paths that are not absolute.

The test was causing a mount with a destination "[/etc/foo]" causing
the OCI runtime to fail.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2021-06-16 10:16:04 +02:00
Giuseppe Scrivano 969cc3237b
utils: move message from warning to debug
if a pid could not be moved to a new cgroup, print a debug message
instead of a warning.

Closes: https://github.com/containers/podman/issues/10674

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2021-06-16 08:49:57 +02:00
Giuseppe Scrivano 5174797316
utils: improve error message
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2021-06-16 08:49:56 +02:00
OpenShift Merge Robot 092b2ecafc
Merge pull request #10629 from dilyanpalauzov/master
[CI:DOCS] podman-run.1.md:detach-keys: spell the default value just once
2021-06-15 16:37:11 -04:00
cdoern eb927dc84e Docs Switch from Query Param to Header
credentials switched from query param to header x-reg due to podman parsing the header for credentials not the query itself.

Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
2021-06-15 16:22:01 -04:00
Daniel J Walsh 8d3a828383
Merge pull request #10680 from bburky/dockerfile-volume-permissions
Create user storage dir with correct permissions in Dockerfiles
2021-06-15 16:19:26 -04:00
OpenShift Merge Robot 0c204084b4
Merge pull request #10679 from cevich/fix_static_build
Fix building static podman-remote
2021-06-15 16:19:10 -04:00
OpenShift Merge Robot e405f12053
Merge pull request #10531 from rhatdan/volume
Fix permissions on initially created named volumes
2021-06-15 16:13:13 -04:00
OpenShift Merge Robot b422a4eb49
Merge pull request #10595 from boaz0/closes_10539
Add podman-restart systemd unit file
2021-06-15 16:12:13 -04:00
OpenShift Merge Robot 463a5a7db5
Merge pull request #10622 from cdoern/imgImportFeature
compat import imageFromSrc support for platform query parameter
2021-06-15 12:43:15 -04:00
OpenShift Merge Robot 6b517a7e90
Merge pull request #10668 from zhangguanzhang/panic-cgroup
[NO TESTS NEEDED] Fixes panic condition in cgroups.getAvailableControllers
2021-06-15 09:29:33 -04:00
Paul Holzinger 9c81b8cf72 add correct slirp ip to /etc/hosts
The container name should have the slirp interface ip set in /etc/hosts
and not the gateway ip. Commit c8dfcce6db introduced this regression.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1972073

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2021-06-15 13:41:14 +02:00
zhangguanzhang fc9868e224 Fix panic condition in cgroups.getAvailableControllers
Signed-off-by: zhangguanzhang <zhangguanzhang@qq.com>
2021-06-15 09:22:37 +08:00
Blake Burkhart 2a974e8b94 Create user storage dir with correct permissions
Docker VOLUMEs will inherit permissions from an existing directory at the same
path. If the path does not exist, the directory will be owned by root which
makes this image unusable in rootless mode.

Signed-off-by: Blake Burkhart <blake.burkhart@us.af.mil>
2021-06-14 14:40:36 -05:00
Chris Evich 5f2c0f63ad
Fix building static podman-remote
As near as I can tell, sometime between `v1.6.4` and `v1.9` the definition
of `LDFLAGS_PODMAN_STATIC` was both created and lost.  Additionally, after
a refactoring of the `Makefile` it was possible to enable CGO (which
will cause a dynamic binary to be built).  Fix both issues by adding the
missing definition and forcing CGO to be disabled.

Signed-off-by: Chris Evich <cevich@redhat.com>
2021-06-14 14:53:47 -04:00
OpenShift Merge Robot e2f51eeb06
Merge pull request #10651 from rhatdan/build
Add support for podman remote build -f - .
2021-06-14 13:04:03 -04:00
Daniel J Walsh 81eb71fe36
Fix permissions on initially created named volumes
Permission of volume should match the directory it is being mounted on.

Fixes: https://github.com/containers/podman/issues/10188

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-06-14 11:56:48 -04:00
OpenShift Merge Robot e3dd12a2be
Merge pull request #10652 from rhatdan/devices
Fix handling of podman-remote build --device
2021-06-14 09:09:16 -04:00
cdoern 3ddadc5326 Image import fromSrc now supports OS/Arch
added handling in entities and compat to support passing a specified OS/Arch while importing from SRC.

fixes #10566

Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
2021-06-14 09:05:01 -04:00