Commit Graph

25449 Commits

Author SHA1 Message Date
Dominique Martinet 90ee7c86a3 podman: remember hooks-dir on restarts
When podman restarts config values within the Engine are lost.
Add --hook-dirs arguments as appropriate to the cleanup command
so that hooks are preserved on restarts due to the on-restart setting

Tests: add a check that prestart/poststop hooks ran every time after 2
restarts.
`wait_for_restart_count` was re-used to wait for restarts and moved to
helpers file.

Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
Fixes: #17935
2025-05-15 14:23:22 +09:00
Ashley Cui 53f118d135 GHA Release: Fix windows installer uploads
The new arm and amd installers were left behind, upload them automatically to the GH release

Signed-off-by: Ashley Cui <acui@redhat.com>
2025-05-14 16:09:26 -04:00
Ashley Cui 3e08c2abf0 Revert "GHA: Pin Go to 1.24.2"
This reverts commit fb9ef0dda0.
Use latest stable go to build release artifacts.

Signed-off-by: Ashley Cui <acui@redhat.com>
2025-05-14 16:08:33 -04:00
openshift-merge-bot[bot] 571a2e48c9
Merge pull request #26137 from Luap99/purego
fix macos compile issue with go 1.24.3
2025-05-14 17:59:02 +00:00
Paul Holzinger db65baaa21
fix macos compile issue with go 1.24.3
Some changes in go broke purego and that causes a compile error on
macos. This update fixes it.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-05-14 18:11:55 +02:00
Siteshwar Vashisht 206d92c25f Packit: disable OpenScanHub scans
Re-enabling them can be considered in the future if OpenScanHub starts
scanning Go code.

Signed-off-by: Siteshwar Vashisht <svashisht@redhat.com>
2025-05-14 17:55:33 +02:00
openshift-merge-bot[bot] f1b457729f
Merge pull request #26133 from ashley-cui/gha
GHA: Pin Go to 1.24.2
2025-05-14 15:37:49 +00:00
Ashley Cui fb9ef0dda0 GHA: Pin Go to 1.24.2
There is a bug that makes building with the latest go to fail. Pin to 1.24.2 for now.

Signed-off-by: Ashley Cui <acui@redhat.com>
2025-05-14 11:08:25 -04:00
openshift-merge-bot[bot] 863621ee5a
Merge pull request #26123 from containers/renovate/github.com-vbauerster-mpb-v8-8.x
fix(deps): update module github.com/vbauerster/mpb/v8 to v8.10.1
2025-05-13 16:57:50 +00:00
renovate[bot] fe84fbae72
fix(deps): update module github.com/vbauerster/mpb/v8 to v8.10.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-13 15:58:27 +00:00
Paul Holzinger 637c264e2e
fix issues found by nilness
The conditions are always true so they can be removed. And in the case
of exportCheckpoint() the scope means addToTarFiles was overwritten and
thus when it looped over it later the slice was always empty.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-05-13 17:20:10 +02:00
openshift-merge-bot[bot] 76e11cf5fc
Merge pull request #25608 from containers/renovate/github.com-crc-org-vfkit-0.x
fix(deps): update module github.com/crc-org/vfkit to v0.6.1
2025-05-13 12:19:13 +00:00
openshift-merge-bot[bot] 1cc6b5c1cc
Merge pull request #26119 from slp/update-krunkit-0.2.1
Bump bundled krunkit to 0.2.1
2025-05-13 10:33:56 +00:00
openshift-merge-bot[bot] 9938feb356
Merge pull request #25537 from containers/renovate/github.com-rootless-containers-rootlesskit-v2-2.x
fix(deps): update module github.com/rootless-containers/rootlesskit/v2 to v2.3.5
2025-05-13 10:03:37 +00:00
openshift-merge-bot[bot] a1ac6c33cc
Merge pull request #26113 from ygalblum/quadlet-pod-name
Quadlet - restore pod name to not use systemd specifiers
2025-05-12 23:22:28 +00:00
openshift-merge-bot[bot] cbcb777920
Merge pull request #26112 from siteshwar/fix-shellcheck
Fix a shellcheck warning about word splitting
2025-05-12 23:19:42 +00:00
openshift-merge-bot[bot] 45fc915dd9
Merge pull request #26117 from containers/renovate/setuptools-80.x
chore(deps): update dependency setuptools to ~=80.4.0
2025-05-12 16:58:17 +00:00
openshift-merge-bot[bot] 93fd26bc58
Merge pull request #25660 from ver4a/main
Fix parsing of paths for unmask
2025-05-12 16:55:30 +00:00
Sergio Lopez 6ae920de8b Bump bundled krunkit to 0.2.1
Bump the bundled krunkit version from 0.2.0 to 0.2.1.

Signed-off-by: Sergio Lopez <slp@redhat.com>
2025-05-12 18:38:28 +02:00
openshift-merge-bot[bot] 6601a0d061
Merge pull request #25980 from containers/renovate/github.com-containernetworking-plugins-1.x
fix(deps): update module github.com/containernetworking/plugins to v1.7.1
2025-05-12 16:32:42 +00:00
openshift-merge-bot[bot] df90606d53
Merge pull request #26086 from Honny1/hc-timeout
Fix: Ensure HealthCheck exec session terminates on timeout
2025-05-12 15:44:18 +00:00
renovate[bot] 59d9f1ea5d
chore(deps): update dependency setuptools to ~=80.4.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-12 15:36:49 +00:00
openshift-merge-bot[bot] e68bd8964d
Merge pull request #20955 from containers/renovate/docker-7.x
chore(deps): update dependency docker to v7
2025-05-12 15:35:56 +00:00
renovate[bot] 5471f6e191
chore(deps): update dependency docker to v7
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-12 15:16:16 +00:00
renovate[bot] 59c45a01c7
fix(deps): update module github.com/rootless-containers/rootlesskit/v2 to v2.3.5
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-12 15:16:07 +00:00
renovate[bot] 6a96f70180
fix(deps): update module github.com/crc-org/vfkit to v0.6.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-12 15:14:39 +00:00
renovate[bot] b572b892b1
fix(deps): update module github.com/containernetworking/plugins to v1.7.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-12 15:12:48 +00:00
Jan Rodák 077649f9d0
Fix: Use SIGKILL instead of SIGTERM when ExecStopContainer timeout is 0
Aligns behavior with documentation stating SIGKILL should be sent immediately if the timeout is zero.

Signed-off-by: Jan Rodák <hony.com@seznam.cz>
2025-05-12 17:01:42 +02:00
Jan Rodák 499ea1168b
Fix: Ensure HealthCheck exec session terminates on timeout
Previously, the HealthCheck exec session would not terminate on timeout, allowing the healthcheck to run indefinitely.

Fixes: https://issues.redhat.com/browse/RHEL-86096

Signed-off-by: Jan Rodák <hony.com@seznam.cz>
2025-05-12 17:01:35 +02:00
Paul Holzinger 74f04e9118
Merge commit from fork
[skip-ci] Tighten version match
2025-05-12 15:54:30 +02:00
Ashley Cui d7fefb7064 [skip-ci] Tighten version match
Tighten the regex needed to match a valid version.

Signed-off-by: Ashley Cui <acui@redhat.com>
2025-05-12 09:44:00 -04:00
Ygal Blum 700c679cd2 Quadlet - Update the docs to reflect the default naming of resources
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2025-05-12 09:33:28 -04:00
Ygal Blum 09d9d3e26b Revert "Quadlet - fix pod name to depend on the name of the generate service"
This reverts commit 4f38c2fea2.

Fixes: #26105
Signed-off-by: Ygal Blum <ygal.blum@gmail.com>
2025-05-12 09:33:16 -04:00
Siteshwar Vashisht 5be3f8d480 Fix a shellcheck warning about word splitting
Error: SHELLCHECK_WARNING (CWE-156): [#def2]
/etc/profile.d/podman-docker.sh:4:10: warning[SC2046]: Quote this to prevent word splitting.
    2|
    3|   if [ -z "${DOCKER_HOST-}" ]; then
    4|->     if [ $(id -u) -eq 0 ]; then
    5|   	export DOCKER_HOST=unix:///run/podman/podman.sock
    6|       else

Resolves: https://openscanhub.fedoraproject.org/task/52458/log/podman-5.4.2-1.fc43/scan-results.html#def2

Signed-off-by: Siteshwar Vashisht <svashisht@redhat.com>
2025-05-12 15:03:54 +02:00
openshift-merge-bot[bot] c0b352f2eb
Merge pull request #26103 from containers/renovate/github.com-vishvananda-netlink-1.x
fix(deps): update module github.com/vishvananda/netlink to v1.3.1
2025-05-12 10:20:37 +00:00
renovate[bot] a5748206d1
fix(deps): update module github.com/vishvananda/netlink to v1.3.1
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-09 21:52:54 +00:00
openshift-merge-bot[bot] 811aabd3b0
Merge pull request #26079 from mvfc/main
Take WSL path from PATH instead of forcing it to WindowsApps
2025-05-09 13:05:03 +00:00
Šimon Škoda 7a161115f9 Fix parsing of paths for unmask
This fixes an issue where multiple paths separated by a colon were
treated as a single path, contrary to what docs say and unlike how mask
option works.

Test was updated with a case that fails without this commit.

Signed-off-by: Šimon Škoda <ver4a@uncontrol.me>
2025-05-09 11:25:30 +00:00
openshift-merge-bot[bot] e138304f33
Merge pull request #26089 from l0rd/release-win-arm64-artifacts
Release win arm64 artifacts
2025-05-08 20:44:29 +00:00
openshift-merge-bot[bot] ec9406af4c
Merge pull request #26076 from containers/renovate/golang.org-x-net-0.x
fix(deps): update module golang.org/x/net to v0.40.0
2025-05-08 15:36:35 +00:00
Matheus Vitório b6eeaea7f3 Take path for wsl instead of forcing through WindowsApps
Signed-off-by: Matheus Cunha <matheusvflor@hotmail.com>
2025-05-08 16:39:03 +02:00
openshift-merge-bot[bot] 58b2eae38c
Merge pull request #25906 from jankaluza/25104-pidfs
Verify the ExecSession pid before killing it.
2025-05-08 10:03:50 +00:00
renovate[bot] d12588f581
fix(deps): update module golang.org/x/net to v0.40.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-08 09:55:33 +00:00
Mario Loriedo 136f2e1ba4 Update win-installer github job for arm64
Adds the build of the arm64 windows installer as part of the release
GitHub workflow.

When a Windows installer is uploaded to the GitHub release, it is named
consistently with the macOS one:

   `podman-installer-windows-${GOARCH}.exe`

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2025-05-07 18:50:04 +02:00
Mario Loriedo efc3b178bb Build windows arm64 artifacts
Includes the necessary changes so that the `Makefile` target
`release-artifacts` builds the `-windows_arm64.zip` too.

In particular the arm64 versions of gvproxy and win-sshproxy
are downloaded as part of the windows arm64 release zip file.

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2025-05-07 18:43:59 +02:00
Mario Loriedo 35e1c2033a Fix windows arm64 installer build
This is a followup of https://github.com/containers/podman/pull/26048

It fixes `process-release.ps1` that was always looking for the amd64 release
zip file, even if `$env:PODMAN_ARCH` was set to arm64. With this fix it looks
for the right zip file.

It fixes `winmake.ps1` that, when the `-arch` param was not passed, set `$env:PODMAN_ARCH`
to the empty string instead of the local `$env:GOARCH`.

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2025-05-07 18:33:32 +02:00
Lokesh Mandvekar f4819412b8
README.md: add openssf passing badge
[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2025-05-07 18:39:18 +05:30
openshift-merge-bot[bot] 1b55e39487
Merge pull request #26083 from itoffshore/secret-create
Update podman-secret-create.1.md
2025-05-07 12:57:54 +00:00
openshift-merge-bot[bot] ce47c999a5
Merge pull request #26085 from containers/renovate/github.com-containers-gvisor-tap-vsock-0.x
fix(deps): update module github.com/containers/gvisor-tap-vsock to v0.8.6
2025-05-07 10:17:30 +00:00
renovate[bot] 9dffc251fc
fix(deps): update module github.com/containers/gvisor-tap-vsock to v0.8.6
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-05-07 09:32:21 +00:00