Commit Graph

21626 Commits

Author SHA1 Message Date
Ed Santiago c823d49fdc CI: unskip tests
New VMs have netavark 1.9, which fixes the "cannot talk to syslog"
warning when running containerized, so we can reenable clean-output
checks in containerized e2e tests

pasta: some new VMs have passt >= 2023-11-10, but f38 does not,
and f39 is unclear (my version extractor could not tell). So
I'm leaving the 20170 skip.

Debian runc now supports umask in *run*, but not *exec*. Even
with runc 1.1.10. And we don't even know what the situation is
on RHEL... so, run the podman-run umask tests but not exec.

Fixes: #19809

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-12-08 15:51:36 -07:00
openshift-merge-bot[bot] d513749085
Merge pull request #20914 from baude/machinehypervregression
Fix regression in e2e machine test suite
2023-12-08 16:16:24 +00:00
openshift-merge-bot[bot] 0a9914f3b2
Merge pull request #20947 from edsantiago/treadmill_cleanup
buildah treadmill: cleaner YAML, uglier script
2023-12-08 14:48:27 +00:00
openshift-merge-bot[bot] 289d6fed6c
Merge pull request #20925 from containers/renovate/actions-setup-go-5.x
[skip-ci] Update actions/setup-go action to v5
2023-12-08 14:26:26 +00:00
openshift-merge-bot[bot] 44a9371164
Merge pull request #20772 from Luap99/rootlessnetns
use rootless netns from c/common
2023-12-08 14:23:40 +00:00
Paul Holzinger 4590b663a7
add test for podman exec --env-file
There was no test for this option, resuse existing podman run
--env-file test for exec as well.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 15:06:24 +01:00
Paul Holzinger 06cee546a3
cli: podman exec --env-file use StringArray()
This option accepts a file path so we should allow commas in it.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 15:06:23 +01:00
Paul Holzinger 7866f6c6e1
cli: podman run/create --blkio-weight-device use StringArray()
This option accepts a file path so we should allow commas in it.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 15:06:23 +01:00
Paul Holzinger 432be13301
cli: podman run/create --device-{read,write}-bps use StringArray()
This option accepts a file path so we should allow commas in it.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 15:06:23 +01:00
Paul Holzinger 8de13271ca
cli: podman run/create --device-{read,write}-iops use StringArray()
This option accepts a file path so we should allow commas in it.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 15:06:23 +01:00
Paul Holzinger e763cc62b7
cli: podman run/create --device use StringArray()
This options accepts a file path so we should allow commas in it.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 15:06:23 +01:00
Paul Holzinger 833163ff3e
add podman create --label-file test
There was no test for this option so I added one.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 15:06:23 +01:00
Paul Holzinger 19571f7509
cli: podman run/create --label-file use StringArray()
This option accepts a file path so we should allow commas in it.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 15:06:22 +01:00
Paul Holzinger 24d08a94d8
cli: podman run/create --decryption-key use StringArray()
This option accepts a file path so we should allow commas in it.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 15:06:10 +01:00
openshift-merge-bot[bot] 8edfea423e
Merge pull request #20948 from cfergeau/typo
machine: usb: Fix 'passtrough' typo
2023-12-08 13:06:43 +00:00
openshift-merge-bot[bot] 67a840fefb
Merge pull request #20949 from lsm5/crun-wasm-podman-next-fcos
[CI:BUILD] override crun-wasm in fcos + podman-next image build
2023-12-08 13:03:55 +00:00
Lokesh Mandvekar f9b2da3eb7
[CI:BUILD] override crun-wasm in fcos + podman-next image build
crun-wasm depends on the same epoch:version-release as crun so
overriding `crun` but not `crun-wasm` will cause installation issues
like:
```
error: Could not depsolve transaction; 1 problem detected:
 Problem: package crun-wasm-1.11.1-1.fc39.x86_64 from @System requires crun = 1.11.1-1.fc39, but none of the providers can be installed
  - cannot install both crun-102:1.12-1.20231205201336970037.main.19.g90b21dd.fc39.x86_64 from @commandline and crun-1.11.1-1.fc39.x86_64 from @System
  - cannot install both crun-102:1.12-1.20231205201336970037.main.19.g90b21dd.fc39.x86_64 from @commandline and crun-1.11.1-1.fc39.x86_64 from updates-archive
  - conflicting requests
```

This commit overrides both crun and crun-wasm from what's found in
podman-next.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2023-12-08 17:10:41 +05:30
openshift-merge-bot[bot] 7dc7ae10ed
Merge pull request #20931 from baude/issue20916
[CI:DOCS]use nginx in podman tutorial
2023-12-08 11:36:00 +00:00
Christophe Fergeau 6c2a0196a9 machine: usb: Fix 'passtrough' typo
[NO NEW TESTS NEEDED]

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
2023-12-08 12:24:39 +01:00
Paul Holzinger 201920f6a4
cli: podman run/create --chrootdirs use StringArray()
This options accepts a file path so we should allow commas in it.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 12:17:02 +01:00
Paul Holzinger dbbec99361
cli: podman run/create --log-opt use StringArray()
This option accepts arbitrary input so we should allow commas in it.

Fixes #20064

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 12:17:01 +01:00
Paul Holzinger b011aa4430
cli: podman run/create --env-file use StringArray()
This option accepts a file path so we should allow commas in it.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 12:17:01 +01:00
Paul Holzinger ef10073b51
cli: podman run/create --annotation use StringArray()
This option accepts arbitrary input so we should allow commas in it.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 12:17:01 +01:00
Paul Holzinger c5258d4630
cli: podman --hooks-dir use StringArray()
This option accepts a file path so we should allow commas in it.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 12:17:01 +01:00
Paul Holzinger 12c39ffda2
cli: podman --module use StringArray()
This option accepts a file path so we should allow commas in it.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 12:17:01 +01:00
Paul Holzinger c97560841f
cli: add docs for StringArray vs StringSlice options
In short always use StringArray over StringSlice.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-08 12:16:52 +01:00
Brent Baude 1ebd507fbf Fix regression in e2e machine test suite
A simple regression was introduced to the test suite that overrode the
default image for hyperv testing.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2023-12-07 21:06:46 -06:00
Ed Santiago 95145d957d buildah treadmill: cleaner YAML, uglier script
There's a stanza in .cirrus.yml that only "runs" in
the treadmill cron job ... but that job is long gone.
The task actually runs in the buildah treadmill PR, #13808,
but that's not obvious to someone reading .cirrus.yml.
This is a maintenance burden. Remove it.

Because rootless bud tests are still important, and we
still want to run them in the treadmill PR, modify the
treadmill script itself so it (ugh) injects rootless jobs
into the buildah_bud test matrix. This is super fragile
but acceptable because I am the only one who ever runs
the treadmill script. I will notice if this breaks.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-12-07 17:55:16 -07:00
openshift-merge-bot[bot] deab493ca6
Merge pull request #20930 from rhatdan/VENDOR
Update vendor of containers/storage
2023-12-07 21:29:42 +00:00
openshift-merge-bot[bot] f8c031170b
Merge pull request #20928 from edsantiago/flakey_since
CI: systests: fix flaking --since test
2023-12-07 17:36:51 +00:00
openshift-merge-bot[bot] 8b6eb806c7
Merge pull request #20937 from eriksjolund/fix-issue-20390
[CI:DOCS] compat api: fix formatting syntax
2023-12-07 17:34:12 +00:00
Ed Santiago 0d1b90d367 CI: systests: fix flaking --since test
Very rare flake, probably caused by my nemesis, podman run -d

Solution: keep the sleep-1 (vs using nanosecond resolution),
but make sure we first wait for the output from the container.

Also, bump down the iteration delay in wait_for_output, from 5s to 1.
Thanks to Paul for noticing that.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-12-07 09:41:07 -07:00
openshift-merge-bot[bot] 09d7260e1c
Merge pull request #20929 from n1hility/fix-user-mode-init
Fix user-mode net init flag on first time install
2023-12-07 15:13:57 +00:00
openshift-merge-bot[bot] 1e3b7ccb7e
Merge pull request #20936 from containers/renovate/actions-stale-9.x
[skip-ci] Update actions/stale action to v9
2023-12-07 14:43:33 +00:00
openshift-merge-bot[bot] 4687654100
Merge pull request #20933 from n1hility/improve-ps-errors
Improve error handling in win-lib.ps1
2023-12-07 14:18:50 +00:00
Brent Baude 9a963221b5 [CI:DOCS]use nginx in podman tutorial
the podman tutorial refers to an old httpd image based on Fedora 29.  It
is x86_64 only so Apple Silicon Macs and RPI's cannot follow the
tutorial.  Switch to nginx

Fixes: #20916

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <bbaude@redhat.com>
2023-12-07 07:54:28 -06:00
Erik Sjölund a1cc99dd46 [CI:DOCS] compat api: fix formatting syntax
Reuse text from podman api

Fixes https://github.com/containers/podman/issues/20390

Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2023-12-07 14:27:47 +01:00
renovate[bot] cac4aa3b44
[skip-ci] Update actions/stale action to v9
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-12-07 13:19:55 +00:00
Paul Holzinger 19457f3823
system service: split out cgroups call into linux specific file
So that we do not cause compile errors on freebsd.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-07 11:26:36 +01:00
Paul Holzinger 03d411abc0
libpod: split out cgroups call into linux specific file
So that we do not cause compile error on freebsd.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-07 11:24:47 +01:00
Paul Holzinger 32c25c6026
pkg/specgen/generate: NOP verifyContainerResources() on freebsd
There is no point in calling into cgroup specific code as freebsd does
not support cgroups.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-07 11:24:47 +01:00
Paul Holzinger a687c38860
use rootless netns from c/common
Use the new rootlessnetns logic from c/common, drop the podman code
here and make use of the new much simpler API.

ref: https://github.com/containers/common/pull/1761

[NO NEW TESTS NEEDED]

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-07 11:24:46 +01:00
Jason T. Greene 3d740674b3 Improve error handling in win-lib.ps1
- Modified Check-Exit to take a relative stack postition so that reusing
  functions like Run-Command report on their callers as opposed to the source
  position of the wrapper.
- Record and print the last command executed as it likely scrolled off with
  test output.

[NO NEW TESTS NEEDED]

Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2023-12-06 21:49:33 -06:00
Daniel J Walsh d78212a009
Update vendor of containers/storage
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-12-06 16:13:43 -05:00
Jason T. Greene 98df5b3978 Fix user-mode net init flag on first time install
Previously the WSL user-mode networking distribution was only installed as part
of a change, when it should have been also applied installs. This mean that the
init flag usage only worked after a previous set command.

[NO NEW TESTS NEEDED]

Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2023-12-06 14:46:12 -06:00
openshift-merge-bot[bot] 605a29a714
Merge pull request #20924 from Luap99/labeler
[CI:DOCS] fix broken labeler.yml config
2023-12-06 18:34:17 +00:00
renovate[bot] 10db6442de
[skip-ci] Update actions/setup-go action to v5
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-12-06 15:39:02 +00:00
openshift-merge-bot[bot] a64cc98179
Merge pull request #20912 from edsantiago/fix_some_cp_flakes
systests: cp: add wait_for_ready
2023-12-06 15:38:37 +00:00
Paul Holzinger 8d8fb726f3
fix broken labeler.yml config
Commit ca66a90b87 was merged without fixing the config. Please read
changelogs before merging renovate PRs, especially when it is a major
version bump.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-06 16:06:07 +01:00
openshift-merge-bot[bot] 72ceb6ee82
Merge pull request #20905 from Odilhao/issue-20585-entrypoint
Add support for Entrypoint in quadlet
2023-12-06 14:13:03 +00:00