OpenShift Merge Robot
5260d33f95
Merge pull request #2952 from rhatdan/change
...
Fix podman command --change CMD
2019-04-18 05:23:43 -07:00
OpenShift Merge Robot
8b027dee48
Merge pull request #2965 from baude/fixcopr
...
Fix COPR builds to start working again
2019-04-18 01:31:20 -07:00
baude
7987a1dfee
Fix COPR builds to start working again
...
We now need systemd in the root of the COPR build for podman.
Signed-off-by: baude <bbaude@redhat.com>
2019-04-17 16:12:54 -05:00
Daniel J Walsh
6b3d4abb07
Fix podman command --change CMD
...
Currently in Docker if you commit with --change 'CMD a b c'
The command that gets added is
[/bin/sh -c "a b c"]
If you commit --change 'CMD ["a","b","c"]'
You get
[a b c]
This patch set makes podman match this behaviour.
Similar change required for Entrypoint.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-04-17 15:44:50 -04:00
OpenShift Merge Robot
bf5ffdafb4
Merge pull request #2917 from baude/remotestart
...
podman-remote start
2019-04-17 10:13:18 -07:00
baude
3c0147e559
podman-remote start
...
enable the ability to start containers from the remote-client. also,
enable start integration tests for remote testing.
Signed-off-by: baude <bbaude@redhat.com>
2019-04-17 11:08:54 -05:00
OpenShift Merge Robot
799d4667c1
Merge pull request #2936 from haircommander/pod-prune
...
Add podman pod prune
2019-04-17 08:55:59 -07:00
OpenShift Merge Robot
d0c5e216ca
Merge pull request #2931 from TomSweeneyRedHat/dev/tsweeney/venbuildah
...
Vendor in latest Buildah
2019-04-17 06:50:48 -07:00
TomSweeneyRedHat
024ae24f14
Vendor in latest Buildah
...
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2019-04-16 15:20:17 -04:00
OpenShift Merge Robot
a87cf6fef8
Merge pull request #2949 from baude/remotecontainercommands
...
podman-remote container commands
2019-04-16 09:38:35 -07:00
Peter Hunt
4319552cf8
Added remote pod prune
...
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-04-16 11:23:18 -04:00
Peter Hunt
0b34b4a59c
Add podman pod prune
...
podman system prune would leave pods be, and not prune them if they were stopped.
Fix this by adding a `podman pod prune` command that prunes stopped pods similarly to containers.
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-04-16 11:23:18 -04:00
baude
7cea949f04
podman-remote container commands
...
Several container commands were ported to the remote client but had not
been updated on the container submenu yet.
Signed-off-by: baude <bbaude@redhat.com>
2019-04-16 10:22:50 -05:00
OpenShift Merge Robot
a2e9626d92
Merge pull request #2934 from haircommander/kube-file
...
Add File mounts to play kube
2019-04-16 08:05:44 -07:00
OpenShift Merge Robot
713839cf83
Merge pull request #2946 from baude/segs
...
Fix segfaults attribute to missing options
2019-04-16 06:25:41 -07:00
baude
6fb0a706af
Fix segfaults attribute to missing options
...
In cases where the remote client culls options to a command, we need to
be sure that the lookup for that flag does not result in a nil pointer.
To do so, we add a Remote attribute to the podman struct and then cli
helper funcs are now aware they are remote.
Signed-off-by: baude <bbaude@redhat.com>
2019-04-15 12:21:51 -05:00
OpenShift Merge Robot
c1e2b583c8
Merge pull request #2944 from mheon/fix_renumber
...
Call the runtime with WithRenumber() when asked by 'system renumber' command
2019-04-15 09:39:17 -07:00
Matthew Heon
936537cfe7
Call the runtime with WithRenumber() when asked
...
We must have lost this at some point, rendering system renumber
useless.
Signed-off-by: Matthew Heon <mheon@redhat.com>
2019-04-15 10:36:19 -04:00
OpenShift Merge Robot
6f3f0267f2
Merge pull request #2870 from rhatdan/change
...
Validate ENV/LABEL Change options in varlink
2019-04-15 07:21:37 -07:00
OpenShift Merge Robot
e5227919af
Merge pull request #2939 from giuseppe/rootless-fixes
...
rootless: cleanups
2019-04-15 07:08:28 -07:00
Peter Hunt
2f804ea9a2
Add File mounts to play kube
...
Both File and FileOrCreate options are supported.
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-04-15 09:27:36 -04:00
OpenShift Merge Robot
6e1dab76e2
Merge pull request #2921 from rhatdan/man
...
Remove old crio reference from man pages
2019-04-15 06:22:35 -07:00
Giuseppe Scrivano
187de9f98e
cmd, pkg: drop commented code
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-04-15 13:00:54 +02:00
Giuseppe Scrivano
a09b6bf77d
pod: drop dead code
...
we always create a user namespace now, so no need to check if we are
running as non root.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-04-15 12:59:46 +02:00
Giuseppe Scrivano
ffd8999421
rootless, mount: not create namespace
...
we need to check if we are able to mount the container as part of the
mount command itself.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-04-15 12:57:19 +02:00
OpenShift Merge Robot
d10f68ac95
Merge pull request #2932 from haircommander/kube-env
...
Incorporate image and default environment variables in play kube
2019-04-15 00:43:16 -07:00
Peter Hunt
e61838bc3b
Incorporate image and default environment variables in play kube
...
Also put Environment variable parsing from image data into a helper function
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-04-14 16:27:52 -04:00
OpenShift Merge Robot
167ce59416
Merge pull request #2928 from giuseppe/fix-umount
...
oci: fix umount of /sys/kernel
2019-04-14 06:29:42 -07:00
OpenShift Merge Robot
eed8bbf3f9
Merge pull request #2927 from giuseppe/fix-tty-rootless
...
Revert "rootless: set controlling terminal for podman in the userns"
2019-04-14 06:21:41 -07:00
OpenShift Merge Robot
f929b9e4d5
Merge pull request #2501 from mtrmac/fixed-hook-order
...
RFC: Make hooks sort order locale-independent
2019-04-14 03:09:41 -07:00
Daniel J Walsh
cd952068f3
Validate ENV/LABEL Change options in varlink
...
If you pass in an invalid CHANGE ENV or LABEL option without the "=" character
podman crashes.
I see that there were other problems with the handling of commit --change handling.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-04-14 05:57:38 -04:00
OpenShift Merge Robot
9acc9cd58c
Merge pull request #2912 from adrianreber/label
...
Use the same SELinux label for CRIU log files
2019-04-14 02:02:40 -07:00
Giuseppe Scrivano
5e6065d9ac
oci: fix umount of /sys/kernel
...
if the mount was already umounted as part of the cleanup (i.e. being a
submount), the umount would fail.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-04-14 09:54:15 +02:00
Giuseppe Scrivano
9e79530f8f
Revert "rootless: set controlling terminal for podman in the userns"
...
This reverts commit 531514e823
.
Closes: https://github.com/containers/libpod/issues/2926
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-04-14 07:48:37 +02:00
OpenShift Merge Robot
b9260053e9
Merge pull request #2916 from vsoch/add/ubuntu-uidmap-install
...
Adding uidmap to install steps for ubuntu
2019-04-13 05:51:07 -07:00
Daniel J Walsh
7db2994a81
Remove old crio reference from man pages
...
Seems like we have some old references to crio man pages left
over in the docs, since we don't mention crio in man pages
we should not be referencing the man page in the see-also.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-04-13 06:31:00 -04:00
OpenShift Merge Robot
4daf788022
Merge pull request #2830 from baude/remotecheckpoint
...
remote-client checkpoint/restore
2019-04-13 03:23:42 -07:00
OpenShift Merge Robot
37598ab896
Merge pull request #2915 from giuseppe/rootless-do-not-block-sigtstp
...
rootless: do not block SIGTSTP
2019-04-13 03:07:48 -07:00
OpenShift Merge Robot
852ca40665
Merge pull request #2910 from giuseppe/fix-create-2-containers
...
create: fix segfault if container name already exists
2019-04-13 01:32:37 -07:00
Giuseppe Scrivano
0a7b5b4e08
create: fix segfault if container name already exists
...
do not try to use ctr if there was an error. It fixes a segfault when
there is already a container with the same name.
regression introduced by: ba65301c95
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-04-12 22:14:00 +02:00
Vanessa Sochat
02541388df
adding uidmap to install steps for ubuntu
...
Signed-off-by: Vanessa Sochat <vsochat@stanford.edu>
2019-04-12 15:42:30 -04:00
OpenShift Merge Robot
15723671b3
Merge pull request #2911 from giuseppe/fix-pull-errors
...
pull: fix a couple of issues
2019-04-12 12:40:51 -07:00
OpenShift Merge Robot
89ffcf9df9
Merge pull request #2903 from baude/remotegenkube
...
podman-remote generate kube
2019-04-12 11:03:20 -07:00
baude
80b2c097fe
podman-remote generate kube
...
Allow the ability to generate kube YAML from the podman remote-client.
Signed-off-by: baude <bbaude@redhat.com>
2019-04-12 12:05:09 -05:00
OpenShift Merge Robot
61fa40b256
Merge pull request #2913 from mheon/get_instead_of_lookup
...
Use GetContainer instead of LookupContainer for full ID
2019-04-12 09:38:48 -07:00
Giuseppe Scrivano
814066ee3b
rootless: do not block SIGTSTP
...
we were previously proxying all the signals, but doing that for
SIGTSTP prevented the main process to be stopped by the tty.
Closes: https://github.com/containers/libpod/issues/2775
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-04-12 18:20:40 +02:00
Giuseppe Scrivano
531514e823
rootless: set controlling terminal for podman in the userns
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-04-12 18:20:28 +02:00
Matthew Heon
f7951c8776
Use GetContainer instead of LookupContainer for full ID
...
All IDs in libpod are stored as a full container ID. We can get a
container by full ID faster with GetContainer (which directly
retrieves) than LookupContainer (which finds a match, then
retrieves). No reason to use Lookup when we have full IDs present
and available.
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-04-12 10:59:00 -04:00
OpenShift Merge Robot
6ddc67c694
Merge pull request #2907 from edsantiago/uidmap_test_fix
...
new uidmap BATS test: fix
2019-04-12 07:17:32 -07:00
Giuseppe Scrivano
fcea6fda82
pull: exit with error if the image is not found
...
Closes: https://github.com/containers/libpod/issues/2785
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-04-12 15:24:22 +02:00