Commit Graph

6355 Commits

Author SHA1 Message Date
Giuseppe Scrivano 14fe39968f
rootless: force resources to be nil on cgroup v1
force the resources block to be empty instead of having default
values.

Regression introduced by 8e88461511

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-05-20 21:45:05 +02:00
OpenShift Merge Robot 9567d87bdf
Merge pull request #3152 from rhatdan/remote
install.remote should be separate for install.bin
2019-05-20 20:26:09 +02:00
OpenShift Merge Robot 0804b28825
Merge pull request #3092 from mheon/jhonce_approver
Add Jhon Honce (@jwhonce on github) to OWNERS
2019-05-20 20:17:06 +02:00
Daniel J Walsh baed81029b
Fixup Flags
Mark hidden all references to signature-policy
Default all uses of --authfile
Add --authfile support to podman run and podman create.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-05-20 13:53:32 -04:00
Divyansh Kamboj c6f7066e77 Minor fix filtering images by label
Added test to avoid future regressions

Fix #3163

Signed-off-by: Divyansh Kamboj <kambojdivyansh2000@gmail.com>
2019-05-20 23:11:48 +05:30
Giuseppe Scrivano f86bb561ef
container: move channel close to its writer
let the writer of the channel close it.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-05-20 19:41:02 +02:00
Giuseppe Scrivano 57e781462c
util: fix race condition in WaitForFile
enable polling also when using inotify.  It is generally useful to
have it as under high load inotify can lose notifications.  It also
solves a race condition where the file is created while the watcher
is configured and it'd wait until the timeout and fail.

Closes: https://github.com/containers/libpod/issues/2942

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-05-20 19:40:15 +02:00
Daniel J Walsh 1d505f6875
Update vendor of buildah and containers/images
Mainly add support for podman build using --overlay mounts.

Updates containers/image also adds better support for new registries.conf
file.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-05-20 13:39:40 -04:00
OpenShift Merge Robot 8d5432932d
Merge pull request #3139 from jwhonce/wip/remote_info
Add connection information to podman-remote info
2019-05-20 17:20:59 +02:00
OpenShift Merge Robot 27f9e23a0b
Merge pull request #3164 from rhatdan/apparmor
Don't set apparmor if --priviliged
2019-05-20 17:05:08 +02:00
OpenShift Merge Robot 18a953918e
Merge pull request #3154 from haircommander/tutorial-conmon
Fixup conmon documentation
2019-05-20 15:46:58 +02:00
Matthew Heon 8719cb828c Add Jhon Honce (@jwhonce on github) to OWNERS
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-05-20 09:35:17 -04:00
Daniel J Walsh db218e7162
Don't set apparmor if --priviliged
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-05-20 09:11:16 -04:00
OpenShift Merge Robot a83edf23ac
Merge pull request #3158 from kofalt/runlabel-formating
Output name of process on runlabel command
2019-05-20 10:42:52 +02:00
OpenShift Merge Robot 5c0dfd0a4d
Merge pull request #3160 from wking/have-higher-precedence-typo
docs/libpod.conf.5: Add "have" to "higher precedence" typo
2019-05-20 09:46:52 +02:00
W. Trevor King d85a9bff83 docs/libpod.conf.5: Add "have" to "higher precedence" typo
I'd left this out in a4b483c848 (libpod/container_internal: Deprecate
implicit hook directories, 2018-12-02, #1920).

Signed-off-by: W. Trevor King <wking@tremily.us>
2019-05-19 07:25:05 -07:00
Nathaniel Kofalt f4a4c7cda0 Output name of process on runlabel command
Signed-off-by: Nathaniel Kofalt <nathaniel@kofalt.com>
2019-05-18 23:31:52 -05:00
OpenShift Merge Robot ce84c3afdb
Merge pull request #3138 from weirdwiz/env-var
Minor fix splitting env vars in podman-commit
2019-05-19 06:31:25 +02:00
Divyansh Kamboj ee3381f8f2 Minor fix splitting env vars in podman-commit
`string.Split()` splits into slice of size greater than 2
which may result in loss of environment variables

fixes #3132

Signed-off-by: Divyansh Kamboj <kambojdivyansh2000@gmail.com>
2019-05-19 06:51:30 +05:30
Peter Hunt 900dd3e633 Fixup conmon documentation
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-05-18 19:33:12 -04:00
OpenShift Merge Robot 00ecbfc131
Merge pull request #2844 from haircommander/cri-o-update
move to cri-o/cri-o and build with containers/conmon
2019-05-17 21:49:10 +02:00
OpenShift Merge Robot ba612a098c
Merge pull request #3142 from cevich/confirm_networking
Cirrus: Confirm networking is working
2019-05-17 21:38:14 +02:00
Giuseppe Scrivano 53a76223ee
troubleshooting.md: add note about updating subuid/subgid
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-05-17 20:48:26 +02:00
Giuseppe Scrivano 9dabb16e65
system: migrate stops the pause process
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-05-17 20:48:25 +02:00
Giuseppe Scrivano 562357ebb2
rootless: join namespace immediately when possible
add a shortcut for joining immediately the namespace so we don't need
to re-exec Podman.

With the pause process simplificaton, we can now attempt to join the
namespaces as soon as Podman starts (and before the Go runtime kicks
in), so that we don't need to re-exec and use just one process.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-05-17 20:48:24 +02:00
Giuseppe Scrivano 791d53a214
rootless: use a pause process
use a pause process to keep the user and mount namespace alive.

The pause process is created immediately on reload, and all successive
Podman processes will refer to it for joining the user&mount
namespace.

This solves all the race conditions we had on joining the correct
namespaces using the conmon processes.

As a fallback if the join fails for any reason (e.g. the pause process
was killed), then we try to join the running containers as we were
doing before.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-05-17 20:48:24 +02:00
Giuseppe Scrivano 2e0fef51b3
migrate: not create a new namespace
this leaves the containers stopped but we won't risk to use the wrong
user namespace.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-05-17 20:47:55 +02:00
Daniel J Walsh 6154ba4a80
install.remote should be separate for install.bin
For people who want to install podman remote or podman
only we need to separate out the two install commands.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2019-05-17 14:20:45 -04:00
OpenShift Merge Robot 144244aeed
Merge pull request #3104 from giuseppe/initial-cgroup2
rootless: allow resource isolation with cgroup v2
2019-05-17 19:54:13 +02:00
Chris Evich 0f31c6bdc4
Cirrus: Confirm networking is working
Thanks to @edsantiago for suggestion to use nc

Signed-off-by: Chris Evich <cevich@redhat.com>
2019-05-17 13:25:59 -04:00
Peter Hunt cb0d89c56e Use containers/conmon
There were some build issues updating cri-o to cri-o/cri-o. Since the only thing we need cri-o for is conmon, we should just build using conmon.

Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-05-17 12:54:47 -04:00
OpenShift Merge Robot 41c4721b0b
Merge pull request #3098 from mheon/fix_release_notes
Fix a typo in release notes, and bump README version
2019-05-17 18:36:07 +02:00
OpenShift Merge Robot 07b87b1390
Merge pull request #3149 from nalind/bump-storage
Bump github.com/containers/storage to v1.12.7
2019-05-17 17:36:08 +02:00
Matthew Heon 4b2d743d53 Fix a typo in release notes, and bump README version
Signed-off-by: Matthew Heon <mheon@redhat.com>
2019-05-17 11:16:10 -04:00
Peter Hunt 38333970ba s|kubernetes-sigs/cri-o|cri-o/cri-o|g
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-05-17 11:10:09 -04:00
Nalin Dahyabhai fc4e5f2580 Bump github.com/containers/storage to v1.12.7
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
2019-05-17 10:25:36 -04:00
OpenShift Merge Robot 0e20ae0b3a
Merge pull request #3146 from vrothberg/fix-3145
remote: version: fix nil dereference
2019-05-17 15:04:39 +02:00
Valentin Rothberg 8f7f86d8cd remote: version: fix nil dereference
Fix a nil dereference by passing the PodmanCommand to GetRuntime().

Fixes: #3145
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2019-05-17 11:32:30 +02:00
OpenShift Merge Robot ee1383a7b9
Merge pull request #3091 from cevich/root_rootless_must_die
Replace root-based rootless tests
2019-05-17 02:25:57 +02:00
OpenShift Merge Robot 1b0b738bef
Merge pull request #3140 from mheon/bump-1.3.1
Bump to v1.3.1
2019-05-17 01:20:58 +02:00
Matthew Heon a61ebf0446 Bump gitvalidation epoch
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-05-16 17:38:43 -04:00
Matthew Heon 03918cfd5f Bump to v1.3.2-dev
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-05-16 17:38:43 -04:00
Matthew Heon 7210727e20 Bump to v1.3.1
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-05-16 17:38:43 -04:00
OpenShift Merge Robot e2cd3d2eec
Merge pull request #3141 from mheon/revert_3090
Revert "Add VarlinkCall.RequiresUpgrade() type and method"
2019-05-16 22:59:58 +02:00
Matthew Heon 601fc2ce4f Revert "Add VarlinkCall.RequiresUpgrade() type and method"
This reverts commit bd3154fcf6.

Commit in question may be breaking upstream CI.

Signed-off-by: Matthew Heon <mheon@redhat.com>
2019-05-16 14:36:11 -04:00
Jhon Honce a1c654de94 Add connection information to podman-remote info
Refactor client code to break out building connection string from
making the connection.

Example:

client:
  Connection: unix:/run/podman/io.podman
  Connection Type: DirectConnection
  .
  :

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2019-05-16 11:03:22 -07:00
OpenShift Merge Robot 8161802f7d
Merge pull request #3135 from mheon/release_notes_1.3.1
More release notes for 1.3.1
2019-05-16 18:21:40 +02:00
OpenShift Merge Robot ff70b6031a
Merge pull request #3090 from jwhonce/wip/upgrade_link
Add VarlinkCall.RequiresUpgrade() type and method
2019-05-16 17:07:12 +02:00
Matthew Heon 9b81b0dd59 More release notes
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-05-16 10:49:42 -04:00
Giuseppe Scrivano 8b344065d2
unshare: define CONTAINERS_GRAPHROOT and CONTAINERS_RUNROOT
define two environment variables, that simplify the task of cleaning
up the storage, as we can do something like:

podman unshare sh -c 'rm -rf $CONTAINERS_GRAPHROOT $CONTAINERS_RUNROOT'

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-05-16 16:31:21 +02:00