podman/test/system
Paul Holzinger 4b3890ccac
remote: fix incorrect CONTAINER_CONNECTION parsing
When a user specifies a invalid connection in CONTAINER_CONNECTION then
podman should return a proper error saying so. Currently it ignored the
error and in rootFlags() just exited early with defining any flags. This
caused a panic then when trying to use the flags later.

In order to address this first store the connection error in the
PodmanConfig struct and not abort right away during flag setup. This is
important as the user might have specified a flag with a valid remote
connection. As such we check all flags and only when none were given we
return the connection error.

Also while at it I noticed that the default connection reported via
podman --help was wrong as it only used the old containers.conf field
for it and did not consider the podman-connections.json default.

New regression tests have been added to make sure it behaves correctly.

This fixes the problem reported in the PR #22997.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2024-06-21 14:01:22 +02:00
..
000-TEMPLATE system tests: add assert(), and start using it 2022-04-20 16:14:42 -06:00
001-basic.bats test/system: speed up podman --log-level recognizes log levels 2024-06-04 16:24:00 +02:00
005-info.bats Add rootless network command to `podman info` 2024-03-26 09:56:48 -04:00
010-images.bats rm --force work for more than one arg 2024-04-04 17:47:28 +02:00
011-image.bats system tests: add and use _prefetch 2023-06-26 06:51:01 -06:00
012-manifest.bats podman manifest add: support creating artifact manifest on the fly 2024-02-29 11:47:44 -05:00
015-help.bats add a podman-compose command 2023-07-24 19:23:04 +02:00
020-tag.bats system tests: prevent leading tabs 2023-02-15 13:50:17 -07:00
030-run.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
032-sig-proxy.bats System tests: add test tags 2023-07-26 13:50:33 -06:00
035-logs.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
037-runlabel.bats Also substitute $HOME in runlabel with user's homedir 2024-05-03 14:00:20 +02:00
040-ps.bats test/system: speed up podman ps --external 2024-06-04 16:24:01 +02:00
045-start.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
050-stop.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
055-rm.bats test/system: speed up podman container rm ... 2024-05-29 11:00:51 +02:00
060-mount.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
065-cp.bats test/system: speed up podman cp dir from host to container 2024-06-04 16:24:00 +02:00
070-build.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
075-exec.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
080-pause.bats System tests: add test tags 2023-07-26 13:50:33 -06:00
085-top.bats Fix output of podman --remote top 2023-10-16 17:25:10 -04:00
090-events.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
110-history.bats [systests] new defer-assertion-failure 2023-11-27 11:31:29 -07:00
120-load.bats test/system: speed up basic_{setup,teardown}() 2024-06-18 11:06:50 +02:00
125-import.bats new testimage and systemd-image 2024-02-09 05:26:07 -07:00
130-kill.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
140-diff.bats Replace egrep/fgrep with grep -E/-F 2023-05-03 07:32:42 -06:00
150-login.bats test/system: speed up basic_{setup,teardown}() 2024-06-18 11:06:50 +02:00
160-volumes.bats Only stop chowning volumes once they're not empty 2024-05-22 17:47:01 -04:00
170-run-userns.bats EMERGENCY: fix broken CI 2023-12-11 06:28:21 -07:00
180-blkio.bats CI: reenable tests that are working again 2024-01-16 10:07:48 -07:00
190-run-ipcns.bats System tests: add test tags 2023-07-26 13:50:33 -06:00
195-run-namespaces.bats System tests: add test tags 2023-07-26 13:50:33 -06:00
200-pod.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
220-healthcheck.bats libpod: do not leak systemd hc startup unit timer 2024-06-04 18:03:46 +02:00
250-systemd.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
251-system-service.bats Add test for legacy address without two slashes 2023-09-12 10:42:27 +02:00
252-quadlet.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
255-auto-update.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
260-sdnotify.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
270-socket-activation.bats Vendor latest c/common and fix tests 2024-02-29 12:16:51 -05:00
271-tcp-cors-server.bats Ensure that we appropriately warn that TCP is insecure 2023-07-20 14:22:04 -04:00
272-system-connection.bats remote: fix incorrect CONTAINER_CONNECTION parsing 2024-06-21 14:01:22 +02:00
280-update.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
300-cli-parsing.bats Run codespell on code 2024-01-28 07:30:52 -05:00
320-system-df.bats new testimage and systemd-image 2024-02-09 05:26:07 -07:00
330-corrupt-images.bats CI: systests: safer isolation in registry & tests 2023-12-13 09:46:09 -07:00
331-system-check.bats System tests: add `podman system check` tests 2024-06-04 10:00:37 -04:00
400-unprivileged-access.bats CI: test overlay and vfs 2023-11-17 05:48:50 -07:00
410-selinux.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
420-cgroups.bats libpod: do not move podman with --cgroups=disabled 2024-05-30 16:59:30 +02:00
450-interactive.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
500-networking.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
505-networking-pasta.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
520-checkpoint.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
550-pause-process.bats rootless: fix reexec to use /proc/self/exe 2024-05-14 12:02:19 +02:00
600-completion.bats test/system: speed up podman shell completion test 2024-05-29 11:01:15 +02:00
610-format.bats add a podman-compose command 2023-07-24 19:23:04 +02:00
620-option-conflicts.bats [systests] new defer-assertion-failure 2023-11-27 11:31:29 -07:00
700-play.bats systests: kube: bump up a timeout 2024-06-20 14:37:25 -06:00
710-kube.bats test/system: fix up many tests that do not cleanup 2024-06-18 11:06:49 +02:00
750-trust.bats system tests: add assert(), and start using it 2022-04-20 16:14:42 -06:00
760-system-renumber.bats sqlite_state: Fix RewriteVolumeConfig 2024-06-20 11:39:44 +02:00
800-config.bats vendor: update containers/{buildah,common,image,storage} 2024-04-19 09:52:13 +02:00
850-compose.bats podman compose: only trim path suffix when ssh protocol 2024-02-27 13:44:26 +01:00
900-ssh.bats ssh system test: skip until it becomes a test 2022-11-21 08:02:00 -07:00
950-preexec-hooks.bats Add file swith for pre-exec 2023-04-26 10:20:10 -04:00
999-final.bats systests: add a last-minute check for db backend 2023-11-06 14:15:28 -07:00
README.md test/system: fix documentation 2024-05-15 13:08:39 +02:00
build-systemd-image new testimage and systemd-image 2024-02-09 05:26:07 -07:00
build-testimage new testimage and systemd-image 2024-02-09 05:26:07 -07:00
helpers.bash test/system: check for leaks in teardown suite 2024-06-18 11:06:51 +02:00
helpers.network.bash test, pasta: Ignore deprecated addresses in tests 2024-05-22 17:36:33 +10:00
helpers.registry.bash CI: systests: instrument flaky tests 2024-04-03 05:26:51 -06:00
helpers.sig-proxy.bash pkg/rootless: correctly handle proxy signals on reexec 2023-05-25 16:48:15 +02:00
helpers.systemd.bash systests: debug systemd failures 2023-12-04 09:28:49 -07:00
helpers.t CI: systest: safer random_rfc1918_subnet 2023-10-26 09:19:32 -06:00
setup_suite.bash test/system: check for leaks in teardown suite 2024-06-18 11:06:51 +02:00

README.md

Quick overview of podman system tests. The idea is to use BATS, but with a framework for making it easy to add new tests and to debug failures.

Quick Start

Look at 030-run.bats for a simple but packed example. This introduces the basic set of helper functions:

  • setup (implicit) - resets container storage so there's one and only one (standard) image, and no running containers.

  • parse_table - you can define tables of inputs and expected results, then read those in a while loop. This makes it easy to add new tests. Because bash is not a programming language, the caller of parse_table sometimes needs to massage the returned values; 015-run.bats offers examples of how to deal with the more typical such issues.

  • run_podman - runs command defined in $PODMAN (default: 'podman' but could also be './bin/podman' or 'podman-remote'), with a timeout. Checks its exit status.

  • is - compare actual vs expected output. Emits a useful diagnostic on failure.

  • die - output a properly-formatted message to stderr, and fail test

  • skip_if_rootless - if rootless, skip this test with a helpful message.

  • skip_if_remote - like the above, but skip if testing podman-remote

  • random_string - returns a pseudorandom alphanumeric string

Test files are of the form NNN-name.bats where NNN is a three-digit number. Please preserve this convention, it simplifies viewing the directory and understanding test order. In particular, 00x tests should be reserved for a first-pass fail-fast subset of tests:

bats test/system/00*.bats || exit 1
bats test/system

...the goal being to provide quick feedback on catastrophic failures without having to wait for the entire test suite.

Running tests

To run the tests locally in your sandbox using hack/bats is recommend, check hack/bats --help for info about usage.

To run the entire suite use make localsystem or make remotesystem for podman-remote testing.

Analyzing test failures

The top priority for this scheme is to make it easy to diagnose what went wrong. To that end, podman_run always logs all invoked commands, their output and exit codes. In a normal run you will never see this, but BATS will display it on failure. The goal here is to give you everything you need to diagnose without having to rerun tests.

The is comparison function is designed to emit useful diagnostics, in particular, the actual and expected strings. Please do not use the horrible BATS standard of [ x = y ]; that's nearly useless for tracking down failures.

If the above are not enough to help you track down a failure:

Debugging tests

Some functions have dprint statements. To see the output of these, set PODMAN_TEST_DEBUG="funcname" where funcname is the name of the function or perhaps just a substring.

Requirements

  • bats
  • jq
  • skopeo
  • nmap-ncat
  • httpd-tools
  • openssl
  • socat
  • buildah
  • gnupg

Further Details

TBD. For now, look in helpers.bash; each helper function has (what are intended to be) helpful header comments. For even more examples, see and/or run helpers.t; that's a regression test and provides a thorough set of examples of how the helpers work.