mirror of https://github.com/containers/podman.git
6a696cb8fd
First: fix podman-registry script so it preserves the initial $PODMAN, so all subsequent invocations of ps, logs, and stop will use the same binary and arguments. Until now we've handled this by requiring that our caller manage $PODMAN (and keep it the same), but that's just wrong. Next, simplify the golang interface: move the $PODMAN setting into registry.go, instead of requiring e2e callers to set it. (This could use some work: the local/remote conditional is icky). IMPORTANT: To prevent registry.go from using the wrong podman binary, the Start() call is gone. Only StartWithOptions() is valid now. And, minor cleanup: comments, and add an actual error-message check Reason for this PR is a recurring flake, #18355, whose multiple failure modes I truly can't understand. I don't think this PR is going to fix it, but this is still necessary work. Signed-off-by: Ed Santiago <santiago@redhat.com> |
||
|---|---|---|
| .. | ||
| perf | ||
| podman-registry-go | ||
| apparmor_tag.sh | ||
| bats | ||
| branch_commits.rb | ||
| btrfs_installed_tag.sh | ||
| btrfs_tag.sh | ||
| buildah-vendor-treadmill | ||
| check_root.sh | ||
| fork_exec_snoop.bt | ||
| get_ci_vm.sh | ||
| golangci-lint.sh | ||
| install_catatonit.sh | ||
| install_golangci.sh | ||
| install_swagger.sh | ||
| libdm_tag.sh | ||
| libsubid_tag.sh | ||
| make-and-check-size | ||
| man-page-checker | ||
| man-page-table-check | ||
| markdown-preprocess | ||
| markdown-preprocess-review | ||
| markdown-preprocess.t | ||
| podman-commands.sh | ||
| podman-registry | ||
| podman-socat | ||
| podmansnoop | ||
| podmanv2-retry | ||
| selinux_tag.sh | ||
| swagger-check | ||
| systemd_tag.sh | ||
| tree_status.sh | ||
| xref-docker-options | ||
| xref-helpmsgs-manpages | ||