podman/cmd/podman
Daniel J Walsh 66d60384f4
add --retry --retry-delay to podman run/create
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2024-02-29 10:20:21 -05:00
..
common add --retry --retry-delay to podman run/create 2024-02-29 10:20:21 -05:00
completion Bump Go module to v5 2024-02-08 09:35:39 -05:00
containers add --retry --retry-delay to podman run/create 2024-02-29 10:20:21 -05:00
diff Bump Go module to v5 2024-02-08 09:35:39 -05:00
farm Bump Go module to v5 2024-02-08 09:35:39 -05:00
generate Bump Go module to v5 2024-02-08 09:35:39 -05:00
healthcheck Bump Go module to v5 2024-02-08 09:35:39 -05:00
images Add support for podman push --retry --retry-delay 2024-02-29 10:20:21 -05:00
inspect Bump Go module to v5 2024-02-08 09:35:39 -05:00
kube Comply to Kubernetes specifications for annotation size. 2024-02-20 14:58:35 -08:00
machine Move locks to shim layer 2024-02-29 00:12:04 -05:00
manifest Bump Go module to v5 2024-02-08 09:35:39 -05:00
networks podman network inspect: include running containers 2024-02-28 16:33:26 +01:00
parse Replace strings.SplitN with strings.Cut 2024-01-11 13:50:15 +00:00
pods Merge pull request #21512 from Luap99/pasta-netname-removal 2024-02-08 17:17:55 +00:00
registry Add support for podman push --retry --retry-delay 2024-02-29 10:20:21 -05:00
secrets Bump Go module to v5 2024-02-08 09:35:39 -05:00
system cmd/podman: remove duplicated event ToHumanReadable() 2024-02-22 12:10:57 +01:00
utils Bump Go module to v5 2024-02-08 09:35:39 -05:00
validate Bump Go module to v5 2024-02-08 09:35:39 -05:00
volumes Bump Go module to v5 2024-02-08 09:35:39 -05:00
README.md cli: add docs for StringArray vs StringSlice options 2023-12-08 12:16:52 +01:00
auto-update.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
client.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
client_supported.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
client_unsupported.go Show client info even if remote connection fails 2023-10-13 08:53:56 -05:00
compose.go podman compose: only trim path suffix when ssh protocol 2024-02-27 13:44:26 +01:00
compose_machine.go podman compose: correctly accept --connection/--url 2024-02-27 13:40:41 +01:00
compose_machine_unsupported.go podman compose: correctly accept --connection/--url 2024-02-27 13:40:41 +01:00
diff.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
early_init_darwin.go set RLIMIT_NOFILE soft limit to match the hard limit on mac 2023-11-10 15:35:57 -06:00
early_init_linux.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
early_init_unsupported.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
inspect.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
login.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
logout.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
main.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
root.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
root_test.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
shell_completion_test.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
syslog_common.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
syslog_unsupported.go Bump Go module to v5 2024-02-08 09:35:39 -05:00

README.md

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/podman/cmd/podman/manifest

Create the file $GOPATH/src/github.com/containers/podman/cmd/podman/manifest/manifest.go

package manifest

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/cmd/podman/validate"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/podman/cmd/podman/main.go to add:

package main

import	_ "github.com/containers/podman/cmd/podman/manifest"

Adding a new sub command podman manifest list

Create the file $GOPATH/src/github.com/containers/podman/cmd/podman/manifest/inspect.go

package manifest

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())
    

Adding CLI flags

When adding adding a new cli option that accepts a string array, there are two options to choose from: StringSlice() and StringArray(). They differ slightly in their behavior: StringSlice() allows the values to be comma separated so --opt v1,v2 --opt v3 results in []string{"v1", "v2", "v3"}, while StringArray() would result in []string{"v1,v2", "v3"}. Thus it is impossible to use values with comma in StringSlice(), which makes it unsuitable for flags that accept arbitrary values such as file paths as example. Also, because StringSlice() uses the csv lib to parse the values, it has special escaping rules for things like quotes, see https://github.com/containers/podman/issues/20064 for an example of how complicated things can get because of this. Thus use StringSlice() only when the option accepts predefined values that do not contain special characters, for example --cap-add and --cap-drop are a good example for this. Using --cap-add NET_ADMIN,NET_RAW is equal to --cap-add NET_ADMIN --cap-add NET_RAW so it is better suited to save some typing for users. When in doubt always choose StringArray() over StringSlice().