mirror of https://github.com/containers/podman.git
4b22913e11
And add an argument to WithHooksDir to set it. If the hook dir doesn't exist, the new hooks package considers that a fatal error. When a podman caller sets --hooks-dir-path=/some/typoed/directory, a fatal error is more helpful than silently not loading any hooks. However, callers who call podman without setting --hooks-dir-path may not need hooks at all. We don't want to pester those callers with not-exist errors. With this commit, we: * Assume the caller knows what they're doing if they set --hooks-dir-path and set HooksDirNotExistFatal. * If the caller does not explicitly set --hooks-dir-path, assume they won't mind if the hook directory is missing and set HooksDirNotExistFatal false. We also considered checking for the directory's existence in the code calling WithHooksDir or from within WithHooksDir, but checks there would race with the underlying ioutil.ReadDir in the hooks package. By pushing the warn/error decision down into libpod's implementation, we avoid a racy "do we expect this to work once libpod gets to it?" pre-check. I've also added a check to error if WithHooksDir is called with an empty-string argument, because we haven't defined the semantics of that (is it clearing a previous value? Is it effectively the same as the current directory?). I agree with Matthew that a separate WithNoHooks, or a *string argument to WithHooks, or some such would be a better API for clearing previous values [1]. But for now, I'm just erroring out to fail early for callers who might otherwise be surprised that libpod ignores empty-string HooksDir. [1]: https://github.com/projectatomic/libpod/pull/686#issuecomment-385119370 Signed-off-by: W. Trevor King <wking@tremily.us> Closes: #686 Approved by: mheon |
||
|---|---|---|
| .. | ||
| common | ||
| driver | ||
| image | ||
| layers | ||
| testdata | ||
| boltdb_state.go | ||
| boltdb_state_internal.go | ||
| common_test.go | ||
| container.go | ||
| container_api.go | ||
| container_attach.go | ||
| container_commit.go | ||
| container_graph.go | ||
| container_graph_test.go | ||
| container_inspect.go | ||
| container_internal.go | ||
| container_top.go | ||
| diff.go | ||
| errors.go | ||
| finished_32.go | ||
| finished_64.go | ||
| in_memory_state.go | ||
| info.go | ||
| networking.go | ||
| oci.go | ||
| options.go | ||
| pod.go | ||
| runtime.go | ||
| runtime_ctr.go | ||
| runtime_img.go | ||
| runtime_img_test.go | ||
| runtime_pod.go | ||
| state.go | ||
| state_test.go | ||
| stats.go | ||
| storage.go | ||
| util.go | ||
| util_test.go | ||
| version.go | ||