containers
/
podman
mirror of https://github.com/containers/podman.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
podman/libpod
History
Paul Holzinger 51fbf3da9e
enable gocritic linter 
The linter ensures a common code style.
- use switch/case instead of else if
- use if instead of switch/case for single case statement
- add space between comment and text
- detect the use of defer with os.Exit()
- use short form var += "..." instead of var = var + "..."
- detect problems with append()
```
newSlice := append(orgSlice, val)
```
  This could lead to nasty bugs because the orgSlice will be changed in
  place if it has enough capacity too hold the new elements. Thus we
  newSlice might not be a copy.

Of course most of the changes are just cosmetic and do not cause any
logic errors but I think it is a good idea to enforce a common style.
This should help maintainability.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
 		2022-04-26 18:12:22 +02:00
..
common fix a number of `godot` issues 2022-03-22 13:04:35 +01:00
define enable gocritic linter 2022-04-26 18:12:22 +02:00
driver bump go module to version 4 2022-01-18 12:47:07 +01:00
events vendor c/common 2022-04-21 13:43:58 +02:00
layers
…
linkmode go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00
lock replace golint with revive linter 2022-04-22 15:12:33 +02:00
logs enable gocritic linter 2022-04-26 18:12:22 +02:00
plugin bump go module to version 4 2022-01-18 12:47:07 +01:00
shutdown Fix CI flake on time of shutdown for API service 2021-10-12 09:53:19 -07:00
boltdb_state.go fix a number of errcheck issues 2022-03-22 13:15:28 +01:00
boltdb_state_internal.go bump go module to version 4 2022-01-18 12:47:07 +01:00
boltdb_state_linux.go go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00
common_test.go bump go module to version 4 2022-01-18 12:47:07 +01:00
container.go enable gocritic linter 2022-04-26 18:12:22 +02:00
container_api.go enable gocritic linter 2022-04-26 18:12:22 +02:00
container_commit.go container-commit: support --squash to squash layers into one 2022-02-23 17:38:28 +05:30
container_config.go Merge pull request #13583 from rhatdan/ipc 2022-04-16 12:30:01 -04:00
container_copy_linux.go enable unparam linter 2022-04-25 13:23:20 +02:00
container_exec.go enable gocritic linter 2022-04-26 18:12:22 +02:00
container_graph.go bump go module to version 4 2022-01-18 12:47:07 +01:00
container_graph_test.go bump go module to version 4 2022-01-18 12:47:07 +01:00
container_inspect.go enable staticcheck linter 2022-04-22 12:51:29 +02:00
container_internal.go Merge pull request #13973 from Luap99/linter-revive 2022-04-23 06:32:41 -04:00
container_internal_linux.go enable gocritic linter 2022-04-26 18:12:22 +02:00
container_internal_linux_test.go enable unparam linter 2022-04-25 13:23:20 +02:00
container_internal_test.go Refactor container config 2020-07-23 10:18:14 -04:00
container_linux.go go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00
container_log.go Add option for pod logs to display different colors per container. 2022-03-29 17:29:13 +02:00
container_log_linux.go Fix --tail log on restart problem 2022-04-13 14:07:15 -04:00
container_log_unsupported.go Add option for pod logs to display different colors per container. 2022-03-29 17:29:13 +02:00
container_path_resolution.go document that using libpod package directly is not supported 2022-03-23 19:05:29 +01:00
container_stat_linux.go enable gocritic linter 2022-04-26 18:12:22 +02:00
container_top_linux.go go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00
container_validate.go bump go module to version 4 2022-01-18 12:47:07 +01:00
diff.go bump go module to version 4 2022-01-18 12:47:07 +01:00
doc.go document that using libpod package directly is not supported 2022-03-23 19:05:29 +01:00
events.go vendor c/common 2022-04-21 13:43:58 +02:00
healthcheck.go healthcheck, libpod: Read healthcheck event output from os pipe 2022-02-04 21:15:03 +05:30
healthcheck_linux.go enable staticcheck linter 2022-04-22 12:51:29 +02:00
info.go bump go module to version 4 2022-01-18 12:47:07 +01:00
kube.go enable gocritic linter 2022-04-26 18:12:22 +02:00
mounts_linux.go go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00
networking_linux.go enable gocritic linter 2022-04-26 18:12:22 +02:00
networking_linux_test.go enable unparam linter 2022-04-25 13:23:20 +02:00
networking_machine.go enable gocritic linter 2022-04-26 18:12:22 +02:00
networking_slirp4netns.go enable gocritic linter 2022-04-26 18:12:22 +02:00
oci.go bump go module to version 4 2022-01-18 12:47:07 +01:00
oci_attach_linux.go go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00
oci_conmon.go podman: add new cgroup mode split 2020-06-25 17:16:12 +02:00
oci_conmon_exec_linux.go enable gocritic linter 2022-04-26 18:12:22 +02:00
oci_conmon_linux.go enable gocritic linter 2022-04-26 18:12:22 +02:00
oci_missing.go bump go module to version 4 2022-01-18 12:47:07 +01:00
oci_util.go bump go module to version 4 2022-01-18 12:47:07 +01:00
options.go enable gocritic linter 2022-04-26 18:12:22 +02:00
pod.go podman stats: calc CPU percentage correctly 2022-03-22 17:43:49 +01:00
pod_api.go fix pod volume passing and alter infra inheritance 2022-03-29 11:10:46 -04:00
pod_internal.go bump go module to version 4 2022-01-18 12:47:07 +01:00
pod_status.go bump go module to version 4 2022-01-18 12:47:07 +01:00
pod_top_linux.go go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00
reset.go system prune: remove all networks 2022-02-03 13:14:07 +01:00
runtime.go enable gocritic linter 2022-04-26 18:12:22 +02:00
runtime_cstorage.go Remove the runtime lock 2022-02-22 11:05:26 -05:00
runtime_ctr.go enable unparam linter 2022-04-25 13:23:20 +02:00
runtime_img.go Remove the runtime lock 2022-02-22 11:05:26 -05:00
runtime_migrate.go enable unparam linter 2022-04-25 13:23:20 +02:00
runtime_pod.go Remove the runtime lock 2022-02-22 11:05:26 -05:00
runtime_pod_linux.go Merge pull request #13398 from giuseppe/fix-warning-pod-create-rm 2022-03-22 15:56:45 +01:00
runtime_renumber.go bump go module to version 4 2022-01-18 12:47:07 +01:00
runtime_volume.go Remove the runtime lock 2022-02-22 11:05:26 -05:00
runtime_volume_linux.go enable unparam linter 2022-04-25 13:23:20 +02:00
state.go use libnetwork from c/common 2022-01-12 17:07:30 +01:00
state_test.go bump go module to version 4 2022-01-18 12:47:07 +01:00
stats.go podman stats: improve cpu average calc 2022-03-22 17:44:58 +01:00
storage.go bump go module to version 4 2022-01-18 12:47:07 +01:00
util.go Show version of the deb package in info output 2022-02-24 20:24:31 +01:00
util_linux.go go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00
util_linux_test.go Fix mismatch between log messages and behavior of libpod.LabelVolumePath. 2020-09-13 23:24:15 -04:00
util_test.go bump go module to version 4 2022-01-18 12:47:07 +01:00
volume.go Switch all calls to filepath.Walk to filepath.WalkDir 2022-03-27 07:18:25 -04:00
volume_inspect.go bump go module to version 4 2022-01-18 12:47:07 +01:00
volume_internal.go bump go module to version 4 2022-01-18 12:47:07 +01:00
volume_internal_linux.go Add podman volume mount support 2022-02-28 14:26:22 -05:00