podman/cmd/podman
Matt Heon 458ba5a8af Fix `podman stop` and `podman run --rmi`
This started off as an attempt to make `podman stop` on a
container started with `--rm` actually remove the container,
instead of just cleaning it up and waiting for the cleanup
process to finish the removal.

In the process, I realized that `podman run --rmi` was rather
broken. It was only done as part of the Podman CLI, not the
cleanup process (meaning it only worked with attached containers)
and the way it was wired meant that I was fairly confident that
it wouldn't work if I did a `podman stop` on an attached
container run with `--rmi`. I rewired it to use the same
mechanism that `podman run --rm` uses, so it should be a lot more
durable now, and I also wired it into `podman inspect` so you can
tell that a container will remove its image.

Tests have been added for the changes to `podman run --rmi`. No
tests for `stop` on a `run --rm` container as that would be racy.

Fixes #22852
Fixes RHEL-39513

Signed-off-by: Matt Heon <mheon@redhat.com>
2024-08-20 09:51:18 -04:00
..
common Add --compat-volumes option to build and farm build 2024-07-30 18:26:13 -04:00
completion Bump Go module to v5 2024-02-08 09:35:39 -05:00
containers Fix `podman stop` and `podman run --rmi` 2024-08-20 09:51:18 -04:00
diff added check for `registry.IsRemote()`. and correct error message. 2024-06-23 15:45:41 +00:00
farm Replace golang.org/x/exp/slices with slices from std 2024-04-23 11:16:40 +02:00
generate Bump Go module to v5 2024-02-08 09:35:39 -05:00
healthcheck Bump Go module to v5 2024-02-08 09:35:39 -05:00
images Remove duplicate call 2024-05-08 23:02:58 +08:00
inspect Bump Go module to v5 2024-02-08 09:35:39 -05:00
kube podman run use pod userns even with --pod-id-file 2024-06-24 17:18:08 +02:00
machine Merge pull request #23145 from afbjorklund/remove-machine-volume-driver 2024-07-15 20:36:19 +00:00
manifest Should not force conversion of manifest type to DockerV2ListMediaType 2024-08-07 06:07:46 -04:00
networks add `list` as an alias to list networks 2024-04-17 17:10:22 +02:00
parse Replace strings.SplitN with strings.Cut 2024-01-11 13:50:15 +00:00
pods working name of pod on start and stop 2024-05-25 19:40:21 -04:00
registry cmd: use fileutils.(Le|E)xists 2024-04-19 09:52:14 +02:00
secrets Bump Go module to v5 2024-02-08 09:35:39 -05:00
system remove trailing comma in example 2024-08-15 11:21:27 -04:00
utils Bump Go module to v5 2024-02-08 09:35:39 -05:00
validate Bump Go module to v5 2024-02-08 09:35:39 -05:00
volumes Bump Go module to v5 2024-02-08 09:35:39 -05:00
README.md cli: add docs for StringArray vs StringSlice options 2023-12-08 12:16:52 +01:00
auto-update.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
client.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
client_supported.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
client_unsupported.go Show client info even if remote connection fails 2023-10-13 08:53:56 -05:00
compose.go Disable compose-warning-logs if PODMAN_COMPOSE_WARNING_LOGS=false 2024-07-30 12:06:11 +00:00
compose_machine.go podman compose: enable machine socket connection 2024-03-07 17:34:05 +01:00
compose_machine_unsupported.go podman compose: correctly accept --connection/--url 2024-02-27 13:40:41 +01:00
diff.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
early_init_darwin.go set RLIMIT_NOFILE soft limit to match the hard limit on mac 2023-11-10 15:35:57 -06:00
early_init_linux.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
early_init_unsupported.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
inspect.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
login.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
logout.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
main.go Add configuration for podmansh 2024-05-23 11:29:37 +02:00
root.go cmd: call shutdown handler stop function 2024-07-14 20:06:46 +02:00
root_test.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
shell_completion_test.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
syslog_common.go Bump Go module to v5 2024-02-08 09:35:39 -05:00
syslog_unsupported.go Bump Go module to v5 2024-02-08 09:35:39 -05:00

README.md

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/podman/cmd/podman/manifest

Create the file $GOPATH/src/github.com/containers/podman/cmd/podman/manifest/manifest.go

package manifest

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/cmd/podman/validate"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/podman/cmd/podman/main.go to add:

package main

import	_ "github.com/containers/podman/cmd/podman/manifest"

Adding a new sub command podman manifest list

Create the file $GOPATH/src/github.com/containers/podman/cmd/podman/manifest/inspect.go

package manifest

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())
    

Adding CLI flags

When adding adding a new cli option that accepts a string array, there are two options to choose from: StringSlice() and StringArray(). They differ slightly in their behavior: StringSlice() allows the values to be comma separated so --opt v1,v2 --opt v3 results in []string{"v1", "v2", "v3"}, while StringArray() would result in []string{"v1,v2", "v3"}. Thus it is impossible to use values with comma in StringSlice(), which makes it unsuitable for flags that accept arbitrary values such as file paths as example. Also, because StringSlice() uses the csv lib to parse the values, it has special escaping rules for things like quotes, see https://github.com/containers/podman/issues/20064 for an example of how complicated things can get because of this. Thus use StringSlice() only when the option accepts predefined values that do not contain special characters, for example --cap-add and --cap-drop are a good example for this. Using --cap-add NET_ADMIN,NET_RAW is equal to --cap-add NET_ADMIN --cap-add NET_RAW so it is better suited to save some typing for users. When in doubt always choose StringArray() over StringSlice().