podman/test/system
Matt Heon 3d344ffd26 In SQLite state, use defaults for empty-string checks
As part of our database init, we perform a check of the current
values for a few fields (graph driver, graph root, static dir,
and a few more) to validate that Libpod is being started with a
sane & sensible config, and the user's containers can actually be
expected to work. Basically, we take the current runtime config
and compare against values cached in the database from the first
time Podman was run.

We've had some issues with this logic before this year around
symlink resolution, but this is a new edge case. Somehow, the
database is being loaded with the empty string for some fields
(at least graph driver) which is causing comparisons to fail
because we will never compare against "" for those fields - we
insert the default value instead, assuming we have one.

Having a value of "" in the database largely invalidates the
check so arguably we could just drop it, but what BoltDB did -
and what SQLite does after this patch - is to use the default
value for comparison instead of "". This should still catch some
edge cases, and shouldn't be too harmful.

What this does not do is identify or solve the reason that we are
seeing the empty string in the database at all. From my read on
the logic, it must mean that the graph driver is explicitly set
to "" in the c/storage config at the time Podman is first run and
I'm not precisely sure how that happens.

Fixes #24738

Signed-off-by: Matt Heon <mheon@redhat.com>
2025-02-11 11:01:00 -05:00
..
000-TEMPLATE CI: system tests: minor documentation on parallel 2024-09-18 11:32:36 -06:00
001-basic.bats
005-info.bats In SQLite state, use defaults for empty-string checks 2025-02-11 11:01:00 -05:00
010-images.bats Fix image ID query 2025-01-23 00:11:24 +01:00
011-image.bats
012-manifest.bats Add podman manifest rm --ignore 2025-01-22 11:43:47 -05:00
015-help.bats CI: system tests: parallelize low-hanging fruit 2024-09-03 14:22:01 -06:00
020-tag.bats CI: make 020-tag parallel-safe 2024-09-09 13:37:57 -06:00
030-run.bats Add --no-hostname option 2025-01-15 06:51:32 -05:00
032-sig-proxy.bats
035-logs.bats CI: parallelize logs test as much as possible 2024-09-23 13:46:00 -06:00
037-runlabel.bats
040-ps.bats
045-start.bats
050-stop.bats CI: systests: workaround for parallel podman-stop flake 2024-11-04 10:45:14 -07:00
055-rm.bats 055-rm test: clean up a test, and document 2024-10-07 15:22:49 -06:00
060-mount.bats AdditionalSupport for SubPath volume mounts 2024-11-06 10:10:26 -05:00
065-cp.bats CI: system tests: parallelize low-hanging fruit 2024-09-03 14:22:01 -06:00
070-build.bats CI: make 070-build.bats use safe image names 2024-10-28 06:58:26 -06:00
075-exec.bats CI: system tests: parallelize low-hanging fruit 2024-09-03 14:22:01 -06:00
080-pause.bats
085-top.bats
090-events.bats CI: fix changing-rootFsSize flake 2024-10-15 05:14:49 -06:00
110-history.bats CI: make 110-history parallel-safe 2024-09-03 14:41:46 -06:00
120-load.bats Revert "Use the config digest to compare images loaded/pulled using different methods" 2025-01-23 00:11:24 +01:00
125-import.bats CI: make 125-import parallel-safe 2024-09-03 14:44:27 -06:00
130-kill.bats CI: make 130-kill parallel-safe 2024-09-03 14:46:55 -06:00
140-diff.bats
150-login.bats Revert "Use the config digest to compare images loaded/pulled using different methods" 2025-01-23 00:11:24 +01:00
155-partial-pull.bats Clarify the reason for skip_if_remote 2024-11-27 21:26:11 +01:00
160-volumes.bats CI: --image-volume test: robustify 2024-11-19 10:03:55 -07:00
170-run-userns.bats libpod: hasCurrentUserMapped checks for gid too 2024-10-04 16:17:04 +02:00
180-blkio.bats
190-run-ipcns.bats
195-run-namespaces.bats
200-pod.bats CI: make 200-pod parallel-safe 2024-09-18 06:25:18 -06:00
220-healthcheck.bats healthcheck: do not leak statup service 2024-10-25 13:47:59 +02:00
250-systemd.bats System tests: clean up unit file leaks 2024-10-28 04:45:04 -06:00
251-system-service.bats
252-quadlet.bats Quadlet - Use = sign when setting the pull arg for build 2024-11-22 15:06:50 -05:00
255-auto-update.bats
260-sdnotify.bats System tests: sdnotify: wait for socket file creation 2024-10-01 14:50:16 -06:00
270-socket-activation.bats
271-tcp-cors-server.bats CORS system test: clean up 2024-09-25 07:46:07 -06:00
272-system-connection.bats
280-update.bats Fix overwriting of LinuxResources structure in the database 2024-12-04 13:16:32 +01:00
300-cli-parsing.bats
320-system-df.bats pasta udp tests: new bytecheck helper 2024-10-16 10:15:19 -06:00
330-corrupt-images.bats Fix 330-corrupt-images.bats in composefs test runs 2024-10-18 23:44:04 +02:00
331-system-check.bats
400-unprivileged-access.bats
410-selinux.bats system-tests: switch ls with getfattr for selinux tests 2025-01-27 18:40:43 +05:30
420-cgroups.bats stats: ignore errors from containers without cgroups 2024-11-28 15:19:04 +01:00
450-interactive.bats CI: parallelize 450-interactive system tests 2024-10-28 07:03:29 -06:00
500-networking.bats test/system: add podman network reload test to distro gating 2024-10-28 11:51:43 +01:00
505-networking-pasta.bats test/system: Fix spurious "duplicate tests" failures in pasta tests 2024-10-23 14:02:53 +11:00
520-checkpoint.bats CI: parallelize 520-checkpoint tests 2024-10-28 07:02:51 -06:00
550-pause-process.bats System tests: set a default XDG_RUNTIME_DIR 2024-09-25 12:45:17 -06:00
600-completion.bats shell completion: respect CONTAINERS_REGISTRIES_CONF 2024-12-17 16:29:40 +01:00
610-format.bats CI: format test: use local registry if available 2024-09-23 07:48:35 -06:00
620-option-conflicts.bats CI: system tests: parallelize low-hanging fruit 2024-09-03 14:22:01 -06:00
700-play.bats test/system: fix "podman play --build private registry" error 2024-12-17 17:20:28 +01:00
710-kube.bats Kube volumes can not container _ 2024-12-18 09:07:57 -05:00
750-trust.bats
760-system-renumber.bats
800-config.bats Avoid printing PR text to stdout in system test 2024-11-07 17:48:27 +01:00
850-compose.bats
900-ssh.bats
950-preexec-hooks.bats
999-final.bats
README.md Update system test template and README 2024-09-17 11:19:37 -06:00
build-systemd-image
build-testimage pasta udp tests: new bytecheck helper 2024-10-16 10:15:19 -06:00
helpers.bash Revert "Use the config digest to compare images loaded/pulled using different methods" 2025-01-23 00:11:24 +01:00
helpers.network.bash
helpers.registry.bash CI: system test registry: use --net=host 2024-09-19 05:17:15 -06:00
helpers.sig-proxy.bash
helpers.systemd.bash Quadlet - Use = sign when setting the pull arg for build 2024-11-22 15:06:50 -05:00
helpers.t
setup_suite.bash test/system: netns leak check for rootless as well 2024-09-18 12:07:11 +02:00

README.md

Quick overview of podman system tests. The idea is to use BATS, but with a framework for making it easy to add new tests and to debug failures.

Quick Start

Look at 000-TEMPLATE for a simple starting point. This introduces the basic set of helper functions:

  • setup (implicit) - establishes a test environment.

  • parse_table - you can define tables of inputs and expected results, then read those in a while loop. This makes it easy to add new tests. Because bash is not a programming language, the caller of parse_table sometimes needs to massage the returned values; 030-run.bats offers examples of how to deal with the more typical such issues.

  • run_podman - runs command defined in $PODMAN (default: 'podman' but could also be './bin/podman' or 'podman-remote'), with a timeout. Checks its exit status.

  • assert - compare actual vs expected output. Emits a useful diagnostic on failure.

  • die - output a properly-formatted message to stderr, and fail test

  • skip_if_rootless - if rootless, skip this test with a helpful message.

  • skip_if_remote - like the above, but skip if testing podman-remote

  • safename - generates a pseudorandom lower-case string suitable for use in names for containers, images, volumes, any object. String includes the BATS test number, making it possible to identify the source of leaks (failure to clean up) at the end of tests.

  • random_string - returns a pseudorandom alphanumeric string suitable for verifying I/O.

Test files are of the form NNN-name.bats where NNN is a three-digit number. Please preserve this convention, it simplifies viewing the directory and understanding test order. In particular, 00x tests should be reserved for a first-pass fail-fast subset of tests:

bats test/system/00*.bats || exit 1
bats test/system

...the goal being to provide quick feedback on catastrophic failures without having to wait for the entire test suite.

Running tests

To run the tests locally in your sandbox using hack/bats is recommend, check hack/bats --help for info about usage.

To run the entire suite use make localsystem or make remotesystem for podman-remote testing.

Analyzing test failures

The top priority for this scheme is to make it easy to diagnose what went wrong. To that end, podman_run always logs all invoked commands, their output and exit codes. In a normal run you will never see this, but BATS will display it on failure. The goal here is to give you everything you need to diagnose without having to rerun tests.

The assert comparison function is designed to emit useful diagnostics, in particular, the actual and expected strings. Please do not use the horrible BATS standard of [ x = y ]; that's nearly useless for tracking down failures.

If the above are not enough to help you track down a failure:

Debugging tests

Some functions have dprint statements. To see the output of these, set PODMAN_TEST_DEBUG="funcname" where funcname is the name of the function or perhaps just a substring.

Requirements

  • bats
  • jq
  • skopeo
  • nmap-ncat
  • httpd-tools
  • openssl
  • socat
  • buildah
  • gnupg

Further Details

TBD. For now, look in helpers.bash; each helper function has (what are intended to be) helpful header comments. For even more examples, see and/or run helpers.t; that's a regression test and provides a thorough set of examples of how the helpers work.