podman/cmd/podman
Paul Holzinger b5d1d89a37 Add shell completion with cobra
Allow automatic generation for shell completion scripts
with the internal cobra functions (requires v1.0.0+).

This should replace the handwritten completion scripts
and even adds support for fish. With this approach it is
less likley that completions and code are out of sync.

We can now create the scripts with
- podman completion bash
- podman completion zsh
- podman completion fish

To test the completion run:
source <(podman completion bash)

The same works for podman-remote and podman --remote and
it will complete your remote containers/images with
the correct endpoints values from --url/--connection.

The completion logic is written in go and provided by the
cobra library. The completion functions lives in
`cmd/podman/completion/completion.go`.

The unit test at cmd/podman/shell_completion_test.go checks
if each command and flag has an autocompletion function set.
This prevents that commands and flags have no shell completion set.

This commit does not replace the current autocompletion scripts.

Closes #6440

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2020-11-12 11:38:31 +01:00
..
common Add shell completion with cobra 2020-11-12 11:38:31 +01:00
completion Add shell completion with cobra 2020-11-12 11:38:31 +01:00
containers Add shell completion with cobra 2020-11-12 11:38:31 +01:00
generate Add shell completion with cobra 2020-11-12 11:38:31 +01:00
healthcheck Add shell completion with cobra 2020-11-12 11:38:31 +01:00
images Add shell completion with cobra 2020-11-12 11:38:31 +01:00
inspect Add shell completion with cobra 2020-11-12 11:38:31 +01:00
manifest Add shell completion with cobra 2020-11-12 11:38:31 +01:00
networks Add shell completion with cobra 2020-11-12 11:38:31 +01:00
parse Restore --format table header support 2020-10-29 10:14:08 -07:00
play Add shell completion with cobra 2020-11-12 11:38:31 +01:00
pods Add shell completion with cobra 2020-11-12 11:38:31 +01:00
registry Add shell completion with cobra 2020-11-12 11:38:31 +01:00
system Add shell completion with cobra 2020-11-12 11:38:31 +01:00
utils Add support for external container 2020-10-15 09:51:31 -04:00
validate Usability: prevent "-l" with arguments 2020-09-14 15:49:28 -06:00
volumes Add shell completion with cobra 2020-11-12 11:38:31 +01:00
README.md Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
auto-update.go Add shell completion with cobra 2020-11-12 11:38:31 +01:00
diff.go Add shell completion with cobra 2020-11-12 11:38:31 +01:00
early_init_linux.go Add support for --connection 2020-08-19 08:37:44 -07:00
early_init_unsupported.go abi: set default umask and rlimits 2020-07-17 20:53:38 +02:00
inspect.go Add shell completion with cobra 2020-11-12 11:38:31 +01:00
login.go Add shell completion with cobra 2020-11-12 11:38:31 +01:00
logout.go Add shell completion with cobra 2020-11-12 11:38:31 +01:00
main.go Add shell completion with cobra 2020-11-12 11:38:31 +01:00
root.go Add shell completion with cobra 2020-11-12 11:38:31 +01:00
root_test.go Fix the "err: cause" order of OCI runtime errors 2020-10-09 10:36:21 -05:00
shell_completion_test.go Add shell completion with cobra 2020-11-12 11:38:31 +01:00
syslog_linux.go Fix build on OS X 2020-05-20 18:24:56 -04:00
syslog_unsupported.go Fix build on OS X 2020-05-20 18:24:56 -04:00

README.md

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/manifest.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/cmd/podman/validate"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/main.go to add:

package main

import	_ "github.com/containers/podman/cmd/podman/manifests"

Adding a new sub command podman manifests list

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/inspect.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest inspect_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())