podman/cmd/podman
Paul Holzinger 7f8e99ded4
podman version: use report.Formatter over Template
Currently the podman command --format output code uses a mix of
report.Formatter and report.Template.

I patched report.Formatter to correctly handle newlines[1]. Since we
cannot fix this with report.Template we have to migrate all users to
report.Formatter. This ensures consistent behavior for all commands.

This change does not change the output.

[1] https://github.com/containers/common/pull/1146

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2022-09-13 10:33:15 +02:00
..
common health check: add on-failure actions 2022-09-09 13:02:05 +02:00
completion enable gocritic linter 2022-04-26 18:12:22 +02:00
containers Fix stutters 2022-09-10 07:52:00 -04:00
diff cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
generate Fix stutters 2022-09-10 07:52:00 -04:00
healthcheck bump go module to version 4 2022-01-18 12:47:07 +01:00
images Fix stutters 2022-09-10 07:52:00 -04:00
inspect podman inspect return exit code > 0 on print error 2022-09-13 10:33:14 +02:00
kube podman kube play/down --read from URL 2022-08-23 12:55:53 +01:00
machine podman machine info: use report.Formatter over Template 2022-09-13 10:33:14 +02:00
manifest Pass io.Writer when pushing images/manifests from command line 2022-08-18 23:48:43 +03:00
networks podman network ls: use report.Formatter over Template 2022-09-13 10:33:13 +02:00
parse Allow colons in windows file paths 2022-08-24 10:31:42 -05:00
pods Fix stutters 2022-09-10 07:52:00 -04:00
registry cmd/podman: Enable ABI and Tunnel mode for freebsd 2022-08-22 10:14:12 +01:00
secrets podman secret inspect: use report.Formatter over Template 2022-09-13 10:33:13 +02:00
system podman version: use report.Formatter over Template 2022-09-13 10:33:15 +02:00
utils Refactored networkPrune function 2022-07-08 08:33:20 +09:00
validate Podman stop --filter flag 2022-07-14 13:18:53 -04:00
volumes podman volume ls: use report.Formatter over Template 2022-09-13 10:33:13 +02:00
README.md [Techinal Debt] Cleanup ABI vs. Tunnel CLI commands 2021-05-27 11:40:43 -07:00
auto-update.go podman auto-update: use report.Formatter over Template 2022-09-13 10:33:12 +02:00
diff.go Remove unused archive flag from diff commands 2022-05-25 08:50:12 -07:00
early_init_linux.go Fix stutters 2022-09-10 07:52:00 -04:00
early_init_unsupported.go go fmt: use go 1.18 conditional-build syntax 2022-03-18 09:11:53 +01:00
inspect.go bump go module to version 4 2022-01-18 12:47:07 +01:00
login.go bump go module to version 4 2022-01-18 12:47:07 +01:00
logout.go bump go module to version 4 2022-01-18 12:47:07 +01:00
main.go Add "podman kube play" cmd 2022-07-13 15:27:03 +01:00
root.go Add --config for Docker compatibility 2022-09-08 16:20:30 -04:00
root_test.go cmd/podman: switch to golang native error wrapping 2022-06-30 12:58:57 +02:00
shell_completion_test.go bump go module to version 4 2022-01-18 12:47:07 +01:00
syslog_common.go cmd/podman: Enable --syslog on FreeBSD 2022-08-26 08:01:02 +01:00
syslog_unsupported.go cmd/podman: Enable --syslog on FreeBSD 2022-08-26 08:01:02 +01:00

README.md

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/manifest.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/cmd/podman/validate"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/main.go to add:

package main

import	_ "github.com/containers/podman/cmd/podman/manifests"

Adding a new sub command podman manifests list

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/inspect.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())