mirror of https://github.com/containers/podman.git
4b784b377c
This was inspired by https://github.com/cri-o/cri-o/pull/3934 and much of the logic for it is contained there. However, in brief, a named return called "err" can cause lots of code confusion and encourages using the wrong err variable in defer statements, which can make them work incorrectly. Using a separate name which is not used elsewhere makes it very clear what the defer should be doing. As part of this, remove a large number of named returns that were not used anywhere. Most of them were once needed, but are no longer necessary after previous refactors (but were accidentally retained). Signed-off-by: Matthew Heon <matthew.heon@pm.me> |
||
|---|---|---|
| .. | ||
| config.go | ||
| events.go | ||
| events_linux.go | ||
| events_unsupported.go | ||
| filters.go | ||
| journal_linux.go | ||
| journal_unsupported.go | ||
| logfile.go | ||
| nullout.go | ||