podman/libpod
Daniel J Walsh bc0e12a047
Fix problem copying files when container is in host pid namespace
When attempting to copy files into and out of running containers
within the host pidnamespace, the code was attempting to join the
host pidns again, and getting an error. This was causing the podman
cp command to fail. Since we are already in the host pid namespace,
we should not be attempting to join.  This PR adds a check to see if
the container is in NOT host pid namespace, and only then attempts to
join.

Fixes: https://github.com/containers/podman/issues/9985

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-05-19 07:55:48 -04:00
..
common Set blob cache directory based on GraphDriver 2019-03-29 08:27:33 -04:00
define Merge pull request #10366 from ashley-cui/secretoptions 2021-05-17 16:24:20 -04:00
driver bump go module to v3 2021-02-22 09:03:51 +01:00
events [NO TESTS NEEDED] Shrink the size of podman-remote 2021-03-29 09:49:45 -04:00
layers Initial checkin from CRI-O repo 2017-11-01 11:24:59 -04:00
linkmode Add podman static build 2020-05-11 13:11:07 +02:00
lock bump go module to v3 2021-02-22 09:03:51 +01:00
logs podman image tree: restore previous behavior 2021-05-12 17:56:59 +02:00
network Detect if in podman machine virtual vm 2021-04-30 13:11:05 -05:00
plugin bump go module to v3 2021-02-22 09:03:51 +01:00
shutdown Fixes from make codespell 2021-04-21 13:16:33 -04:00
boltdb_state.go Removing a non existing container API should return 404 2021-03-10 04:08:29 -05:00
boltdb_state_internal.go Add --requires flag to podman run/create 2021-04-06 14:01:31 -04:00
boltdb_state_linux.go bump go module to v3 2021-02-22 09:03:51 +01:00
boltdb_state_unsupported.go podman-remote inspect 2019-01-18 15:43:11 -06:00
common_test.go bump go module to v3 2021-02-22 09:03:51 +01:00
container.go Merge pull request #10366 from ashley-cui/secretoptions 2021-05-17 16:24:20 -04:00
container_api.go turn hidden --trace into a NOP 2021-03-08 09:22:42 +01:00
container_commit.go migrate Podman to containers/common/libimage 2021-05-05 11:30:12 +02:00
container_config.go Support uid,gid,mode options for secrets 2021-05-17 14:35:55 -04:00
container_copy_linux.go Fix problem copying files when container is in host pid namespace 2021-05-19 07:55:48 -04:00
container_copy_unsupported.go podman cp: support copying on tmpfs mounts 2021-03-04 15:43:12 +01:00
container_exec.go oci: drop ExecContainerCleanup 2021-04-16 17:45:52 -04:00
container_graph.go bump go module to v3 2021-02-22 09:03:51 +01:00
container_graph_test.go bump go module to v3 2021-02-22 09:03:51 +01:00
container_inspect.go Fix problem copying files when container is in host pid namespace 2021-05-19 07:55:48 -04:00
container_internal.go Merge pull request #10366 from ashley-cui/secretoptions 2021-05-17 16:24:20 -04:00
container_internal_linux.go Merge pull request #10334 from mheon/add_relabel_vol_plugin 2021-05-17 16:28:21 -04:00
container_internal_linux_test.go Make an entry in /etc/group when we modify /etc/passwd 2020-09-10 13:02:31 -04:00
container_internal_test.go Refactor container config 2020-07-23 10:18:14 -04:00
container_internal_unsupported.go bump go module to v3 2021-02-22 09:03:51 +01:00
container_linux.go Do not fetch pod and ctr State on retrieval in Bolt 2018-07-31 14:19:50 +00:00
container_log.go Tidy duplicate log tests 2021-03-02 14:28:16 -05:00
container_log_linux.go podman image tree: restore previous behavior 2021-05-12 17:56:59 +02:00
container_log_unsupported.go bump go module to v3 2021-02-22 09:03:51 +01:00
container_path_resolution.go Fix infinite loop in isPathOnVolume 2021-05-06 19:24:14 +03:00
container_stat_linux.go podman cp: evaluate symlink correctly when copying from container 2021-03-09 10:45:15 +01:00
container_stat_unsupported.go podman cp: support copying on tmpfs mounts 2021-03-04 15:43:12 +01:00
container_top_linux.go bump go module to v3 2021-02-22 09:03:51 +01:00
container_top_unsupported.go bump go module to v3 2021-02-22 09:03:51 +01:00
container_unsupported.go Do not fetch pod and ctr State on retrieval in Bolt 2018-07-31 14:19:50 +00:00
container_validate.go Ensure that `--userns=keep-id` sets user in config 2021-04-06 09:18:46 -04:00
diff.go Create the /etc/mtab file if does not exists 2021-05-15 03:56:38 -04:00
events.go bump go module to v3 2021-02-22 09:03:51 +01:00
healthcheck.go bump go module to v3 2021-02-22 09:03:51 +01:00
healthcheck_linux.go bump go module to v3 2021-02-22 09:03:51 +01:00
healthcheck_unsupported.go bump go module to v3 2021-02-22 09:03:51 +01:00
info.go Use seccomp_profile as default profile if defined in containers.conf 2021-04-28 15:19:48 +02:00
kube.go Adds support to preserve auto update labels in generate and play kube 2021-05-06 21:21:43 -06:00
mounts_linux.go set root propagation based on volume properties 2018-11-26 13:55:02 +01:00
networking_linux.go Merge pull request #9972 from bblenard/issue-5651-hostname-for-container-gateway 2021-05-17 10:45:23 -04:00
networking_slirp4netns.go Add host.containers.internal entry into container's etc/hosts 2021-05-17 08:21:22 -05:00
networking_unsupported.go bump go module to v3 2021-02-22 09:03:51 +01:00
oci.go oci: drop ExecContainerCleanup 2021-04-16 17:45:52 -04:00
oci_attach_linux.go prune remotecommand dependency 2021-02-25 10:02:41 -06:00
oci_attach_unsupported.go prune remotecommand dependency 2021-02-25 10:02:41 -06:00
oci_conmon.go podman: add new cgroup mode split 2020-06-25 17:16:12 +02:00
oci_conmon_exec_linux.go oci: drop ExecContainerCleanup 2021-04-16 17:45:52 -04:00
oci_conmon_linux.go fix container startup for empty pidfile 2021-05-10 10:59:04 +02:00
oci_conmon_unsupported.go bump go module to v3 2021-02-22 09:03:51 +01:00
oci_missing.go oci: drop ExecContainerCleanup 2021-04-16 17:45:52 -04:00
oci_util.go bump go module to v3 2021-02-22 09:03:51 +01:00
options.go Support uid,gid,mode options for secrets 2021-05-17 14:35:55 -04:00
pod.go bump go module to v3 2021-02-22 09:03:51 +01:00
pod_api.go bump go module to v3 2021-02-22 09:03:51 +01:00
pod_internal.go cgroup: fix rootless --cgroup-parent with pods 2021-05-06 08:33:28 +02:00
pod_status.go bump go module to v3 2021-02-22 09:03:51 +01:00
pod_top_linux.go bump go module to v3 2021-02-22 09:03:51 +01:00
pod_top_unsupported.go bump go module to v3 2021-02-22 09:03:51 +01:00
reset.go migrate Podman to containers/common/libimage 2021-05-05 11:30:12 +02:00
runtime.go Support uid,gid,mode options for secrets 2021-05-17 14:35:55 -04:00
runtime_cstorage.go bump go module to v3 2021-02-22 09:03:51 +01:00
runtime_ctr.go Support uid,gid,mode options for secrets 2021-05-17 14:35:55 -04:00
runtime_img.go migrate Podman to containers/common/libimage 2021-05-05 11:30:12 +02:00
runtime_img_test.go Document CONTAINERS_CONF/CONTAINERS_STORAGE_CONF Env variables 2021-03-10 06:34:47 -05:00
runtime_migrate.go bump go module to v3 2021-02-22 09:03:51 +01:00
runtime_migrate_unsupported.go Use Libpod tmpdir for pause path 2020-12-02 14:18:37 -05:00
runtime_pod.go bump go module to v3 2021-02-22 09:03:51 +01:00
runtime_pod_infra_linux.go migrate Podman to containers/common/libimage 2021-05-05 11:30:12 +02:00
runtime_pod_linux.go cgroup: fix rootless --cgroup-parent with pods 2021-05-06 08:33:28 +02:00
runtime_pod_unsupported.go bump go module to v3 2021-02-22 09:03:51 +01:00
runtime_renumber.go bump go module to v3 2021-02-22 09:03:51 +01:00
runtime_volume.go bump go module to v3 2021-02-22 09:03:51 +01:00
runtime_volume_linux.go bump go module to v3 2021-02-22 09:03:51 +01:00
runtime_volume_unsupported.go bump go module to v3 2021-02-22 09:03:51 +01:00
state.go Rewrite Rename backend in a more atomic fashion 2021-03-02 13:30:28 -05:00
state_test.go Remove in-memory state implementation 2021-04-13 14:00:38 -04:00
stats.go bump go module to v3 2021-02-22 09:03:51 +01:00
stats_unsupported.go bump go module to v3 2021-02-22 09:03:51 +01:00
storage.go turn hidden --trace into a NOP 2021-03-08 09:22:42 +01:00
util.go Use seccomp_profile as default profile if defined in containers.conf 2021-04-28 15:19:48 +02:00
util_linux.go bump go module to v3 2021-02-22 09:03:51 +01:00
util_linux_test.go Fix mismatch between log messages and behavior of libpod.LabelVolumePath. 2020-09-13 23:24:15 -04:00
util_test.go bump go module to v3 2021-02-22 09:03:51 +01:00
util_unsupported.go bump go module to v3 2021-02-22 09:03:51 +01:00
volume.go bump go module to v3 2021-02-22 09:03:51 +01:00
volume_inspect.go bump go module to v3 2021-02-22 09:03:51 +01:00
volume_internal.go Ensure manually-created volumes have correct ownership 2021-03-24 14:24:47 -04:00
volume_internal_linux.go [NO TESTS NEEDED] Fix rootless volume plugins 2021-03-24 22:53:53 +03:00
volume_internal_unsupported.go bump go module to v3 2021-02-22 09:03:51 +01:00