Fix errcheck: error return value of `d.Cleanup` is not checked

Signed-off-by: Jan Rodák <hony.com@seznam.cz>
This commit is contained in:
Jan Rodák 2024-07-04 08:29:59 +02:00
parent d1ae3288d6
commit 11aac2360b
No known key found for this signature in database
GPG Key ID: E82E2FA0E160318E
1 changed files with 35 additions and 7 deletions

View File

@ -221,7 +221,11 @@ func TestMountedFalseResponse(t *testing.T) {
func TestMountedTrueResponse(t *testing.T) { func TestMountedTrueResponse(t *testing.T) {
d := newDriver(t) d := newDriver(t)
defer os.RemoveAll(tmp) defer os.RemoveAll(tmp)
defer d.Cleanup() defer func() {
if err := d.Cleanup(); err != nil {
t.Fatal(err)
}
}()
err := d.Create("1", "", nil) err := d.Create("1", "", nil)
require.NoError(t, err) require.NoError(t, err)
@ -488,7 +492,11 @@ func TestDiffSize(t *testing.T) {
func TestChildDiffSize(t *testing.T) { func TestChildDiffSize(t *testing.T) {
d := newDriver(t) d := newDriver(t)
defer os.RemoveAll(tmp) defer os.RemoveAll(tmp)
defer d.Cleanup() defer func() {
if err := d.Cleanup(); err != nil {
t.Fatal(err)
}
}()
if err := d.CreateReadWrite("1", "", nil); err != nil { if err := d.CreateReadWrite("1", "", nil); err != nil {
t.Fatal(err) t.Fatal(err)
@ -543,7 +551,11 @@ func TestChildDiffSize(t *testing.T) {
func TestExists(t *testing.T) { func TestExists(t *testing.T) {
d := newDriver(t) d := newDriver(t)
defer os.RemoveAll(tmp) defer os.RemoveAll(tmp)
defer d.Cleanup() defer func() {
if err := d.Cleanup(); err != nil {
t.Fatal(err)
}
}()
if err := d.Create("1", "", nil); err != nil { if err := d.Create("1", "", nil); err != nil {
t.Fatal(err) t.Fatal(err)
@ -561,7 +573,11 @@ func TestExists(t *testing.T) {
func TestStatus(t *testing.T) { func TestStatus(t *testing.T) {
d := newDriver(t) d := newDriver(t)
defer os.RemoveAll(tmp) defer os.RemoveAll(tmp)
defer d.Cleanup() defer func() {
if err := d.Cleanup(); err != nil {
t.Fatal(err)
}
}()
if err := d.Create("1", "", nil); err != nil { if err := d.Create("1", "", nil); err != nil {
t.Fatal(err) t.Fatal(err)
@ -589,7 +605,11 @@ func TestStatus(t *testing.T) {
func TestApplyDiff(t *testing.T) { func TestApplyDiff(t *testing.T) {
d := newDriver(t) d := newDriver(t)
defer os.RemoveAll(tmp) defer os.RemoveAll(tmp)
defer d.Cleanup() defer func() {
if err := d.Cleanup(); err != nil {
t.Fatal(err)
}
}()
if err := d.CreateReadWrite("1", "", nil); err != nil { if err := d.CreateReadWrite("1", "", nil); err != nil {
t.Fatal(err) t.Fatal(err)
@ -652,7 +672,11 @@ func testMountMoreThan42Layers(t *testing.T, mountPath string) {
defer os.RemoveAll(mountPath) defer os.RemoveAll(mountPath)
d := testInit(mountPath, t).(*Driver) d := testInit(mountPath, t).(*Driver)
defer d.Cleanup() defer func() {
if err := d.Cleanup(); err != nil {
t.Fatal(err)
}
}()
var last string var last string
var expected int var expected int
@ -726,7 +750,11 @@ func BenchmarkConcurrentAccess(b *testing.B) {
d := newDriver(b) d := newDriver(b)
defer os.RemoveAll(tmp) defer os.RemoveAll(tmp)
defer d.Cleanup() defer func() {
if err := d.Cleanup(); err != nil {
b.Fatal(err)
}
}()
numConcurrent := 256 numConcurrent := 256
// create a bunch of ids // create a bunch of ids