Merge pull request #16895 from vdemeester/ocd-validate-typo
Fix few comments in validate scripts
This commit is contained in:
commit
a6bbf16aa1
|
|
@ -8,7 +8,6 @@ unset IFS
|
||||||
|
|
||||||
errors=()
|
errors=()
|
||||||
for f in "${files[@]}"; do
|
for f in "${files[@]}"; do
|
||||||
# we use "git show" here to validate that what's committed passes go vet
|
|
||||||
failedLint=$(golint "$f")
|
failedLint=$(golint "$f")
|
||||||
if [ "$failedLint" ]; then
|
if [ "$failedLint" ]; then
|
||||||
errors+=( "$failedLint" )
|
errors+=( "$failedLint" )
|
||||||
|
|
|
||||||
|
|
@ -15,7 +15,7 @@ for f in "${files[@]}"; do
|
||||||
continue
|
continue
|
||||||
fi
|
fi
|
||||||
|
|
||||||
# we use "git show" here to validate that what's committed is formatted
|
# we use "git show" here to validate that what's committed doesn't contain golang built-in testing
|
||||||
if git show "$VALIDATE_HEAD:$f" | grep -q testing.T; then
|
if git show "$VALIDATE_HEAD:$f" | grep -q testing.T; then
|
||||||
badFiles+=( "$f" )
|
badFiles+=( "$f" )
|
||||||
fi
|
fi
|
||||||
|
|
|
||||||
|
|
@ -8,7 +8,7 @@ unset IFS
|
||||||
|
|
||||||
badFiles=()
|
badFiles=()
|
||||||
for f in "${files[@]}"; do
|
for f in "${files[@]}"; do
|
||||||
# we use "git show" here to validate that what's committed is formatted
|
# we use "git show" here to validate that what's committed has valid toml syntax
|
||||||
if ! git show "$VALIDATE_HEAD:$f" | tomlv /proc/self/fd/0 ; then
|
if ! git show "$VALIDATE_HEAD:$f" | tomlv /proc/self/fd/0 ; then
|
||||||
badFiles+=( "$f" )
|
badFiles+=( "$f" )
|
||||||
fi
|
fi
|
||||||
|
|
|
||||||
|
|
@ -8,7 +8,6 @@ unset IFS
|
||||||
|
|
||||||
errors=()
|
errors=()
|
||||||
for f in "${files[@]}"; do
|
for f in "${files[@]}"; do
|
||||||
# we use "git show" here to validate that what's committed passes go vet
|
|
||||||
failedVet=$(go vet "$f")
|
failedVet=$(go vet "$f")
|
||||||
if [ "$failedVet" ]; then
|
if [ "$failedVet" ]; then
|
||||||
errors+=( "$failedVet" )
|
errors+=( "$failedVet" )
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue