From 02a831466e23df9b654acf469ef5e32d314a1b4e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20M=C3=ADchal?= Date: Mon, 25 Oct 2021 03:46:02 +0300 Subject: [PATCH] cmd/enter: Don't use double negation Double negation is hard to wrap your head around. https://github.com/containers/toolbox/pull/913 --- src/cmd/enter.go | 8 ++++---- src/cmd/run.go | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/cmd/enter.go b/src/cmd/enter.go index 903829b..06b8f3a 100644 --- a/src/cmd/enter.go +++ b/src/cmd/enter.go @@ -80,7 +80,7 @@ func enter(cmd *cobra.Command, args []string) error { var container string var containerArg string - var nonDefaultContainer bool + var defaultContainer bool = true if len(args) != 0 { container = args[0] @@ -91,7 +91,7 @@ func enter(cmd *cobra.Command, args []string) error { } if container != "" { - nonDefaultContainer = true + defaultContainer = false if !utils.IsContainerNameValid(container) { var builder strings.Builder @@ -106,7 +106,7 @@ func enter(cmd *cobra.Command, args []string) error { var release string if enterFlags.release != "" { - nonDefaultContainer = true + defaultContainer = false var err error release, err = utils.ParseRelease(enterFlags.distro, enterFlags.release) @@ -150,7 +150,7 @@ func enter(cmd *cobra.Command, args []string) error { } if err := runCommand(container, - !nonDefaultContainer, + defaultContainer, image, release, command, diff --git a/src/cmd/run.go b/src/cmd/run.go index 470a787..b7a9b06 100644 --- a/src/cmd/run.go +++ b/src/cmd/run.go @@ -86,10 +86,10 @@ func run(cmd *cobra.Command, args []string) error { return nil } - var nonDefaultContainer bool + var defaultContainer bool = true if runFlags.container != "" { - nonDefaultContainer = true + defaultContainer = false if !utils.IsContainerNameValid(runFlags.container) { var builder strings.Builder @@ -104,7 +104,7 @@ func run(cmd *cobra.Command, args []string) error { var release string if runFlags.release != "" { - nonDefaultContainer = true + defaultContainer = false var err error release, err = utils.ParseRelease(runFlags.distro, runFlags.release) @@ -136,7 +136,7 @@ func run(cmd *cobra.Command, args []string) error { } if err := runCommand(container, - !nonDefaultContainer, + defaultContainer, image, release, command,