From 80c02344dfa0a01005d728c69b9c4474f402dc26 Mon Sep 17 00:00:00 2001 From: Debarshi Ray Date: Mon, 24 Aug 2020 19:29:14 +0200 Subject: [PATCH] Silence SC2086 Otherwise https://www.shellcheck.net/ would complain: Line 729: if $podman_command image exists localhost/$base_toolbox_image >/dev/null 2>&3; then ^-----------------^ SC2086: Double quote to prevent globbing and word splitting. See: https://github.com/koalaman/shellcheck/wiki/SC2086 https://github.com/containers/toolbox/pull/537 --- toolbox | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/toolbox b/toolbox index 2093729..1722157 100755 --- a/toolbox +++ b/toolbox @@ -726,7 +726,7 @@ pull_base_toolbox_image() if ! $has_domain; then echo "$base_toolbox_command: looking for image localhost/$base_toolbox_image" >&3 - if $podman_command image exists localhost/$base_toolbox_image >/dev/null 2>&3; then + if $podman_command image exists "localhost/$base_toolbox_image" >/dev/null 2>&3; then return 0 fi fi @@ -975,7 +975,7 @@ create() echo "$base_toolbox_command: checking if container $toolbox_container already exists" >&3 enter_command=$(create_enter_command "$toolbox_container") - if $podman_command container exists $toolbox_container >/dev/null 2>&3; then + if $podman_command container exists "$toolbox_container" >/dev/null 2>&3; then echo "$base_toolbox_command: container $toolbox_container already exists" >&2 echo "Enter with: $enter_command" >&2 echo "Try '$base_toolbox_command --help' for more information." >&2