containers
/
toolbox
mirror of https://github.com/containers/toolbox.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

build: Enforce all the default 'go vet' checks on all Go sources 

Currently, only a so-called high-confidence subset of the default checks
in 'go vet' are being run by 'go test' [1].  Since 'go vet' is part of
the core Go tools, it's worth trying to use more of it.  After all,
golangci-lint, which is currently being run through a GitHub Action,
is running the default 'go vet' checks as one of its linters [2].

It's good to have as much of the testing wrapped inside 'meson test', as
possible, because it's easier to run locally and on other non-GitHub CI
environments like those of downstream distributors.

[1] https://pkg.go.dev/cmd/go/internal/test

[2] https://golangci-lint.run/usage/linters/
    https://golangci-lint.run/usage/linters/#govet

https://github.com/containers/toolbox/pull/1186
This commit is contained in:
Debarshi Ray 2022-12-02 10:15:44 +01:00
parent f0425d4240
commit f695012faf
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/meson.build
View File

@ -71,4 +71,5 @@ if shellcheck.found()
endif
test('go fmt', meson_go_fmt_program, args: [meson.current_source_dir()])
test('go test', go, args: ['test', '-v', './...'], workdir: meson.current_source_dir())
test('go vet', go, args: ['vet', '-c', '3', './...'], workdir: meson.current_source_dir())
test('go test', go, args: ['test', '-v', '-vet', 'off', './...'], workdir: meson.current_source_dir())