From 5da8d8ce1b9bd5d0d7e8f434b924f747727c293f Mon Sep 17 00:00:00 2001 From: Arthur Outhenin-Chalandre Date: Sun, 24 Nov 2024 17:59:58 +0100 Subject: [PATCH] dont panic on empty SRV segments Apply commit https://github.com/coredns/coredns/commit/4349b6fa63326681333c1adfa3ee32bfddf2d3c0 Signed-off-by: Arthur Outhenin-Chalandre --- parse.go | 3 +++ parse_test.go | 2 ++ 2 files changed, 5 insertions(+) diff --git a/parse.go b/parse.go index 7a8ae1a..94a1dc7 100644 --- a/parse.go +++ b/parse.go @@ -95,6 +95,9 @@ func parseRequest(name, zone string) (r recordRequest, err error) { // stripUnderscore removes a prefixed underscore from s. func stripUnderscore(s string) string { + if len(s) == 0 { + return s + } if s[0] != '_' { return s } diff --git a/parse_test.go b/parse_test.go index 9698d78..12e7651 100644 --- a/parse_test.go +++ b/parse_test.go @@ -23,6 +23,8 @@ func TestParseRequest(t *testing.T) { {"svc.inter.webs.tests.", "......"}, // bare pod type {"pod.inter.webs.tests.", "......"}, + // SRV request with empty segments + {"..webs.mynamespace.svc.inter.webs.tests.", "...webs.mynamespace.svc"}, } for i, tc := range tests { m := new(dns.Msg)