crossplane
/
crossplane-runtime
mirror of https://github.com/crossplane/crossplane-runtime.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add debug log for pending + deterministic name case 

Signed-off-by: nolancon <cmsnolan@gmail.com>
This commit is contained in:
nolancon 2025-06-09 08:33:12 +00:00
parent da72350d65
commit 6120cd37b6
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/reconciler/managed/reconciler.go
View File

@ -958,11 +958,14 @@ func (r *Reconciler) Reconcile(ctx context.Context, req reconcile.Request) (resu
// an updated external name which is non-deterministic, we have leaked a // an updated external name which is non-deterministic, we have leaked a
// resource. The safest thing to do is to refuse to proceed. However, if // resource. The safest thing to do is to refuse to proceed. However, if
// the resource has a deterministic external name, it is safe to proceed. // the resource has a deterministic external name, it is safe to proceed.
if meta.ExternalCreateIncomplete(managed) && !r.deterministicExternalName { if meta.ExternalCreateIncomplete(managed) {
log.Debug(errCreateIncomplete) if !r.deterministicExternalName {
record.Event(managed, event.Warning(reasonCannotInitialize, errors.New(errCreateIncomplete))) log.Debug(errCreateIncomplete)
status.MarkConditions(xpv1.Creating(), xpv1.ReconcileError(errors.New(errCreateIncomplete))) record.Event(managed, event.Warning(reasonCannotInitialize, errors.New(errCreateIncomplete)))
return reconcile.Result{Requeue: false}, errors.Wrap(r.client.Status().Update(ctx, managed), errUpdateManagedStatus) status.MarkConditions(xpv1.Creating(), xpv1.ReconcileError(errors.New(errCreateIncomplete)))
return reconcile.Result{Requeue: false}, errors.Wrap(r.client.Status().Update(ctx, managed), errUpdateManagedStatus)
}
log.Debug("Cannot determine creation result, but proceeding due to deterministic external name")
} }
// We resolve any references before observing our external resource because // We resolve any references before observing our external resource because