Use OpenAPI to set the default ProviderConfig

This allows us to avoid an extra update call to the API server when new managed
resources are created.

Signed-off-by: Nic Cope <negz@rk0n.org>

apis/common/v1/resource.go

@@ -139,6 +139,7 @@ type ResourceSpec struct {
 	// ProviderConfigReference specifies how the provider that will be used to
 	// create, observe, update, and delete this managed resource should be
 	// configured.
+	// +kubebuilder:default={"name": "default"}
 	ProviderConfigReference *Reference `json:"providerConfigRef,omitempty"`
 
 	// ProviderReference specifies the provider that will be used to create,

pkg/reconciler/managed/api.go

@@ -58,9 +58,11 @@ func (a *NameAsExternalName) Initialize(ctx context.Context, mg resource.Managed
 
 // DefaultProviderConfig fills the ProviderConfigRef with `default` if it's left
 // empty.
+// Deprecated: Use OpenAPI schema defaulting instead.
 type DefaultProviderConfig struct{ client client.Client }
 
 // NewDefaultProviderConfig returns a new DefaultProviderConfig.
+// Deprecated: Use OpenAPI schema defaulting instead.
 func NewDefaultProviderConfig(c client.Client) *DefaultProviderConfig {
 	return &DefaultProviderConfig{client: c}
 }

pkg/reconciler/managed/reconciler.go

@@ -367,11 +367,8 @@ func defaultMRManaged(m manager.Manager) mrManaged {
 	return mrManaged{
 		ConnectionPublisher: NewAPISecretPublisher(m.GetClient(), m.GetScheme()),
 		Finalizer:           resource.NewAPIFinalizer(m.GetClient(), managedFinalizerName),
-		Initializer: InitializerChain{
+		Initializer:         NewNameAsExternalName(m.GetClient()),
-			NewDefaultProviderConfig(m.GetClient()),
+		ReferenceResolver:   NewAPISimpleReferenceResolver(m.GetClient()),
-			NewNameAsExternalName(m.GetClient()),
-		},
-		ReferenceResolver: NewAPISimpleReferenceResolver(m.GetClient()),
 	}
 }