Merge pull request #77 from hasheddan/gomodfailci

Check for dirty go modules in CI

Jenkinsfile

@@ -45,6 +45,7 @@ pipeline {
                 }
             }
             steps {
+                sh './build/run make check-diff'
                 sh './build/run make vendor.check'
                 sh './build/run make -j\$(nproc) build.all'
             }

Makefile

@@ -58,7 +58,14 @@ cobertura:
 		$(GOCOVER_COBERTURA) > $(GO_TEST_OUTPUT)/cobertura-coverage.xml
 
 # Ensure a PR is ready for review.
-reviewable: vendor generate lint
+reviewable: generate lint
+	@go mod tidy
+
+# Ensure branch is clean.
+check-diff: reviewable
+	@$(INFO) checking that branch is clean
+	@git diff --quiet || $(FAIL)
+	@$(OK) branch is clean
 
 # Update the submodules, such as the common build scripts.
 submodules: