From 8f5be4134744a545e87325ca77ac4e23174eb393 Mon Sep 17 00:00:00 2001 From: Nic Cope Date: Fri, 25 Sep 2020 23:12:00 -0700 Subject: [PATCH] Have GetCredentialsSecretReference operate on pointers Credentials secrets are used by ProviderConfigs. They should be optional, since a ProviderConfig may use a form of authentication that does not involve secrets. This is a breaking API change, though I believe this interface was orphaned and not actually in use anywhere. Signed-off-by: Nic Cope --- pkg/resource/fake/mocks.go | 6 +++--- pkg/resource/interfaces.go | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pkg/resource/fake/mocks.go b/pkg/resource/fake/mocks.go index 0a84e95..e9e664d 100644 --- a/pkg/resource/fake/mocks.go +++ b/pkg/resource/fake/mocks.go @@ -133,15 +133,15 @@ func (m *Orphanable) GetDeletionPolicy() v1alpha1.DeletionPolicy { return m.Poli // CredentialsSecretReferencer is a mock that satisfies CredentialsSecretReferencer // interface. -type CredentialsSecretReferencer struct{ Ref v1alpha1.SecretKeySelector } +type CredentialsSecretReferencer struct{ Ref *v1alpha1.SecretKeySelector } // SetCredentialsSecretReference sets CredentialsSecretReference. -func (m *CredentialsSecretReferencer) SetCredentialsSecretReference(r v1alpha1.SecretKeySelector) { +func (m *CredentialsSecretReferencer) SetCredentialsSecretReference(r *v1alpha1.SecretKeySelector) { m.Ref = r } // GetCredentialsSecretReference gets CredentialsSecretReference. -func (m *CredentialsSecretReferencer) GetCredentialsSecretReference() v1alpha1.SecretKeySelector { +func (m *CredentialsSecretReferencer) GetCredentialsSecretReference() *v1alpha1.SecretKeySelector { return m.Ref } diff --git a/pkg/resource/interfaces.go b/pkg/resource/interfaces.go index 6ba5ba1..2c3851a 100644 --- a/pkg/resource/interfaces.go +++ b/pkg/resource/interfaces.go @@ -68,8 +68,8 @@ type Orphanable interface { // A CredentialsSecretReferencer may refer to a credential secret in an arbitrary // namespace. type CredentialsSecretReferencer interface { - GetCredentialsSecretReference() v1alpha1.SecretKeySelector - SetCredentialsSecretReference(r v1alpha1.SecretKeySelector) + GetCredentialsSecretReference() *v1alpha1.SecretKeySelector + SetCredentialsSecretReference(r *v1alpha1.SecretKeySelector) } // A ProviderReferencer may reference a provider resource.