Commit Graph

787 Commits

Author SHA1 Message Date
ezgidemirel 8c85120418 Fix MR state metrics when MRs are deleted
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
(cherry picked from commit 78ccb5f030)
2024-05-10 09:37:31 +00:00
Hasan Turken 8641eb2ba3
Merge pull request #683 from ezgidemirel/mr-metrics
Introduce High Level MR metrics
2024-04-24 14:46:34 +03:00
Predrag Knezevic d049fcc2e9 Address reviewer comments
Signed-off-by: Predrag Knezevic <predrag.knezevic@upbound.io>
2024-04-19 15:47:18 +02:00
ezgidemirel 249f4c09be
remove XRStateMetrics
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
2024-04-18 15:44:32 +03:00
ezgidemirel aa7264baf4
make state recorders Runnable and remove unstructured listing
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
2024-04-16 20:01:05 +03:00
ezgidemirel 4b6c2de666
add XR state metrics
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
2024-04-16 11:36:10 +03:00
Predrag Knezevic b5462b512d Add ability to expose resource reconciliation progress
* `status.observedGeneration` fields has been added to claim/composite/composed status,
  showing the latest metadata.generation which resulted in either a ready state,
  or stalled due to error it can not recover from without human intervention.
* `status.conditions[x].observedGeneration represents the .metadata.generation
  that the condition was set based upon

Signed-off-by: Predrag Knezevic <predrag.knezevic@upbound.io>
2024-04-09 11:04:31 +02:00
ezgidemirel af6588856c
change init pattern and move state metrics to a go routine
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
2024-04-08 18:48:05 +03:00
ezgidemirel 64074c3e5d
Add High Level MR metrics
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
2024-04-03 16:16:14 +03:00
Dr. Stefan Schimanski b42479383b
reconciler/managed: add crossplane_resource_drift_seconds metric
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
2024-04-02 17:18:39 +03:00
Nic Cope 0c7b1eb549 Bump golangci-lint, copy config from c/c
This copies the latest config from c/c and addresses all the linter
errors that config produces.

Signed-off-by: Nic Cope <nicc@rk0n.org>
2024-02-20 03:45:27 -08:00
Dr. Stefan Schimanski 5f2a2782ca
logging: add SetFilteredKlogLogger to show client-go throttling logs
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
2024-02-23 09:01:22 +01:00
Sergen Yalçın 195a02da31
Change the error message with a more consistent with the other errors
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
2024-02-13 16:01:25 +03:00
Sergen Yalçın b1cd25a73b
Change the error message
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
2024-02-07 11:18:55 +03:00
Sergen Yalçın 5cd11c97cb
Add a nil case to the getValueFromInterface function
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
2024-02-06 19:32:18 +03:00
Philippe Scorsolini 88865715a0
fix: add RemoveInformer to implement Informers
Co-authored-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com>
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
2024-01-31 15:05:57 +00:00
Dr. Stefan Schimanski 34c3e60a06
reconciler/managed: don't brick MR on create conflict
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
2024-01-27 16:01:56 +01:00
Dr. Stefan Schimanski 7d7a4e9273
reconciler/managed: keep trying to update critical annotation until ctx canceled
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
2024-01-27 15:59:19 +01:00
Dr. Stefan Schimanski 7f21c79d63
controller/engine: sync informers on controller start
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
2024-01-09 23:13:56 +01:00
Dr. Stefan Schimanski 1355caff8e
reconciler/managed: fix RetryingCriticalAnnotationUpdater to support namespaces
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
2024-01-05 18:23:56 +01:00
Sergen Yalçın 4e24aae89d
- Used %q in the error message
- Added a unit-test case

Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
2023-12-12 15:00:40 +03:00
Sergen Yalçın cac4c15ef3
Add a nil case to the expandWildcards function
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
2023-12-12 13:09:14 +03:00
Alper Rifat Ulucinar f1be5e62dc
Use server-side apply patch to update the resolved cross-resource references
in managed.APISimpleReferenceResolver.

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
2023-12-08 15:04:53 +03:00
Alper Rifat Ulucinar 3d34552fe9
Treat all maps & slices of zero-length equal whether they are nil or not in managed.APISimpleReferenceResolver
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
2023-12-04 18:43:59 +03:00
Philippe Scorsolini ce34a9d134
Merge pull request #613 from lsviben/od-supported-policy
Add [Observe, Delete] as a supported management policy
2023-11-30 08:22:06 +01:00
lsviben 40bf7a947d
add Observe Delete as a supported management policy
Signed-off-by: lsviben <sviben.lovro@gmail.com>
2023-11-29 15:19:51 +01:00
Evan Johnson e8a5d63058 add support for int pointer references
Signed-off-by: Evan Johnson <eljohn1014@gmail.com>
2023-11-20 12:53:09 -05:00
Philippe Scorsolini e258edd7e2
Merge pull request #580 from crossplane/renovate/golangci-golangci-lint-1.x
Update dependency golangci/golangci-lint to v1.55.2
2023-11-16 13:48:32 +01:00
Philippe Scorsolini 0467f86082
chore(linting): use getters
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
2023-11-16 12:14:24 +01:00
Nic Cope fab7762d2e Generate deepcopy methodsets for Unstructured types
Removes the tests - we don't need to test generated code.

Signed-off-by: Nic Cope <nicc@rk0n.org>
2023-11-06 16:42:57 -08:00
Nic Cope d54c6046df Give unstructured types their own DeepCopy methods
Fixes https://github.com/crossplane/crossplane/issues/4970

These types all embed *unstructured.Unstructured. If they don't
implement their own DeepCopy methods, callers will end up calling those
of the embedded *Unstructured. The result is that a deepcopy isn't a
real copy - it's the wrong type (*unstructured.Unstructured).

Signed-off-by: Nic Cope <nicc@rk0n.org>
2023-11-05 14:51:44 -08:00
Hasan Turken 9aa1024097
Fix retry in update critical annotations
- A successful get after a conflict should not hide the conflict
error and prevent retries.

Signed-off-by: Hasan Turken <turkenh@gmail.com>
2023-11-02 12:06:06 +03:00
Dr. Stefan Schimanski 8c70e452b0
Revert back to interface
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
2023-10-13 12:10:45 +02:00
Dr. Stefan Schimanski d77466ecd2
controller/engine: split controller creation and start
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
2023-10-13 11:48:06 +02:00
Dr. Stefan Schimanski 33981937cc
controller/engine: merge parent and local cache
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
2023-10-13 11:48:06 +02:00
Predrag Knezevic 81b21d47fe fix(pkg/resource/composite) drop usage of ObjectReference in SetClaimReference
`spec.claimRef` schema is just subset of corev1.ObjectReference, and hence
`SetClaimReference` might get a reference that have more fields set, e.g. UID.
The fields that do not exist in claimRef schema must be not set on the underlying object,
otherwise K8s API server complains about non-existing field when client sends a patch request.

* Introduced `claim.Reference` type that corresponds to `spec.claimRef` schema.
* `composite.SetClaimReference` signature changed to accept an instance of `claim.Reference`
* appropriate tests updated/new tests added

Signed-off-by: Predrag Knezevic <predrag.knezevic@upbound.io>
2023-10-09 13:53:55 +02:00
lsviben 3e9d757b6c
fix missing import
Signed-off-by: lsviben <sviben.lovro@gmail.com>
2023-10-03 10:04:24 +02:00
Hasan Turken 075b3d5fb8
Merge pull request #556 from sttts/sttts-silently-ignore-conflicts
errors: add SilentlyRequeueOnConflicts
2023-10-02 13:28:09 +03:00
Philippe Scorsolini c05e74a4b5
Merge pull request #540 from phisco/fix/conflict-errors-remake-2 2023-09-26 18:40:23 +02:00
Dr. Stefan Schimanski 8333c5c0bd
reconciler/managed: simplify conflict suppression with helper
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
2023-09-26 16:20:56 +02:00
Dr. Stefan Schimanski 712d0dbc69
errors: add SilentlyRequeueOnConflicts
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
2023-09-26 16:20:56 +02:00
Alper Rifat Ulucinar 95e05915a4
Do not modify the informer cache objects in resource.AnnotationChangedPredicate.Update
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
2023-09-25 15:36:17 +03:00
Philippe Scorsolini b82c293947
Merge pull request #553 from lsviben/lintable 2023-09-22 12:49:57 +02:00
lsviben 3edf846d8f
add docs
Signed-off-by: lsviben <sviben.lovro@gmail.com>
2023-09-22 11:25:03 +02:00
Philippe Scorsolini 2d96b39e1e
Merge pull request #548 from phisco/avoid-dropping-commented-lines
fix(package parser): only drop fully commented files
2023-09-21 11:39:49 +02:00
Hasan Turken 9597f2ac5a
Merge pull request #549 from lsviben/gmp-to-beta
GMP to beta
2023-09-20 16:29:02 +03:00
lsviben a6045dd880
introduce Lintable
Signed-off-by: lsviben <sviben.lovro@gmail.com>
2023-09-20 14:55:48 +02:00
lsviben 55a8c10930
gmp to beta
Signed-off-by: lsviben <sviben.lovro@gmail.com>
2023-09-20 11:46:19 +02:00
Philippe Scorsolini 6cb0b49702
refactor: switch to side effect free check
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
2023-09-19 12:53:41 +02:00
Dr. Stefan Schimanski eb74932955
controller: add TriggeredBy custom watches to engine
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@upbound.io>
2023-09-18 14:03:41 +03:00