External link fixes (#738)

* fix link to github issue

Signed-off-by: Pete Lumbis <pete@upbound.io>

* fix generated link for 'view page source'

Signed-off-by: Pete Lumbis <pete@upbound.io>

* don't strip query strings to properly check youtube links

Signed-off-by: Pete Lumbis <pete@upbound.io>

---------

Signed-off-by: Pete Lumbis <pete@upbound.io>
This commit is contained in:
Pete Lumbis 2024-04-09 10:10:29 -04:00 committed by GitHub
parent 4a1d3e6c07
commit f7e5e04966
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 5 additions and 3 deletions

View File

@ -42,7 +42,7 @@ registry.
<!-- allow "check" -->
* Fixed [an issue](https://github.com/crossplane/docs/pull/718) where mermaid
diagrams didn't display the right colors across light and dark modes.
* Added support for a "[you are here](https://github.com/crossplane/docs/pull/716")
* Added support for a "[you are here](https://github.com/crossplane/docs/pull/716)"
feature for doc page table of contents.
* Fixed the color of check marks (✔️) in dark mode.
<!-- vale Google.WordList = YES -->

View File

@ -42,7 +42,7 @@ registry.
<!-- allow "check" -->
* Fixed [an issue](https://github.com/crossplane/docs/pull/718) where mermaid
diagrams didn't display the right colors across light and dark modes.
* Added support for a "[you are here](https://github.com/crossplane/docs/pull/716")
* Added support for a "[you are here](https://github.com/crossplane/docs/pull/716)"
feature for doc page table of contents.
* Fixed the color of check marks (✔️) in dark mode.
<!-- vale Google.WordList = YES -->

View File

@ -57,7 +57,7 @@
</div>
<div>
<svg class="bi" width="1em" height="1em"><use xlink:href="#github"/></svg>
<span class="ps-1"><a href="{{printf "https://github.com/crossplane/docs/tree/master/content/%s" .Page.File}}">View page source</a></span>
<span class="ps-1"><a href="{{printf "https://github.com/crossplane/docs/tree/master/content/%s" .Page.File.Path}}">View page source</a></span>
</div>
</div>
</nav>

View File

@ -3,9 +3,11 @@ DirectoryPath: "public"
# This doesn't cause errors
IgnoreInternalEmptyHash: true
CheckExternal: false
StripQueryString: false
IgnoreURLs:
- "github.com/crossplane/docs/tree/master/content/(.*).md" # Ignore the links to "view this source"
- "www.googletagmanager.com/*" # Ignore google tag manager
- "twitter.com/*" # Ignore twitter links since they send to login page
- "https://releases.crossplane.io/stable/current/bin" # S3 bucket listing always returns 404 status even with directory listing
- "docs.crossplane.io/latest/*" # Allow links to the latest release (e.g. from knowledge-base)
- "github.com/crossplane/docs/issues/new*" # Ignore the "open an issue" link