crossplane
/
function-sdk-python
mirror of https://github.com/crossplane/function-sdk-python.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use class matches in resource.update() 

This was introduced in 3.10, and seems like a much better way to handle
matching a type.

Signed-off-by: Nic Cope <nicc@rk0n.org>
This commit is contained in:
Nic Cope 2024-10-09 17:51:26 -07:00
parent 5fe3b5c9e0
commit df655cabec
1 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
crossplane/function/resource.py
View File

@ -36,20 +36,18 @@ def update(r: fnv1.Resource, source: dict | structpb.Struct | pydantic.BaseModel
The source can be a dictionary, a protobuf Struct, or a Pydantic model. The source can be a dictionary, a protobuf Struct, or a Pydantic model.
""" """
# If the resource has a model_dump attribute it's a Pydantic BaseModel. match source:
if hasattr(source, "model_dump"): case pydantic.BaseModel():
r.resource.update(source.model_dump(exclude_defaults=True, warnings=False)) r.resource.update(source.model_dump(exclude_defaults=True, warnings=False))
return case structpb.Struct():
# TODO(negz): Use struct_to_dict and update to match other semantics?
# If the resource has a get_or_create_struct attribute it's a Struct. r.resource.MergeFrom(source)
if hasattr(source, "get_or_create_struct"): case dict():
# TODO(negz): Use struct_to_dict and update to match other semantics? r.resource.update(source)
r.resource.MergeFrom(source) case _:
return t = type(source)
msg = f"Unsupported type: {t}"
# If it has neither, it must be a dictionary. raise TypeError(msg)
r.resource.update(source)
return
def dict_to_struct(d: dict) -> structpb.Struct: def dict_to_struct(d: dict) -> structpb.Struct: