Fix check for version to contain scheduler. (#1417)

Signed-off-by: Artur Souza <asouza.pro@gmail.com>
This commit is contained in:
Artur Souza 2024-07-05 20:16:40 -07:00 committed by GitHub
parent fd1d8e85bf
commit 762e2bb4ac
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 27 additions and 1 deletions

View File

@ -176,7 +176,11 @@ func isSchedulerIncluded(runtimeVersion string) (bool, error) {
return false, err
}
return c.Check(v), nil
vNoPrerelease, err := v.SetPrerelease("")
if err != nil {
return false, err
}
return c.Check(&vNoPrerelease), nil
}
// Init installs Dapr on a local machine using the supplied runtimeVersion.

View File

@ -334,3 +334,25 @@ func TestInitLogActualContainerRuntimeName(t *testing.T) {
})
}
}
func TestIsSchedulerIncluded(t *testing.T) {
scenarios := []struct {
version string
isIncluded bool
}{
{"1.13.0-rc.1", false},
{"1.13.0", false},
{"1.13.1", false},
{"1.14.0", true},
{"1.14.0-rc.1", true},
{"1.14.0-mycompany.1", true},
{"1.14.1", true},
}
for _, scenario := range scenarios {
t.Run("isSchedulerIncludedIn"+scenario.version, func(t *testing.T) {
included, err := isSchedulerIncluded(scenario.version)
assert.NoError(t, err)
assert.Equal(t, scenario.isIncluded, included)
})
}
}