From 8e9c675bf6636285fb5ea143586167f50f7b8ce7 Mon Sep 17 00:00:00 2001 From: Pravin Pushkar Date: Wed, 1 Jun 2022 22:17:32 +0530 Subject: [PATCH] Fix for panic during upgrade of edge version dapr (#983) * Fix for panic during upgrade of edge version dapr Signed-off-by: Pravin Pushkar * change console log message Signed-off-by: Pravin Pushkar Co-authored-by: Yaron Schneider --- pkg/kubernetes/upgrade.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/pkg/kubernetes/upgrade.go b/pkg/kubernetes/upgrade.go index d543b597..2d8f2188 100644 --- a/pkg/kubernetes/upgrade.go +++ b/pkg/kubernetes/upgrade.go @@ -169,7 +169,12 @@ func upgradeChartValues(ca, issuerCert, issuerKey string, haMode, mtls bool, arg func isDowngrade(targetVersion, existingVersion string) bool { target, _ := version.NewVersion(targetVersion) - existing, _ := version.NewVersion(existingVersion) - + existing, err := version.NewVersion(existingVersion) + if err != nil { + print.FailureStatusEvent( + os.Stderr, + fmt.Sprintf("Upgrade failed, %s. The current installed version does not have sematic versioning", err.Error())) + os.Exit(1) + } return target.LessThan(existing) }