Commit Graph

5 Commits

Author SHA1 Message Date
Shubham Sharma b51eda4876
Make JSON and YAML output consistent across `list`, `components`, and `configurations` commands (#1172)
* Fix formatting

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update UT

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update UT

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update E2E

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
2023-01-19 23:23:31 -08:00
Pravin Pushkar 9d18f86768
find dapr.yaml in dirpath when dapr run -f <dirpath> is executed (#1166)
* find dapr.yaml in dirpath when dapr run -f <dirpath> is executed

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* modtidy

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* get rid of afero

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* review comments

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* review comments

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* merge fixes

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
2023-01-19 10:06:01 -08:00
Pravin Pushkar c1f9627ed6
Apps run config template parsing (#1152)
* initial commit for run template parsing

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* some code refactor.

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* add some UTs

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* call validate

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* add tests and correct err message

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* refactor Runconfig into 2 structs

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* Fix Arg parsing

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* fix UTs. make app-id be inferred from app-dir if empty

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* fix tests

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* put config reltd code into separate folder

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* merge logic for common and apps section of flags.

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* adding tests and few refactoring

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* fix tests

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* file close

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* review comments

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* fix review comments

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* refactor file names

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* resolve path to abs and add more e2e for path resolving

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* address review comments

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* remove getAppskeysmapping

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* add tests, and fix issue for setitng app id when empty.

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* fix tests

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
2023-01-03 17:19:59 +05:30
Pravin Pushkar 63f14c36f9
mariner renew-certificate fix (#1139)
* mariner renew-certificate fix

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* added UT and E2E test

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* lint fix

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* Update cmd/renew_certificate.go

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* address review commnets

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* lint fix

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* trigger pr checks

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* Update utils/utils_test.go

Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* Update utils/utils_test.go

Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* Update pkg/kubernetes/renew_certificate.go

Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* added inline comments

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* trigger pr checks

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* adding usage doc

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
2022-12-07 18:14:10 +05:30
Shubham Sharma 07cf0553dc
Validate and limit container runtime configuration in init and uninstall commands (#1099)
* Limit container runtime

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Lint

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update docs for container runtime flag

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Add uninstall e2e test

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update uninstallcmd

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Fix skip in e2e

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
2022-10-12 02:47:41 -07:00