Commit Graph

35 Commits

Author SHA1 Message Date
Josh van Leeuwen 29d29ab549
Give scheduler a default volume, making it resilient to restarts by (#1423)
* Give scheduler a default volume, making it resilient to restarts by
default

Signed-off-by: joshvanl <me@joshvanl.dev>

* Remove dapr_scheduler volume on uninstall, gated by `--all`

Signed-off-by: joshvanl <me@joshvanl.dev>

* Fix containerErrs in standaone.go

Signed-off-by: joshvanl <me@joshvanl.dev>

* Do not attempt to delete scheduler volume if no container runtime

Signed-off-by: joshvanl <me@joshvanl.dev>

* Increase upgrade test timeout to 40m

Signed-off-by: joshvanl <me@joshvanl.dev>

---------

Signed-off-by: joshvanl <me@joshvanl.dev>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
2024-07-17 12:13:51 -07:00
Cassie Coyle fd1d8e85bf
Distributed Scheduler CLI Changes (#1405)
* wip

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* rm scheduleJob logic. keep only init/uninstall logic

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>

* Fixes install and uninstall of scheduler in standalone mode.

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

* Fixing path for Go tools in Darwin.

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

* Fix Go bin location for MacOS.

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

* Fix min scheduler version to be 1.14.x

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

* Use env var to pass scheduler host.

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

* Fix CLI build to work with latest MacOS runners from GH

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

---------

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Co-authored-by: Artur Souza <asouza.pro@gmail.com>
2024-07-03 14:58:55 -07:00
Vishal Yadav a4f924f49d
Adding warning for uninstall all while container runtime not running (#1310)
Signed-off-by: Vishal Yadav <vishalydv.me@gmail.com>
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
2023-06-20 10:10:57 +05:30
Shubham Sharma 77fbc192ea
Fix checks for container runtime installation (#1307)
* Check container runtime while installing

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Fix lint

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Fix lint (another attempt)

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

---------

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
2023-06-09 11:14:23 +05:30
Tom Meadows 36a13bc55a
fixed small typo in variables and function call (#1297)
Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
2023-05-29 18:08:06 -05:00
Girish Sharma 17124ebbe9
Upgrade go version to 1.20 (#1246)
* Upgrade go version

Signed-off-by: letmerecall <girishsharma001@gmail.com>

* Upgrade go patch version to get through ci cache

Signed-off-by: letmerecall <girishsharma001@gmail.com>

* Format error message correctly

Signed-off-by: letmerecall <girishsharma001@gmail.com>

* Setup go from go.mod

Signed-off-by: letmerecall <girishsharma001@gmail.com>

* Fix workflow, checkout code before go setup

Signed-off-by: letmerecall <girishsharma001@gmail.com>

* Fix workflow

Signed-off-by: letmerecall <girishsharma001@gmail.com>

---------

Signed-off-by: letmerecall <girishsharma001@gmail.com>
Signed-off-by: Girish Sharma <girishsharma001@gmail.com>
2023-03-02 02:41:17 +05:30
Mukundan Sundararajan 56ba05982e
Upgrade linter version to the latest (#1253)
* upgrade golangci-lint version to latest

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* fix tests

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

---------

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
2023-02-28 23:43:28 +05:30
Mukundan Sundararajan a7f06c3b1b
Fix runtime custom path installation logic (#1203)
* fix dapr path version, custom  installation path logic, e2e

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* fix linter errors

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* fix paths for windows

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

* rename daprPath to daprRuntimePath

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>

---------

Signed-off-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
2023-02-05 21:57:23 -08:00
mikeb26 53dff409b4
Support environments with broken $HOME (#1057)
* Support environments with broken $HOME

Currently in standalone mode dapr cli will install the dapr runtime
binaries into $HOME/.dapr. However, in some environments $HOME is
readonly or os.UserHomeDir() can fail (e.g. AWS Lambda). To support
dapr in these environments this change does 2 things:

1. Allows the user to set DAPR_PATH environment variable to indicate
the location of the dapr runtime binaries.

2. Allows the user to optionally specify --dapr-path cli flag to
indicate the location of the dapr runtime binaries. When both
DAPR_PATH environment variable and --dapr-path CLI flag are present,
the cli flag has higher precedence.

When neither DAPR_PATH nor the --dapr-path CLI flag are present, we
fallback to existing behavior of defaulting to $HOME/.dapr.

Signed-off-by: Mike Brown <github@torvosoft.com>

* Address comments

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Address comments

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Address comments

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Fix unit test

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Fix e2e test

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Fix lint

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

Signed-off-by: Mike Brown <github@torvosoft.com>
Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
2023-01-03 15:40:06 +05:30
Pravin Pushkar 1d0a566a45
Delete remove image logic from uninstall (#1095)
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Co-authored-by: Mukundan Sundararajan <65565396+mukundansundar@users.noreply.github.com>
2022-10-11 03:01:09 -07:00
Pravin Pushkar 5a28708a12
feature/podman: Updating dapr cli to allow different container runtime (#1041)
* feature/podman: Updating dapr cli to allow providing of container
runtime.

- Ability to provide docker or podman runtime for init and uninstall commands
  by passing along the --container-runtime flag with values docker or
  podman.

Signed-off-by: Martin <7595909+martin-bucinskas@users.noreply.github.com>

* feature/podman: Updating install message to use the runtime environment

Signed-off-by: Martin <7595909+martin-bucinskas@users.noreply.github.com>

* feature/podman: Fixing linting issues.

- Fixing go lint issues by running gofumpt and gofmt.

Signed-off-by: Martin <7595909+martin-bucinskas@users.noreply.github.com>

* Correcting rebase

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* use podman for macos tests

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* setting env

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* adding docker host

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* Change step title and remove docker host

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* code cleanup

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* install podman mac helper

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* fix review comments

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* Refactor use of global varibale

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* matrix added for slim and complete  mode

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* correcting worflow expression

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* refactor uninstall code

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

* separate uninstall test for slim and complete mode

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>

Signed-off-by: Martin <7595909+martin-bucinskas@users.noreply.github.com>
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
Co-authored-by: Martin <7595909+martin-bucinskas@users.noreply.github.com>
2022-08-23 21:30:50 +05:30
tanvigour 050eb553f2
Go linter upgrade to 1.44.2 (#908)
* Go linter upgrade to 1.44

Signed-off-by: tanvigour <tanvi.gour@gmail.com>

* remove old excludes and address new ones

Signed-off-by: tanvigour <tanvi.gour@gmail.com>
2022-03-07 13:18:48 +05:30
Dmitry Shmulevich 0f9d0d3a89
replaced license headers (#855)
Signed-off-by: Dmitry Shmulevich <dmitry.shmulevich@gmail.com>
2021-12-10 08:09:09 +05:30
Mukundan Sundararajan d09b09c0dd
Remove redis-host flag, fix configs and uninstall with network flag. (#546) 2020-12-10 21:33:03 -08:00
Mukundan Sundararajan 24ca35d78b
Upgrade to linter v1.31.0 (#447)
* Upgrade to linter v1.30.0

* Remove --fix from lint

* Fix linter issues

* use golang-ci lint action

* Fix linter version

* add linter patch version

* remove linter patch version
2020-10-07 17:24:12 -07:00
Aman Bhardwaj 2a4123efaf
Change init and uninstall behavior for self hosted mode (#413)
* remove install-path option for dapr init copy bianries under $HOME/.dapr/bin
2020-07-22 14:47:57 -07:00
Mukundan Sundararajan 5ba8e9ab39
Fix messages on init and uninstall (#392) 2020-07-13 16:50:51 -07:00
Mukundan Sundararajan ff2d5dd482
Initialize dapr without docker dependency (#386)
* Initialize dapr without docker dependency

* Create default empty components dir

* Remove --slim flag from uninstall command

* Changed phrasing

* Updated Readme

* Clarify slim init use case

* language corrections

Co-authored-by: Mark Chmarny <mchmarny@users.noreply.github.com>
Co-authored-by: Ori Zohar <orzohar@microsoft.com>
2020-07-10 16:32:45 -07:00
Mukundan Sundararajan 0b76467280
Fix Standalone dapr init behavior. (#384)
* Remove uninstall all from init path. Add install path arg to uninstall cmd. Cleanup binaries, archive correctly.

* Addressed review comments

* Change readme

* update readme
2020-06-29 15:27:59 -07:00
Mukundan Sundararajan a82a7487b5
Add Zipkin on dapr init. Add tracing config, zipkin component on init. (#377)
* Add Zipkin on dapr init. Add tracing config, zipkin component on initial run.

* Fix uninstallAll check

* Move zipkin config to init

* Default run parameter for config

* Updated Readme and dapr run reference

* Address review comments.

* Updated Readme, cli reference

* Address review comments

* Change uninstall cli ref doc
2020-06-22 09:25:10 -07:00
Aman Bhardwaj a9a8bc3ac2
passing components folder to daprd (#367)
* passing components folder to daprd

* fixing tests

* fixing tests

* using cli flag to set default value for components path

* fixing build

* linter

* linter

* fixing tests
2020-06-05 21:33:57 -07:00
vinayada1 9da489ba6e fix review comments 2020-06-03 09:54:03 -07:00
vinayada1 04ba665313 Add tests and remove debug logs 2020-05-29 16:15:30 -07:00
Vinaya Damle 9fee955548 Changes to fix the homepath dir on windows 2020-05-29 12:05:46 -07:00
vinayada1 8df8a716ca use home dir to create default components folder 2020-05-29 11:26:26 -07:00
vinayada1 57e20ceb57 tested on mac 2020-05-28 13:19:40 -07:00
Sashi Kumar cbe46b1eb1 Check if docker is running on uninstall (#334)
* Check if docker is running on uninstall

* Add comment for exported method

* Call DeleteRunDataFile even if docker is not running

* Refactor: Move to common method and rename container to image
2020-05-15 13:26:07 -07:00
Sashi Kumar 6cba4a47f3
More verbose log on failure of container uninstall (#333) 2020-05-14 13:01:16 -07:00
Leon Mai 9f74353200
Delete rundata file on uninstall (#274)
* Delete rundata file on uninstall

* reorder

* correct print
2020-02-19 13:08:16 -08:00
Abhishek Gupta 8699ed9a8a
Checking containers are running before "dapr init" (#226)
* checking containers are running before dapr init

* updated impl

* removed constraint for placement container

* updated RunCmdAndWait and refactored

* fix lint issues

* fix linter

* correction

Co-authored-by: Young Bu Park <youngp@microsoft.com>
2020-02-11 11:30:58 -08:00
Young Bu Park f84566fb2b
Enable linter and fix all linter errors (#241)
* Enable golangci linter

* remove gomnd

* upgrade golang lint

* upgrade go to 1.13.7

* fix messages

Co-authored-by: Yaron Schneider <yaronsc@microsoft.com>
2020-02-03 09:07:32 -08:00
Yaron Schneider 228e5bea5e
remove Dapr placement image on uninstall and init (#204) 2019-11-12 14:29:52 -08:00
Phillip Hoff 997ab8ce38 Allow installation of Dapr runtime into a specific Docker network (#192)
* Allow option to specify Docker network for containers.

* Add network aliases when on a specific network

* Allow Redis and placement server hosts be specified

* Don't expose container ports when on explicit network

* Use a network-specific container name.

* Update docs.

* Update per PR feedback.
2019-11-06 10:17:55 -08:00
Leon Mai ef9c854563
dapr uninstall should remove all containers (#184)
* dapr uninstall should remove all containers

* Delete redis container only if user specifies --all
2019-10-28 12:16:49 -07:00
Young Bu Park e9e261a420 Merge release-0.4 to master (#141)
* Enable uninstall to remove placement container for standalone mode (#120)

* Uninstall placement container in standalone

* fix lint error

* remove useless logging

* simplify more

* Add v0.4.0-alpha.2 rel note (#125)

* add 0.4.0-alpha.2 release note

* add changes

* wip
2019-10-11 16:22:34 -07:00