dapr
/
components-contrib
mirror of https://github.com/dapr/components-contrib.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use consumerID for queue name (#99) 

* use consumerID for queue name

* update tests
This commit is contained in:
Yaron Schneider 2019-11-04 11:42:21 -08:00 committed by GitHub
parent 34e1757740
commit 718a51ff40
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pubsub/nats/nats.go
View File

@ -15,8 +15,8 @@ import (
)
const (
natsURL = "natsURL"
natsQueueGroupName = "natsQueueGroupName"
natsURL = "natsURL"
consumerID = "consumerID"
)
type natsPubSub struct {
@ -37,7 +37,7 @@ func parseNATSMetadata(meta pubsub.Metadata) (metadata, error) {
return m, errors.New("nats error: missing nats URL")
}
if val, ok := meta.Properties[natsQueueGroupName]; ok && val != "" {
if val, ok := meta.Properties[consumerID]; ok && val != "" {
m.natsQueueGroupName = val
} else {
return m, errors.New("nats error: missing queue name")

14
pubsub/nats/nats_test.go
View File

@ -17,8 +17,8 @@ import (
func TestParseNATSMetadata(t *testing.T) {
t.Run("metadata is correct", func(t *testing.T) {
fakeProperties := map[string]string{
natsURL: "foonats1",
natsQueueGroupName: "fooq1",
natsURL: "foonats1",
consumerID: "fooq1",
}
fakeMetaData := pubsub.Metadata{
Properties: fakeProperties,
@ -32,13 +32,13 @@ func TestParseNATSMetadata(t *testing.T) {
assert.NotEmpty(t, m.natsURL)
assert.NotEmpty(t, m.natsQueueGroupName)
assert.Equal(t, fakeProperties[natsURL], m.natsURL)
assert.Equal(t, fakeProperties[natsQueueGroupName], m.natsQueueGroupName)
assert.Equal(t, fakeProperties[consumerID], m.natsQueueGroupName)
})
t.Run("queue is not given", func(t *testing.T) {
fakeProperties := map[string]string{
natsURL: "foonats2",
natsQueueGroupName: "",
natsURL: "foonats2",
consumerID: "",
}
fakeMetaData := pubsub.Metadata{
@ -55,8 +55,8 @@ func TestParseNATSMetadata(t *testing.T) {
t.Run("nats url is not given", func(t *testing.T) {
fakeProperties := map[string]string{
natsURL: "",
natsQueueGroupName: "fooq2",
natsURL: "",
consumerID: "fooq2",
}
fakeMetaData := pubsub.Metadata{
Properties: fakeProperties,