Use AzureKeyVaultName param for Azure Keyvault conformance test (#975)

Unlike the other conformance tests, the azure-keyvault.yaml config hardcodes the name of the
target resource which creates an issue for contributors wanting to set up their own test
environments. For example, different users sharing an Azure subscription may not be able
to manage the permissions on the target key vault individually, and will need to edit the
yaml to retarget against their own keyvault instance.

- Add `AzureKeyVaultName` environment variable as the value for `vaultName` in azure-keyvault.yaml
- Update conformance.yml github workflow to require AzureKeyVaultName secret.
This commit is contained in:
Simon Leet 2021-07-07 12:04:50 -07:00 committed by GitHub
parent ff65172407
commit 830f6ee3ed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions

View File

@ -87,7 +87,7 @@ jobs:
- component: bindings.azure.storagequeues
required-secrets: AzureBlobStorageAccessKey,AzureBlobStorageAccount,AzureBlobStorageQueue
- component: secretstores.azure.keyvault
required-secrets: AzureKeyVaultSecretStoreTenantId,AzureKeyVaultSecretStoreClientId
required-secrets: AzureKeyVaultName,AzureKeyVaultSecretStoreTenantId,AzureKeyVaultSecretStoreClientId
required-certs: AzureKeyVaultSecretStoreCert
EOF
)

View File

@ -6,7 +6,7 @@ spec:
type: secretstores.azure.keyvault
metadata:
- name: vaultName
value: secretstore-keyvault
value: ${{AzureKeyVaultName}}
- name: spnTenantId
value: ${{AzureKeyVaultSecretStoreTenantId}}
- name: spnClientId