From 90b43f3adf077dc13da68117d66ad203cf7b0341 Mon Sep 17 00:00:00 2001 From: Mike Nguyen Date: Fri, 25 Jul 2025 18:30:11 +0100 Subject: [PATCH] fix(bindings.s3): pathstyle logic and region debug region Signed-off-by: Mike Nguyen --- bindings/aws/s3/s3.go | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/bindings/aws/s3/s3.go b/bindings/aws/s3/s3.go index 0846b929d..39e26dfd1 100644 --- a/bindings/aws/s3/s3.go +++ b/bindings/aws/s3/s3.go @@ -136,15 +136,23 @@ func (s *AWSS3) Init(ctx context.Context, metadata bindings.Metadata) error { var s3Options []func(options *s3.Options) + if s.metadata.Region != "" { + s3Options = append(s3Options, func(options *s3.Options) { + options.Region = s.metadata.Region + }) + } + + // TODO: Double check this config if s.metadata.DisableSSL { s3Options = append(s3Options, func(options *s3.Options) { options.EndpointOptions.DisableHTTPS = true }) } - if !s.metadata.ForcePathStyle { + if s.metadata.ForcePathStyle { s3Options = append(s3Options, func(options *s3.Options) { options.UsePathStyle = true + options.EndpointOptions.ResolvedRegion = s.metadata.Region }) } @@ -174,6 +182,8 @@ func (s *AWSS3) Init(ctx context.Context, metadata bindings.Metadata) error { s.s3PresignClient = s3.NewPresignClient(s.s3Client) + s.logger.Debugf("s3 binding: initialized with region %s", s.s3Client.Options().Region) + return nil }