Adding and Correcting code comments and types

This commit is contained in:
shalabhs 2019-10-10 18:09:13 -07:00
parent 04bef3ac3f
commit ae8c77f43b
4 changed files with 7 additions and 5 deletions

View File

@ -15,12 +15,12 @@ import (
) )
const ( const (
corellationID = "corellationID" correlationID = "correlationID"
label = "label" label = "label"
id = "id" id = "id"
) )
// AzureServiceBusQueues is an input/outbput binding reading from and sending events to Azure Service Bus queues // AzureServiceBusQueues is an input/output binding reading from and sending events to Azure Service Bus queues
type AzureServiceBusQueues struct { type AzureServiceBusQueues struct {
metadata *serviceBusQueuesMetadata metadata *serviceBusQueuesMetadata
client *servicebus.Queue client *servicebus.Queue
@ -79,7 +79,7 @@ func (a *AzureServiceBusQueues) Write(req *bindings.WriteRequest) error {
if val, ok := req.Metadata[id]; ok && val != "" { if val, ok := req.Metadata[id]; ok && val != "" {
msg.ID = val msg.ID = val
} }
if val, ok := req.Metadata[corellationID]; ok && val != "" { if val, ok := req.Metadata[correlationID]; ok && val != "" {
msg.CorrelationID = val msg.CorrelationID = val
} }
err := a.client.Send(ctx, msg) err := a.client.Send(ctx, msg)
@ -90,7 +90,7 @@ func (a *AzureServiceBusQueues) Read(handler func(*bindings.ReadResponse) error)
var sbHandler servicebus.HandlerFunc = func(ctx context.Context, msg *servicebus.Message) error { var sbHandler servicebus.HandlerFunc = func(ctx context.Context, msg *servicebus.Message) error {
err := handler(&bindings.ReadResponse{ err := handler(&bindings.ReadResponse{
Data: msg.Data, Data: msg.Data,
Metadata: map[string]string{id: msg.ID, corellationID: msg.CorrelationID, label: msg.Label}, Metadata: map[string]string{id: msg.ID, correlationID: msg.CorrelationID, label: msg.Label},
}) })
if err == nil { if err == nil {
return msg.Complete(ctx) return msg.Complete(ctx)

View File

@ -12,7 +12,7 @@ import (
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
) )
func TestRetriPolicies(t *testing.T) { func TestRetryPolicies(t *testing.T) {
t.Run("set with no options", func(t *testing.T) { t.Run("set with no options", func(t *testing.T) {
counter := 0 counter := 0
SetWithRetries(func(req *SetRequest) error { SetWithRetries(func(req *SetRequest) error {

View File

@ -5,6 +5,7 @@
package state package state
// StateStore is an interface to perform operations on store
type StateStore interface { type StateStore interface {
Init(metadata Metadata) error Init(metadata Metadata) error
Delete(req *DeleteRequest) error Delete(req *DeleteRequest) error

View File

@ -5,6 +5,7 @@
package state package state
// TransactionalStateStore is an interface for initialization and support multiple transactional requests
type TransactionalStateStore interface { type TransactionalStateStore interface {
Init(metadata Metadata) error Init(metadata Metadata) error
Multi(reqs []TransactionalRequest) error Multi(reqs []TransactionalRequest) error