This commit is related to dapr/dapr#4624. As noted there, we have an issue in the runtime where all components are shut down after the grace period, when the app is likely already stopped. Because of that, certain input components (the subscribe part of pubsub and the input part of bindings - the latter not in scope of this PR), can continue bringing new work when it's known to fail.
In order to fix the issue linked above properly, we need to implement a way for PubSub components to have the "publish" part closed before the "subscribe" one (and in the future that will need to be done for input bindings too).
This commit achieves precisely that by adding a context in the Subscribe method. When that context is canceled (which can be at any time), the subscription is removed.
PS: This API change was implemented so it can one day be used for dapr/dapr#814 too, as it allows canceling individual subscriptions by using a different context. Although that's not possible today because it requires more work on the runtime, it does implement everything that's needed in the pubsub components already.
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
* Fix race in pulsar pubsub component
* fix lint
Co-authored-by: Phil Kedy <phil.kedy@gmail.com>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
* no message
* Switching over usages of retry to the new package and making use of the DecodeConfig function
* Added decoding configuration using settings with a specific prefix
* Linter fixes
* Fixing linter error
* time.Sleep is the enemy
* Fix typo in comment
* Moving config to a pointer parameter so that the component can pass in the config with default values that make sense for that component.
* Renamed config struct
* Fix comment
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
* Improve pulsar publisher performance.
* Addressed comments and added some debug logs
* Use peek instead of get for closing producers
* Fixed lint issue
* Added debug log in close
* Change back o 100
* Close producer before client
* Fixed cached number of producer and added todo for making it configurable
Co-authored-by: Yaron Schneider <yaronsc@microsoft.com>
* Improve conformance tests and add pulsar
* Fix linter error
* Fix linter errors
* Tweaks to pulsar pubsub per PR
* Switching uuid import
* Using Stringer interface to print message keys as base64 in logger
* Disabling some checks w/ Redis pubsub until the component can be enhanced
* Adding comment to eventually remove the simulateErrors option
* Add comment asBase64String to explain what it does
* Adding redelivery (reclaims) to the Redis pubsub component
Removed the temporary simulateErrors flag now that Redis is passing
* Fixing linter issues
* using a wait group instead of a sleep to wait for processing to complete
* More comments and refactoring
* comment tweaks
* Tweaks per PR
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
* created pulsar component
* fixed multi topic issue
* moved metadata struct
* finished writing metadata tests
* fixed linter issues
* modifies consumer type to failover
* uncapitalized errors
* changed subscriptionName to consumerID
* acknowledge message only if there's no error returned from handler
Co-authored-by: john verdonck <John@johns-MacBook-Pro.local>
ItalyPaleAle
saber-wang
pigletfly
saberwang
1046102779
Dmitry Shmulevich
Taction
Long Dai
Phil Kedy
Xueqian Wang
Joni Collinge
Artur Souza
Yaron Schneider
halspang
Kyle Housley
John